|
Thread Rules 1. This is not a "do my homework for me" thread. If you have specific questions, ask, but don't post an assignment or homework problem and expect an exact solution. 2. No recruiting for your cockamamie projects (you won't replace facebook with 3 dudes you found on the internet and $20) 3. If you can't articulate why a language is bad, don't start slinging shit about it. Just remember that nothing is worse than making CSS IE6 compatible. 4. Use [code] tags to format code blocks. |
Oh, the code I showed wasn't supposed to be C#, just how I'd do it in C/++. I thought about this;
foreach (int i in arrayA) { foreach (int ii in arrayB) { if (i == ii) return true; } }
But it would seem natural for i and ii to be the indexes rather than the values. Maybe I'm too used to references in C++. arrayA[i] would make more sense, y'know? 
About this:
return arrayA.Intersect(arrayB).Count()>0 You're saying I can't Console.WriteLine(function()) if function returns the above code? The result has to be stored in a buffer first, is that what you mean by "doesn't support early out"?
|
On July 13 2010 00:00 Adeny wrote: However in C# I'm sitting on two arraylists (whatever the hell that is)]
An ArrayList is a list which uses a backing array (as opposed to a non-array backed list, such as a linked list). There are many types of list which have the same functionality but are handled it in a completely different way. All lists are self expanding, they can be iterated through, and their indexes manually accessed and modified, much like an array.
In OOP you should always try to hide as much information as possible (use encapsulation), in order to reduce side-effects, de-couple and simplify your code. With the case of the ArrayList, when you instantiate an ArrayList, you should use a List variable (as MasterOfChaos said). You can do this by type-casting (down casts such as ArrayList->List are automatic), it part of a principle of OOP called polymorphism.
This means other programmers won't know whether it is a LinkedList or an ArrayList, which means he/she can't make assumptions on its functionality. This is good because it means you can switch from a LinkedList to an ArrayList without any problems if you need to later on.
|
See how confusing that is? Think I got it though, checking out LINQ and it's some really funky stuff.
var lowNums = from n in numbers where n < 5 select n;
SQL-syntax for C#...
|
So, I figured I would share.
VBA Excel Macro coding...is the devil.
|
On July 13 2010 00:00 Adeny wrote:C# question time! in C++ i would do this: if (a[i] == b[ii]). However in C# I'm sitting on two arraylists (whatever the hell that is), and I want to loop through both of them the way you'd solved one of the bike-locks with codes... 001, 002, 003 etc. which I'd usually do by nesting for loops, i < 9, ii < 9 and so on... I don't know if I'm making any sense. Let's try again, what I'm looking for is a replacement to this, but with arraylists; for (int i = 0; i < 9; i++) { for (int ii = 0; ii < 9; ii++) { if (arrayA[i] == arrayB[ii]) return true; } }
List<int> list1 = new List<int>(); List<int> list2 = new List<int>();
//add whatever you want to lists i.e. list1.add(3)
foreach (int i in list1) {
foreach (int y in list2) { if (i == y) { return true; } }
}
I hope this helps! : ) This might help as well : http://msdn.microsoft.com/en-us/library/d9hw1as6.aspx
|
+ Show Spoiler +On July 13 2010 00:27 Adeny wrote:Oh, the code I showed wasn't supposed to be C#, just how I'd do it in C/++. I thought about this; foreach (int i in arrayA) { foreach (int ii in arrayB) { if (i == ii) return true; } }
But it would seem natural for i and ii to be the indexes rather than the values. Maybe I'm too used to references in C++. arrayA[i] would make more sense, y'know?  About this: return arrayA.Intersect(arrayB).Count()>0 You're saying I can't Console.WriteLine(function()) if function returns the above code? The result has to be stored in a buffer first, is that what you mean by "doesn't support early out"?
I didn't see this post until after I was done writing it : P.
|
On July 13 2010 00:57 Schamus wrote: So, I figured I would share.
VBA Excel Macro coding...is the devil.
I completely agree. This is actually what I do for my day job at the moment. VBA macros and user forms for excel. If I had a choice I would be using .NET but alas my company does not have the funds.
|
Sanya12364 Posts
On July 13 2010 00:27 Adeny wrote:Oh, the code I showed wasn't supposed to be C#, just how I'd do it in C/++. I thought about this; foreach (int i in arrayA) { foreach (int ii in arrayB) { if (i == ii) return true; } }
But it would seem natural for i and ii to be the indexes rather than the values. Maybe I'm too used to references in C++. arrayA[i] would make more sense, y'know?  About this: return arrayA.Intersect(arrayB).Count()>0 You're saying I can't Console.WriteLine(function()) if function returns the above code? The result has to be stored in a buffer first, is that what you mean by "doesn't support early out"?
An "early out" is a fast termination sequence without having to brute force through the entire for loop (worst case). When you don't have an "early out" you completely go through your loops.
In your code, the worst case is when you have no matches - the code goes through both for loops completely. The best cases is when the first member of A matches the first member of B - it only looks at one comparison before terminating with an answer.
|
Germany2896 Posts
On July 13 2010 00:29 sluggaslamoo wrote:Show nested quote +On July 13 2010 00:00 Adeny wrote: However in C# I'm sitting on two arraylists (whatever the hell that is)] An ArrayList is a list which uses a backing array (as opposed to a non-array backed list, such as a linked list). There are many types of list which have the same functionality but are handled it in a completely different way. All lists are self expanding, they can be iterated through, and their indexes manually accessed and modified, much like an array. In OOP you should always try to hide as much information as possible (use encapsulation), in order to reduce side-effects, de-couple and simplify your code. With the case of the ArrayList, when you instantiate an ArrayList, you should use a List variable (as MasterOfChaos said). You can do this by type-casting (down casts such as ArrayList->List are automatic), it part of a principle of OOP called polymorphism. This means other programmers won't know whether it is a LinkedList or an ArrayList, which means he/she can't make assumptions on its functionality. This is good because it means you can switch from a LinkedList to an ArrayList without any problems if you need to later on.
Both ArrayList and List are backed by arrays, and neither derives from the other. The main difference is that List<T> is generic and ArrayList isn't. So List<object> is pretty much the same as ArrayList. IMO ArrayList is obsolete since .net 2.0.
You can hide information by using IList, ICollection or IEnumerable. But a typical linked list wouldn't implement IList either, since indexed access is O(n) for linked list.
And I there is an easy way to give my linq statement early out behavior:
return arrayA.Intersect(arrayB).Take(1).Count()>0 It probably evaluates one of the sides, puts it in a hashtable and then lazily evaluates the other side. So the average case runtime is something like O(arrayA.Count+arrayB.Count) provided the hashes are evenly distributed. Your code on the other hand is O(arrayA.Count*arrayB.Count), which is much slower for large lists.
edit: changed Limit to Take, I always mix that up
|
On July 13 2010 02:11 MasterOfChaos wrote:Show nested quote +On July 13 2010 00:29 sluggaslamoo wrote:On July 13 2010 00:00 Adeny wrote: However in C# I'm sitting on two arraylists (whatever the hell that is)] An ArrayList is a list which uses a backing array (as opposed to a non-array backed list, such as a linked list). There are many types of list which have the same functionality but are handled it in a completely different way. All lists are self expanding, they can be iterated through, and their indexes manually accessed and modified, much like an array. In OOP you should always try to hide as much information as possible (use encapsulation), in order to reduce side-effects, de-couple and simplify your code. With the case of the ArrayList, when you instantiate an ArrayList, you should use a List variable (as MasterOfChaos said). You can do this by type-casting (down casts such as ArrayList->List are automatic), it part of a principle of OOP called polymorphism. This means other programmers won't know whether it is a LinkedList or an ArrayList, which means he/she can't make assumptions on its functionality. This is good because it means you can switch from a LinkedList to an ArrayList without any problems if you need to later on. Both ArrayList and List are backed by arrays, and neither derives from the other. The main difference is that List<T> is generic and ArrayList isn't. So List<object> is pretty much the same as ArrayList. IMO ArrayList is obsolete since .net 2.0. You can hide information by using IList, ICollection or IEnumerable. But a typical linked list wouldn't implement IList either, since indexed access is O(n) for linked list. And I there is an easy way to give my linq statement early out behavior: return arrayA.Intersect(arrayB).Limit(1).Count()>0 It probably evaluates one of the sides, puts it in a hashtable and then lazily evaluates the other side. So the average case runtime is something like O(arrayA.Count+arrayB.Count) provided the hashes are evenly distributed. Your code on the other hand is O(arrayA.Count*arrayB.Count), which is much slower for large lists.
Lists in Java and C# arent backed by arrays, they are objects with references to the next object.
|
On July 13 2010 01:54 TanGeng wrote:Show nested quote +On July 13 2010 00:27 Adeny wrote:Oh, the code I showed wasn't supposed to be C#, just how I'd do it in C/++. I thought about this; foreach (int i in arrayA) { foreach (int ii in arrayB) { if (i == ii) return true; } }
But it would seem natural for i and ii to be the indexes rather than the values. Maybe I'm too used to references in C++. arrayA[i] would make more sense, y'know?  About this: return arrayA.Intersect(arrayB).Count()>0 You're saying I can't Console.WriteLine(function()) if function returns the above code? The result has to be stored in a buffer first, is that what you mean by "doesn't support early out"? An "early out" is a fast termination sequence without having to brute force through the entire for loop (worst case). When you don't have an "early out" you completely go through your loops. In your code, the worst case is when you have no matches - the code goes through both for loops completely. The best cases is when the first member of A matches the first member of B - it only looks at one comparison before terminating with an answer. Gotcha, thanks for the explanation.
|
On July 13 2010 02:18 Catch]22 wrote:Show nested quote +On July 13 2010 02:11 MasterOfChaos wrote:On July 13 2010 00:29 sluggaslamoo wrote:On July 13 2010 00:00 Adeny wrote: However in C# I'm sitting on two arraylists (whatever the hell that is)] An ArrayList is a list which uses a backing array (as opposed to a non-array backed list, such as a linked list). There are many types of list which have the same functionality but are handled it in a completely different way. All lists are self expanding, they can be iterated through, and their indexes manually accessed and modified, much like an array. In OOP you should always try to hide as much information as possible (use encapsulation), in order to reduce side-effects, de-couple and simplify your code. With the case of the ArrayList, when you instantiate an ArrayList, you should use a List variable (as MasterOfChaos said). You can do this by type-casting (down casts such as ArrayList->List are automatic), it part of a principle of OOP called polymorphism. This means other programmers won't know whether it is a LinkedList or an ArrayList, which means he/she can't make assumptions on its functionality. This is good because it means you can switch from a LinkedList to an ArrayList without any problems if you need to later on. Both ArrayList and List are backed by arrays, and neither derives from the other. The main difference is that List<T> is generic and ArrayList isn't. So List<object> is pretty much the same as ArrayList. IMO ArrayList is obsolete since .net 2.0. You can hide information by using IList, ICollection or IEnumerable. But a typical linked list wouldn't implement IList either, since indexed access is O(n) for linked list. And I there is an easy way to give my linq statement early out behavior: return arrayA.Intersect(arrayB).Limit(1).Count()>0 It probably evaluates one of the sides, puts it in a hashtable and then lazily evaluates the other side. So the average case runtime is something like O(arrayA.Count+arrayB.Count) provided the hashes are evenly distributed. Your code on the other hand is O(arrayA.Count*arrayB.Count), which is much slower for large lists. Lists in Java and C# arent backed by arrays, they are objects with references to the next object.
In java a List is simply an interface. You cannot instantiate a List.
|
Finished Project Euler's 23, but it's slow as ASS. http://pastie.org/1041271 . Ran for hours, anyone have a suggestion for a better algorithm?
Edit: Left an extra arraylist in there from a previous attempt. Edit2: Took that out, re-ran it because why not... It's a lot faster now, what? It was only a declaration. Edit3: Maybe I'm just an idiot, I had a lot of programs running earlier...
|
On July 13 2010 02:18 Catch]22 wrote:Show nested quote +On July 13 2010 02:11 MasterOfChaos wrote:On July 13 2010 00:29 sluggaslamoo wrote:On July 13 2010 00:00 Adeny wrote: However in C# I'm sitting on two arraylists (whatever the hell that is)] An ArrayList is a list which uses a backing array (as opposed to a non-array backed list, such as a linked list). There are many types of list which have the same functionality but are handled it in a completely different way. All lists are self expanding, they can be iterated through, and their indexes manually accessed and modified, much like an array. In OOP you should always try to hide as much information as possible (use encapsulation), in order to reduce side-effects, de-couple and simplify your code. With the case of the ArrayList, when you instantiate an ArrayList, you should use a List variable (as MasterOfChaos said). You can do this by type-casting (down casts such as ArrayList->List are automatic), it part of a principle of OOP called polymorphism. This means other programmers won't know whether it is a LinkedList or an ArrayList, which means he/she can't make assumptions on its functionality. This is good because it means you can switch from a LinkedList to an ArrayList without any problems if you need to later on. Both ArrayList and List are backed by arrays, and neither derives from the other. The main difference is that List<T> is generic and ArrayList isn't. So List<object> is pretty much the same as ArrayList. IMO ArrayList is obsolete since .net 2.0. You can hide information by using IList, ICollection or IEnumerable. But a typical linked list wouldn't implement IList either, since indexed access is O(n) for linked list. And I there is an easy way to give my linq statement early out behavior: return arrayA.Intersect(arrayB).Limit(1).Count()>0 It probably evaluates one of the sides, puts it in a hashtable and then lazily evaluates the other side. So the average case runtime is something like O(arrayA.Count+arrayB.Count) provided the hashes are evenly distributed. Your code on the other hand is O(arrayA.Count*arrayB.Count), which is much slower for large lists. Lists in Java and C# arent backed by arrays, they are objects with references to the next object.
You're wrong.
http://download.oracle.com/docs/cd/E17476_01/javase/1.4.2/docs/api/java/util/ArrayList.html
Resizable-array implementation of the List interface. http://msdn.microsoft.com/en-us/library/6sh2ey19.aspx
The List(Of T) class is the generic equivalent of the ArrayList class. It implements the IList(Of T) generic interface using an array whose size is dynamically increased as required.
Please actually know this stuff before stating it as fact, it makes things a lot less confusing for newcomers.
|
whoa, stuff happening itt
The most idiomatic C# way to write that is this (for the naive n*m algorithm):
return arrayA.Any(x => arrayB.Contains(x));
Or for the intersection method, which as surmised does put one list into a hashtable first:
return arrayA.Intersect(arrayB).Any(); // .Any() short-circuits, unlike Count()
I don't know where the above poster pulled the Enumerable.Limit() function out from; it's not a framework function.
Project Euler guy: Your function for grabbing divisors is unnecessarily slow. You only need to search up to sqrt(n) for potential divisors, not all the way up to N -- when you pick up on a divisor you can automatically add the corresponding divisor that multiplies with it to N. That's the easiest way to improve it significantly. I don't remember what that problem actually is, but I'll check it out after work and see if I can think of anything else -- the PE problems often admit clever mathematical solutions. (Although I do know there's no known fast method to enumerate all perfect/deficient/abundant numbers in general.)
|
Some of the other solutions on project euler inspired me, I think I'll re-do it completely for an acceptable completion time.
|
On July 13 2010 02:11 MasterOfChaos wrote:Show nested quote +On July 13 2010 00:29 sluggaslamoo wrote:On July 13 2010 00:00 Adeny wrote: However in C# I'm sitting on two arraylists (whatever the hell that is)] An ArrayList is a list which uses a backing array (as opposed to a non-array backed list, such as a linked list). There are many types of list which have the same functionality but are handled it in a completely different way. All lists are self expanding, they can be iterated through, and their indexes manually accessed and modified, much like an array. In OOP you should always try to hide as much information as possible (use encapsulation), in order to reduce side-effects, de-couple and simplify your code. With the case of the ArrayList, when you instantiate an ArrayList, you should use a List variable (as MasterOfChaos said). You can do this by type-casting (down casts such as ArrayList->List are automatic), it part of a principle of OOP called polymorphism. This means other programmers won't know whether it is a LinkedList or an ArrayList, which means he/she can't make assumptions on its functionality. This is good because it means you can switch from a LinkedList to an ArrayList without any problems if you need to later on. Both ArrayList and List are backed by arrays, and neither derives from the other. The main difference is that List<T> is generic and ArrayList isn't. So List<object> is pretty much the same as ArrayList. IMO ArrayList is obsolete since .net 2.0. You can hide information by using IList, ICollection or IEnumerable. But a typical linked list wouldn't implement IList either, since indexed access is O(n) for linked list. And I there is an easy way to give my linq statement early out behavior: return arrayA.Intersect(arrayB).Limit(1).Count()>0 It probably evaluates one of the sides, puts it in a hashtable and then lazily evaluates the other side. So the average case runtime is something like O(arrayA.Count+arrayB.Count) provided the hashes are evenly distributed. Your code on the other hand is O(arrayA.Count*arrayB.Count), which is much slower for large lists.
Sorry for some reason I was thinking about Java. In Java, List is IList, and ArrayList is List. 
Another thing I often forget with C# is that LinkedList implements IList in Java and not in C#. My biggest gripe with C# is it doesn't slavishly follow OO principles, LinkedList should really implement IList. It does implement ICollection but ICollection doesn't have the functionality to required to be useful in most situations, where as IList does.
Not using the interface allows programmers to make assumptions about the List object, and end up making code maintenance harder (or impossible) in the long-run. In OO you should always access interfaces, rather than concrete classes. It is up to the original programmer to decide whether the List should be optimised for indexing or expanding. Everyone else should just view it as a list and not refer Big O to decide how the List is going to be used (the goal of OOP is easier code maintenance, not performance ). This way if the business rules change, and indexing becomes more crucial (and for example you make a more optimised concrete list class), you could switch the concrete class without any problems.
|
I see your point of view, but I have to disagree. I think that a valuable piece of information communicated by your return type (or your parameter type) is what "kind" of thing you are returning, in a general sense. If I am returning an IList, which implements an indexer, that really implies that the indexer is going to be constant time, because that's the example set by all the other IList implementations. Similarly, if you have an ISet, you expect Contains to be at least better than linear. I don't think there's anything wrong with having conventions like that, and it helps communicate things that you would have to put in a comment otherwise.
|
|
On July 13 2010 12:56 catamorphist wrote: I see your point of view, but I have to disagree. I think that a valuable piece of information communicated by your return type (or your parameter type) is what "kind" of thing you are returning, in a general sense. If I am returning an IList, which implements an indexer, that really implies that the indexer is going to be constant time, because that's the example set by all the other IList implementations. Similarly, if you have an ISet, you expect Contains to be at least better than linear. I don't think there's anything wrong with having conventions like that, and it helps communicate things that you would have to put in a comment otherwise.
But again you are making assumptions about List when you should be looking at it at face value. The "kind" of thing being returned is a List. Programmers shouldn't have to look at the code of every type of List class to find a pattern and then derive its usage based on that, it just over-complicates programming. A List is simply a list, you look at the methods of list, which tells you what it can do, that is all you need to know. If you start thinking in this manner, programming becomes much much simpler. One principle of OOP is encapsulation, part of of this principle involves encapsulating code.
Design patterns often (if not always) use this method (a simple example is the factory pattern), it is not just my opinion, it is a best practice. The problem may be that I am using Lists as an example, where the results are clearly obvious from research on data-structures. What happens though, when you are programming for a company that has its own libraries?
Wouldn't I be a much more efficient programmer if I could just look at the interface to find out how to use it, rather than looking at every concrete class its based on and have to figure out which one is the best, and how to best use it? 
|
|
|
|