• Log InLog In
  • Register
Liquid`
Team Liquid Liquipedia
EDT 03:05
CEST 09:05
KST 16:05
  • Home
  • Forum
  • Calendar
  • Streams
  • Liquipedia
  • Features
  • Store
  • EPT
  • TL+
  • StarCraft 2
  • Brood War
  • Smash
  • Heroes
  • Counter-Strike
  • Overwatch
  • Liquibet
  • Fantasy StarCraft
  • TLPD
  • StarCraft 2
  • Brood War
  • Blogs
Forum Sidebar
Events/Features
News
Featured News
WTL 2023 Summer - Week 6 Recap/Week 7 Preview2Team Liquid Map Contest #18: Voting4[Interview] iRk-AgGe7WTL 2023 Summer - Week 5 Recap/Week 6 Preview6Maru wins Code S Season 1, achieves "6SL"49
Community News
ESL Open Week #177: herO, Clem, Astrea win1Matcherino starts SC2 team with Astrea, Future16ESL Open Week #176: Creator, Clem, Solar win7Alpha X disbands15ESL Open Week #175: ByuN, MaxPax, Solar win1
StarCraft 2
General
WTL 2023 Summer - Prediction Game Matcherino starts SC2 team with Astrea, Future ESL Open Week #177: herO, Clem, Astrea win WTL 2023 Summer - Week 6 Recap/Week 7 Preview trigger Talks: SC2 Balance, Basilisk, Serral...
Tourneys
[WTL 2023] Summer - Week 7 Grand Platypus Open (EPT Asia Region) WardiTV TL Map Contest Tournament #10! [WTL 2023] Summer - Week 6 WardiTV 2023 Opens (Monthly)
Strategy
Custom Maps
TLMC#18 Judging Comments and Feedback Thread [M] (2) Magannatha [M] (2) Ultralove [M] (2) Vertigo
External Content
Mutation # 371 Never Say Die Mutation # 370 Astigmatism Mutation # 369 Undermined Mutation # 368 Secret Storm
Brood War
General
Stork's Protoss Quotes Compendium vol. 1 BGH auto balance -> http://bghmmr.com/ Golden Girl Tournament (Off-Line in Peru) Insane Snow PvT (FPVOD) Recent recommended BW games
Tourneys
[Megathread] Daily Proleagues Small VOD Thread 2.0 Artosis vs the World BSL 2v2 ProLeague S2 - Day 4 - Sunday 20:00 CEST
Strategy
[H] Yet even more questions about DT builds Carriers or arbiters Abusive drop locations on Vermeer
Other Games
General Games
Diablo IV FF7 remake for PS4 announced Nintendo Switch Thread Frost Giant announce Stormgate Diablo 4 lvl 100 HC challenge!
Dota 2
Official 'what is Dota anymore' discussion Berlin Major 2023
League of Legends
MSI is happening, the thread TSM pausing esports and CLG Dead Building the Future of Sport at Riot Games
Heroes of the Storm
Heroes International Nations Cup - Berlin 2023
Hearthstone
TL Mafia
TL Endures Mafia TL Endures Voting Thread TL Mafia Plays: Diplomacy TL Mafia Community Thread [410]TL.net/forum/mafia Appeal Disambiguation 1.02
Community
General
NASA and the Private Sector US Politics Mega-thread Russo-Ukrainian War Thread The Games Industry And ATVI Summer Games Done Quick 2023!
Fan Clubs
The Guru Fan Club INnoVation Fan Club
Media & Entertainment
[Manga] One Piece Korean Music Discussion Movie Discussion! Rome (TV Series) [TV] HBO The Last Of Us series
Sports
NBA General Discussion 2022 - 2023 Football Thread TeamLiquid Health and Fitness Initiative For 2023 Formula 1 Discussion McBoner: A hockey love story
World Cup 2022
FIFA World Cup Qatar 2022 Thread
Tech Support
StarCraft 2 Is Crashing on My PC
TL Community
Recent Gifted Posts
Blogs
Atom-Mech (Chapter 4)
Terryberri
Berlin and Balloons!
FuDDx
Unexpected Wholesome SC Mome…
JieXian
Job interview
mantequilla
15 years
Shady Sands
The truth about Final Fan…
jameswatts
TL Currency Converter Mafia…
Minely
Teaching Students StarCr…
Lovethelord
Customize Sidebar...

Website Feedback

Closed Threads



Active: 961 users

1.16.1 repfix (pause/chat)

Forum Index > BW General
Post a Reply
1 2 3 Next All
Python_Max
Profile Joined November 2007
Ukraine51 Posts
Last Edited: 2009-01-27 08:40:07
January 25 2009 16:14 GMT
#1
RepFix is a BWL/ChaosLauncher plugin which fixes StarCraft's (1.16.1) crash when watching a replay with chat text recorded while game was paused.

Download v. 0.0.0.4: http://depositfiles.com/files/wk71bm2ie

The bug itself seems to be very old.
Basically replay action processing looks like:
1) read the actions for next tick and copy actions data to the buffer
2) wait until that tick comes, read actions from the buffer and execute

When game is paused the tick remains unchanged, so every chat message written while game paused has been recorded with that tick when game was paused.
The problem is in that the buffer in which actions are copied for execution is too small. I believe about 12 messages are enough to make it overflow. And when overflow happens the data overrides neighbor memory areas in which are other variables located.The consequences can be very different and depend on amount of messages has been recorded during pause.

What I did is a replacement of static buffer with dynamic one.
1) when copying actions to the buffer:
1.1) when overwrite - allocate new buffer, write data to the new buffer
1.2) when append (multiple actions for a single tick) - append to the previously allocated buffer increasing its size if needed
2) when reading from a static buffer - return a pointer to the dynamic buffer instead of static

Plugin patches StarCraft's code, so use it on your own risk!

I will be very appreciated for any testing/bugreports.
Later I will merge this fix into ICCup Launcher.

EDIT: It has nothing to do with saving a replay, it just fixes a playback
You need this only when watching a replay not playing a game.

Thanks.


PS: I believe the main mistake of BW developers was to count chat text as game action. I would rather record/read it in a different way. But I'm not the one who decide ^^

EDIT: http://www.iccup.com/starcraft/forum/general_forum/starcraft_forum_/50888.html?1232900679

EDIT2: the bug is old, but it was impossible to produce so many actions for a single tick... before RWT was implemented! Because player was unable to make game actions while game paused. Thats why I believe that text messages should not count as game actions.

UPDATE: v. 0.0.0.2 should work online now.
UPDATE: v. 0.0.0.3 fixed action loss in bnet-mode.
UPDATE: v. 0.0.0.4 fixed activation behavior (when replay starts)
fusionsdf
Profile Blog Joined June 2006
Canada15390 Posts
Last Edited: 2009-01-25 16:18:32
January 25 2009 16:17 GMT
#2
foreign community: 26
blizzard devs: 2

----
nice work, thanks :D
SKT_Best: "I actually chose Protoss because it was so hard for me to defeat Protoss as a Terran. When I first started Brood War, my main race was Terran."
GTR
Profile Blog Joined September 2004
50946 Posts
January 25 2009 16:25 GMT
#3
Nice!

Uploaded onto TL webspace because host sites suck!

Here!
CommentatorTwitter: @GTR1H
Stream: http://www.twitch.tv/GTR1H
Racenilatr
Profile Blog Joined August 2008
United States2756 Posts
January 25 2009 16:26 GMT
#4
very awsome. Thanks!

Btw:Mega Upload doesn't suck that badly
Python_Max
Profile Joined November 2007
Ukraine51 Posts
January 25 2009 16:27 GMT
#5
On January 26 2009 01:17 fusionsdf wrote:
foreign community: 26
blizzard devs: 2

Sorry don't get this :D
freelander
Profile Blog Joined December 2004
Hungary4707 Posts
January 25 2009 16:29 GMT
#6
On January 26 2009 01:27 Python_Max wrote:
Show nested quote +
On January 26 2009 01:17 fusionsdf wrote:
foreign community: 26
blizzard devs: 2

Sorry don't get this :D


score
And all is illuminated.
IzzyCraft
Profile Blog Joined June 2007
United States4487 Posts
January 25 2009 16:32 GMT
#7
Is that 26 really meaning something vs the 2 what is the 2 blizzard gets?
I have ass for brains so,
even when I shit I'm droping knowledge.
Cloud
Profile Blog Joined November 2004
Sexico5880 Posts
January 25 2009 16:34 GMT
#8
Like... its a JOKE dude, dont take it so seriously..
BlueLaguna on West, msg for game.
MasterReY
Profile Blog Joined August 2007
Germany2708 Posts
January 25 2009 16:34 GMT
#9
wow great THANKS !
https://www.twitch.tv/MasterReY/ ~ Biggest Reach fan on TL.net (Don't even dare to mention LR now) ~ R.I.P Violet ~ Developer of SCRChart
TL+ Member
MasterOfChaos
Profile Blog Joined April 2007
Germany2896 Posts
January 25 2009 16:37 GMT
#10
nice
Starcraft had(I think it was fixed in 1.15.0) a bug where if the data for a replayframe was >255 bytes the replay got corruped. In that patch they corrected it to start a new replayframe with the same framenumber containing the remaining commands which apparently fixed the problem(PP did it way before blizzard by the way). So I'm surprised that chat cause these problems, while multicommands do not. They generate many commands in one frame and corrupted the replay before the fix.
LiquipediaOne eye to kill. Two eyes to live.
Doso
Profile Joined March 2008
Germany765 Posts
January 25 2009 16:37 GMT
#11
I loaded this into Chaoslauncher.

When I am trying to connect to Battle.net (Europe) with English StarcraftI get an error saying that Starcraft can't verify the application version. A friend of mine has the same problem.
Python_Max
Profile Joined November 2007
Ukraine51 Posts
Last Edited: 2009-01-25 16:43:27
January 25 2009 16:41 GMT
#12
On January 26 2009 01:37 MasterOfChaos wrote:
nice
Starcraft had(I think it was fixed in 1.15.0) a bug where if the data for a replayframe was >255 bytes the replay got corruped. In that patch they corrected it to start a new replayframe with the same framenumber containing the remaining commands which apparently fixed the problem(PP did it way before blizzard by the way). So I'm surprised that chat cause these problems, while multicommands do not. They generate many commands in one frame and corrupted the replay before the fix.

Each message action is 82 bytes long. I think such amount of data (per tick) as 12-15 messages was not reached yet, until RWT xD
Python_Max
Profile Joined November 2007
Ukraine51 Posts
January 25 2009 16:42 GMT
#13
On January 26 2009 01:37 Doso wrote:
I loaded this into Chaoslauncher.

When I am trying to connect to Battle.net (Europe) with English StarcraftI get an error saying that Starcraft can't verify the application version. A friend of mine has the same problem.

OMG, I just patch it when started, but seems I should wait until replay starts then patch...
tec27
Profile Blog Joined June 2004
United States3642 Posts
Last Edited: 2009-01-25 17:10:19
January 25 2009 17:09 GMT
#14
Very nice job, Python But yeah, try to make it wait til a replay is loaded

Offsets I use for that:
006D0F14 - byte, 0 for out of, 1 for in replay
006D11EC - byte, 0 for out of game, 1 for ingame
(You have to use them both, because the replay one will for some reason trigger when you first enter the menu to load a replay (the file selection part). Actually, now that I think about it, using only the first one would probably work fine for this application)
Can you jam with the console cowboys in cyberspace?
imBLIND
Profile Blog Joined December 2006
United States2623 Posts
January 25 2009 18:31 GMT
#15
i don't think you can use this online cause he modded the code of starcraft...
im deaf
MasterOfChaos
Profile Blog Joined April 2007
Germany2896 Posts
January 25 2009 18:36 GMT
#16
no it's just that he patches to early and thus fails the revision check. He just needs to patch only during a replay. But of course anybody without this fix who watches the replay with you will still crash.
LiquipediaOne eye to kill. Two eyes to live.
liger13
Profile Blog Joined February 2008
United States1060 Posts
January 25 2009 18:36 GMT
#17
On January 26 2009 03:31 imBLIND wrote:
i don't think you can use this online cause he modded the code of starcraft...

at least it might speed up Blizz's patch ...
+ Show Spoiler +
might take a month and 1/2 instead of two
I feel like pwning noobs
Python_Max
Profile Joined November 2007
Ukraine51 Posts
January 25 2009 18:53 GMT
#18
UPDATE: v. 0.0.0.2 should work online now.
prOxi.Beater
Profile Joined December 2008
Denmark626 Posts
January 25 2009 19:06 GMT
#19
You can't use this fix online, but it's still nice to have for offline use.
Nobody beats the Beater
Python_Max
Profile Joined November 2007
Ukraine51 Posts
January 25 2009 19:17 GMT
#20
On January 26 2009 04:06 prOxi.Beater wrote:
You can't use this fix online, but it's still nice to have for offline use.

Why?
1 2 3 Next All
Please log in or register to reply.
Live Events Refresh
Next event in 55m
[ Submit Event ]
Live Streams
Refresh
StarCraft 2
Forgg! 80
SpeCial 1
StarCraft: Brood War
Bisu 1296
Larva 990
Snow 342
LaStScan 103
Sexy 41
Barracks 18
Sacsri 14
Hm[arnc] 5
Sacsri 4
Jumperer 2
[ Show more ]
Bale 0
Dota 2
XaKoH 290
NeuroSwarm137
XcaliburYe18
League of Legends
JimRising 744
Other Games
summit1g12481
Stewie2K3218
singsing1623
WinterStarcraft990
HitmanStarcraft2191
ViBE128
Mew2King96
Trikslyr58
febbydoto52
Hui .49
Livibee43
Liquid`Ken17
Organizations
Other Games
gamesdonequick44353
Dota 2
PGL Dota 2 - Main Stream5578
Counter-Strike: Global Offensive
ESL CS:GO1339
Other Games
BasetradeTV271
StarCraft 2
Esl_sc2196
ESL.tv196
StarCraft: Brood War
lovetv 24
StarcraftVOD3
StarCraft 2
Blizzard YouTube
StarCraft: Brood War
BSLTrovo
[ Show 21 non-featured ]
StarCraft 2
• davetesta63
• Maddox 23
• IndyKCrew
• Poblha
• Migwel
• Alpha X_
• aXEnki
• Laughngamez YouTube
• intothetv
• LaughNgamez Trovo
• Gussbus
• Kozan
StarCraft: Brood War
• sscaitournament1
• STPLYoutube
• BSLYoutube
• AfreecaTV YouTube
League of Legends
• Scarra3477
• Ambition2169
• Lourlo1111
• Shiphtur1093
• Stunt540
Upcoming Events
Grand Platypus Open
55m
World Team League
4h 55m
Team Liquid vs Berserker eSports
Onsyde Gaming vs SSLT
PSISTORM Gaming Misc
10h 55m
Matcherino INu Series
21h 55m
Classic vs Astrea
ByuN vs Solar
Sparkling Tuna Cup
1d
World Team League
1d 4h
Starlight Twinkle vs DKZ Gaming
Shopify Rebellion vs PSISTORM Gaming
BeAsT Cup
1d 8h
ESL Open Cup
2 days
ESL Open Cup
2 days
ESL Open Cup
2 days
[ Show More ]
PassionCraft
5 days
Liquipedia Results

Completed

Wisdom Invitational
WardiTV TLMC #10
NC 2023 - EU Quals. - 2nd Stage
CCT Online Finals #1

Ongoing

FS Mania
KCM Ladies Race Survival 2023 Season 2
KCM Race Survival 2023 Season 2
GRS Season 6
Super Anchor Qualifying S1
Platinum StarCraft League S1
CSL 9: 2023 Summer
BSL 2v2 ProLeague #2
TT Offline Party
WTL 2023 Summer
Nexus Never Dies #3
HOTS Unchained
ESL Impact League S3 Finals
IEM Dallas 2023

Upcoming

Copa Latinoamericana Season 2
ESL Winter
2023 GSL S3: Code S
2023 GSL S2: Code S
HSC XXIII
ESL Summer
LTK Thunderball
Nations Cup 2023
ESL Pro League Season 18
IEM Cologne 2023
BLAST Premier Fall Groups
ESL Challenger Katowice 2023
BLAST Premier Spring Final
TLPD

1. ByuN
2. TY
3. Dark
4. Solar
5. Stats
6. Nerchio
7. sOs
8. soO
9. INnoVation
10. Elazer
1. Rain
2. Flash
3. EffOrt
4. Last
5. Bisu
6. Soulkey
7. Mini
8. Sharp
Sidebar Settings...

Advertising | Privacy Policy | Terms Of Use | Contact Us

Original banner artwork: Jim Warren
The contents of this webpage are copyright © 2023 TLnet. All Rights Reserved.