• Log InLog In
  • Register
Liquid`
TeamLiquid Liquipedia LiquidDota LiquidLegends
EST 04:27
CET 10:27
KST 18:27
  • Home
  • Forum
  • Calendar
  • Streams
  • Liquipedia
  • Features
  • Store
  • EPT
  • TL+
  • StarCraft 2
  • Brood War
  • Smash
  • Heroes
  • Counter-Strike
  • Overwatch
  • Liquibet
  • Fantasy StarCraft
  • TLPD
  • StarCraft 2
  • Brood War
  • Blogs
Forum Sidebar
Events/Features
News
Featured News
DH Last Chance: RO16 Group C Preview8[ASTL2] Power Rank22DH Last Chance: RO16 Group B Preview11DH Last Chance: RO16 Group A Preview12TL.net is recruiting SC2 writers26
Community News
DH Last Chance: RO8 Bracket Set24ESL Open #53: Zest doubles, MaNa wins EU12Ryung joins Team GP13Lilbow returns to SC2 joins Archangel Gaming88ESL Open #52: Zoun, HeroMarine, Zest win1
StarCraft 2
General
Lilbow returns to SC2 joins Archangel Gaming StarCraft Mass Recall: SC1 campaigns on SC2 thread 2021 GSL Super Tournament I (Qualifiers) DH Last Chance: RO8 Bracket Set DH Last Chance: RO16 Group C Preview
Tourneys
$9,000 WardiTV 2021 [DH Masters 2020] Last Chance 2021 ITaX Ultimate Battles#2 - Cure vs Patience (BO.11) When is WESG? Alpha X Junior Championships - Global Finals 2020
Strategy
[G] PvZ Cheese: PartinG's "Adios Amigo" Build Select Larvae + Morph unit Rapidfire [D] My Interpretation of Standard TvP kill the carriers as a zerg
Custom Maps
Re-created map Wasteland [Q] BO Practice Custom Map Simple Questions/Answers [A] The Beginning (Populous 3 remake)
External Content
New edition of the Dank Templars SC2 newsletter! Mutation #247 Perfect Storm Welcome to the External Content forum Sponsoring a Bo7 between 2 pros of your choice
Brood War
General
Grant Davies leaves Blizzard FlaSh on: What Exactly is "Talent" in Progaming? [ASTL2] Week 1 Lineups 24/7 Classic Starcraft VoD Stream StarCraft Human 'N' AI League
Tourneys
[CMSLS4] CasterMuse StarLeague S4 [ASTL2] Week 1 Day 1 Coach Pupil League Season 6 (CPL 6) Rogue City Rumble - Open Qualifiers
Strategy
FlaSh's TvP Gas FE into 3 Tank Pressure [subbed] What is this new pvt style with no arbiters? PvP Bonyth style 2 gate 3 zealot 21 gas guide Valkyrie dmg formula?
Other Games
Heroes of the Storm
HotS: WP and Funny Moments [HotS] NA Stands Supreme
General Games
Final Fantasy XIV FF7 remake for PS4 announced Genshin Impact - Coop RPG Path of Exile Cyberpunk 2077
TL Mafia
[M][T] Personality Mafia: Mini Edition TL Mafia Plays: Diplomacy Personality Mini Mafia: Vote Thread TL Mafia Community Thread British Empire Mini Mafia II
Hearthstone
Is Hearthstone Gambling?
LoL General
LoL Tournaments
LoL Strategy
Community
General
US Politics Mega-thread The Chess Thread Coronavirus and You [Space] Space Launch System, SLS Mexico's Drug War
Fan Clubs
The TY Fan Club Stats Fan Club The BoxeR Fan Club
Media & Entertainment
[SCIFI Series] The Expanse [Manga] One Piece Anime Discussion Thread Korean Music Discussion [HBO] 30 Coins
Sports
2020 NFL and College Football Corona Season NBA Season 2019-2020 NHL 19-20: Hop Off my Kakko 2020 - 2021 Football Thread Major League Baseball 2015
Tech Support
Simple Questions Simple Answers PC for Premiere Pro and After Effects Computer Build, Upgrade & Buying Resource Thread
TL Community
The Automated Ban List Recent Gifted Posts Happy Birthday R1CH!
Blogs
The one man Army vs Serral…
EheroSC2
How Do We Improve Su…
waywardstrategy
My iPhone game
GroT
Trekkertent Saor DCF 4-season …
Tak3r
Cheeseadelphia 11 Trav…
TheRealNanMan
BattleReports.com to …
Psyonic_Reaver
Shameless self promotion/opin…
WindOw
Customize Sidebar...

Website Feedback

Closed Threads



Active: 931 users

1.16.1 repfix (pause/chat)

Forum Index > BW General
Post a Reply
1 2 3 Next All
Python_Max
Profile Joined November 2007
Ukraine51 Posts
Last Edited: 2009-01-27 08:40:07
January 25 2009 16:14 GMT
#1
RepFix is a BWL/ChaosLauncher plugin which fixes StarCraft's (1.16.1) crash when watching a replay with chat text recorded while game was paused.

Download v. 0.0.0.4: http://depositfiles.com/files/wk71bm2ie

The bug itself seems to be very old.
Basically replay action processing looks like:
1) read the actions for next tick and copy actions data to the buffer
2) wait until that tick comes, read actions from the buffer and execute

When game is paused the tick remains unchanged, so every chat message written while game paused has been recorded with that tick when game was paused.
The problem is in that the buffer in which actions are copied for execution is too small. I believe about 12 messages are enough to make it overflow. And when overflow happens the data overrides neighbor memory areas in which are other variables located.The consequences can be very different and depend on amount of messages has been recorded during pause.

What I did is a replacement of static buffer with dynamic one.
1) when copying actions to the buffer:
1.1) when overwrite - allocate new buffer, write data to the new buffer
1.2) when append (multiple actions for a single tick) - append to the previously allocated buffer increasing its size if needed
2) when reading from a static buffer - return a pointer to the dynamic buffer instead of static

Plugin patches StarCraft's code, so use it on your own risk!

I will be very appreciated for any testing/bugreports.
Later I will merge this fix into ICCup Launcher.

EDIT: It has nothing to do with saving a replay, it just fixes a playback
You need this only when watching a replay not playing a game.

Thanks.


PS: I believe the main mistake of BW developers was to count chat text as game action. I would rather record/read it in a different way. But I'm not the one who decide ^^

EDIT: http://www.iccup.com/starcraft/forum/general_forum/starcraft_forum_/50888.html?1232900679

EDIT2: the bug is old, but it was impossible to produce so many actions for a single tick... before RWT was implemented! Because player was unable to make game actions while game paused. Thats why I believe that text messages should not count as game actions.

UPDATE: v. 0.0.0.2 should work online now.
UPDATE: v. 0.0.0.3 fixed action loss in bnet-mode.
UPDATE: v. 0.0.0.4 fixed activation behavior (when replay starts)
fusionsdf
Profile Blog Joined June 2006
Canada15384 Posts
Last Edited: 2009-01-25 16:18:32
January 25 2009 16:17 GMT
#2
foreign community: 26
blizzard devs: 2

----
nice work, thanks :D
SKT_Best: "I actually chose Protoss because it was so hard for me to defeat Protoss as a Terran. When I first started Brood War, my main race was Terran."
GTR
Profile Blog Joined September 2004
49072 Posts
January 25 2009 16:25 GMT
#3
Nice!

Uploaded onto TL webspace because host sites suck!

Here!
CommentatorTwitter: @GTR1H
Stream: http://www.twitch.tv/GTR1H
Racenilatr
Profile Blog Joined August 2008
United States2756 Posts
January 25 2009 16:26 GMT
#4
very awsome. Thanks!

Btw:Mega Upload doesn't suck that badly
Python_Max
Profile Joined November 2007
Ukraine51 Posts
January 25 2009 16:27 GMT
#5
On January 26 2009 01:17 fusionsdf wrote:
foreign community: 26
blizzard devs: 2

Sorry don't get this :D
freelander
Profile Blog Joined December 2004
Hungary4089 Posts
January 25 2009 16:29 GMT
#6
On January 26 2009 01:27 Python_Max wrote:
Show nested quote +
On January 26 2009 01:17 fusionsdf wrote:
foreign community: 26
blizzard devs: 2

Sorry don't get this :D


score
And all is illuminated.
IzzyCraft
Profile Blog Joined June 2007
United States4487 Posts
January 25 2009 16:32 GMT
#7
Is that 26 really meaning something vs the 2 what is the 2 blizzard gets?
I have ass for brains so,
even when I shit I'm droping knowledge.
Cloud
Profile Blog Joined November 2004
Sexico5650 Posts
January 25 2009 16:34 GMT
#8
Like... its a JOKE dude, dont take it so seriously..
BlueLaguna on West, msg for game.
MasterReY
Profile Blog Joined August 2007
Germany2698 Posts
January 25 2009 16:34 GMT
#9
wow great THANKS !
https://www.twitch.tv/MasterReY/ ~ Biggest Reach fan on TL.net (Don't even dare to mention LR now) ~ R.I.P Violet ~ Developer of SCRChart
TL+ Member
MasterOfChaos
Profile Blog Joined April 2007
Germany2896 Posts
January 25 2009 16:37 GMT
#10
nice
Starcraft had(I think it was fixed in 1.15.0) a bug where if the data for a replayframe was >255 bytes the replay got corruped. In that patch they corrected it to start a new replayframe with the same framenumber containing the remaining commands which apparently fixed the problem(PP did it way before blizzard by the way). So I'm surprised that chat cause these problems, while multicommands do not. They generate many commands in one frame and corrupted the replay before the fix.
LiquipediaOne eye to kill. Two eyes to live.
Doso
Profile Joined March 2008
Germany747 Posts
January 25 2009 16:37 GMT
#11
I loaded this into Chaoslauncher.

When I am trying to connect to Battle.net (Europe) with English StarcraftI get an error saying that Starcraft can't verify the application version. A friend of mine has the same problem.
Python_Max
Profile Joined November 2007
Ukraine51 Posts
Last Edited: 2009-01-25 16:43:27
January 25 2009 16:41 GMT
#12
On January 26 2009 01:37 MasterOfChaos wrote:
nice
Starcraft had(I think it was fixed in 1.15.0) a bug where if the data for a replayframe was >255 bytes the replay got corruped. In that patch they corrected it to start a new replayframe with the same framenumber containing the remaining commands which apparently fixed the problem(PP did it way before blizzard by the way). So I'm surprised that chat cause these problems, while multicommands do not. They generate many commands in one frame and corrupted the replay before the fix.

Each message action is 82 bytes long. I think such amount of data (per tick) as 12-15 messages was not reached yet, until RWT xD
Python_Max
Profile Joined November 2007
Ukraine51 Posts
January 25 2009 16:42 GMT
#13
On January 26 2009 01:37 Doso wrote:
I loaded this into Chaoslauncher.

When I am trying to connect to Battle.net (Europe) with English StarcraftI get an error saying that Starcraft can't verify the application version. A friend of mine has the same problem.

OMG, I just patch it when started, but seems I should wait until replay starts then patch...
tec27
Profile Blog Joined June 2004
United States3443 Posts
Last Edited: 2009-01-25 17:10:19
January 25 2009 17:09 GMT
#14
Very nice job, Python But yeah, try to make it wait til a replay is loaded

Offsets I use for that:
006D0F14 - byte, 0 for out of, 1 for in replay
006D11EC - byte, 0 for out of game, 1 for ingame
(You have to use them both, because the replay one will for some reason trigger when you first enter the menu to load a replay (the file selection part). Actually, now that I think about it, using only the first one would probably work fine for this application)
Can you jam with the console cowboys in cyberspace?
TL+ Member
imBLIND
Profile Blog Joined December 2006
United States2388 Posts
January 25 2009 18:31 GMT
#15
i don't think you can use this online cause he modded the code of starcraft...
im deaf
MasterOfChaos
Profile Blog Joined April 2007
Germany2896 Posts
January 25 2009 18:36 GMT
#16
no it's just that he patches to early and thus fails the revision check. He just needs to patch only during a replay. But of course anybody without this fix who watches the replay with you will still crash.
LiquipediaOne eye to kill. Two eyes to live.
liger13
Profile Blog Joined February 2008
United States1060 Posts
January 25 2009 18:36 GMT
#17
On January 26 2009 03:31 imBLIND wrote:
i don't think you can use this online cause he modded the code of starcraft...

at least it might speed up Blizz's patch ...
+ Show Spoiler +
might take a month and 1/2 instead of two
I feel like pwning noobs
Python_Max
Profile Joined November 2007
Ukraine51 Posts
January 25 2009 18:53 GMT
#18
UPDATE: v. 0.0.0.2 should work online now.
prOxi.Beater
Profile Joined December 2008
Denmark626 Posts
January 25 2009 19:06 GMT
#19
You can't use this fix online, but it's still nice to have for offline use.
Nobody beats the Beater
Python_Max
Profile Joined November 2007
Ukraine51 Posts
January 25 2009 19:17 GMT
#20
On January 26 2009 04:06 prOxi.Beater wrote:
You can't use this fix online, but it's still nice to have for offline use.

Why?
1 2 3 Next All
Please log in or register to reply.
Live Events Refresh
Next event in 33m
[ Submit Event ]
Live Streams
Refresh
StarCraft 2
PartinGtheBigBoy 881
Livibee 374
Dragon 82
SC2Nice 42
StarCraft: Brood War
Calm 1996
Larva 1284
Stork 609
ToSsGirL 319
Rush 255
Bisu 249
EffOrt 178
Iris 135
BeSt 123
Killer 77
[ Show more ]
Rain 62
Bale 35
yabsab 28
Sharp 14
Soulkey 11
Beast 9
Sexy 7
Counter-Strike: Global Offensive
rGuardiaN1022
Super Smash Bros
Westballz135
Other Games
summit1g37388
m0e_tv2164
WinterStarcraft934
HitmanStarcraft2283
Chillindude201
OGKoka 114
nookyyy 53
AxAlicia11
Organizations
StarCraft 2
ESL.tv2080
Counter-Strike: Global Offensive
ESL CS:GO1465
StarCraft 2
OGamingTV SC2 289
Other Games
BasetradeTV234
StarCraft 2
SC2 Vod Archives107
Blizzard YouTube
[ Show 20 non-featured ]
StarCraft 2
• SC2Artist 13
• ThisGuy707 2
• Genesis Gaming
• LaughNgamez Trovo
• AlphaB_SC2
• Matiz_pl
• Laughngamez YouTube
• IndyKCrew
• Kozan
• intothetv
• aXEnki
• Alpha X_
SC2: Legacy of the Void
• KarlJayG
• PSISTORM Gaming
StarCraft: Brood War
• Surfer4life 66
• SkrOs 45
• ourplay13 19
• sscaitournament5
• AfreecaTV YouTube
Other Games
• TSM TheOddOne640
Upcoming Events
AfreecaTV Starcraft Tea…
33m
Snow vs Bisu
BeSt vs Larva
Shuttle vs Killer
JyJ vs sSak
Action vs Shine
Soulkey vs hero
free vs Mini
Flash vs Light
maraleCup
1h 33m
ITaX Ultimate Battle
1h 33m
Cure vs Patience
ESL Pro Tour
4h 33m
BW Jeez Weekly
8h 3m
Gosudark vs trutaCz
The Pizza Pie
13h 33m
The NA Apprentice
15h 33m
ESL Pro Tour
23h 33m
ESL Pro Tour
1d 7h
ESL Pro Tour
1d 14h
[ Show More ]
AfreecaTV Starcraft Tea…
2 days
Sharp vs ZerO
Soma vs Stork
sOrry vs Rush
EffOrt vs MIsO
Snow vs Soulkey
JyJ vs Flash
BeSt vs Action
Shuttle vs free
OlimoLeague
2 days
OSC
4 days
PSISTORM Gaming Misc
5 days
PSISTORM Gaming Misc
6 days
Cheesadelphia
6 days
The Three-Winged Angel
6 days
Alpha X Junior Champion…
6 days
Liquipedia Results

Completed

2020 KCM Challenge Season 4
OSC Championship Season 8
NGS Storm Division S2 Qual. 2
IEM Global Challenge

Ongoing

Ultimate Battle
Shinhan Tank Proleague S4
BWCL Season 52
ASTL Season 2
BW Jeez weekly GF 2020
KCM Race Survival 2020 Season 4
DH Masters: Last Chance 2021
NGS Storm Division S2 Quals
Community Clash League S1

Upcoming

Rogue City Rumble
IEM Katowice 2021
2021 AfreecaTV GSL Super Tournament 1
Cheeseadelphia Winter
WardiTV 2021
Masters Clash Champ. 2021
MCC 2021 Qualifier 1
MCC 2021 Qualifiers
ESL Pro League Season 13
IEM Katowice 2021
BLAST Premier Spring Groups
DreamHack Open Jan 2021
cs_summit 7
BLAST Premier Global Final
TLPD

1. ByuN
2. TY
3. Dark
4. Solar
5. Stats
6. Nerchio
7. sOs
8. soO
9. INnoVation
10. Elazer
1. Rain
2. Flash
3. EffOrt
4. Last
5. Bisu
6. Soulkey
7. Mini
8. Sharp
Sidebar Settings...

Advertising | Privacy Policy | Terms Of Use | Contact Us

Original banner artwork: Jim Warren
The contents of this webpage are copyright © 2021 TLnet. All Rights Reserved.