A note about immortals: incoming high-damage attacks will be reduced to 10 regardless of armor upgardes, making armor upgrades doubly ineffective against high-damage/low-speed units.
Still vs low-damage attacks (eg: lings, the menace of immortals), the armor upgrade helps immortals a lot. Probably obvious, but wanted to clarify, in case some reader translates the text into "armor upgrades never help immortals", which isn't what was stated of course.
I think immortals are perfect example for when upgrade effectiveness radically depends on the enemy army composition. Vs some units the armor upgrade of immortals is absolutely useless, vs other units it becomes absolutely critical.
That's probably my favorite property of upgrades - how they can turn around all kinds of "hard counters". Wouldn't it be super fun to throw an army of +3 armor immortals right into the claws of an ocean of +0 damage lings, just so they realize that each of their hits causes only 1 damage, and there won't be toss for dinner.
If the percentage of your army's total damage output done by a single unit is less than the percentage damage output a weapon upgrade gives to your whole army
I think you meant "more", instead of "less". Check it out, or I might have gotten it wrong. You use this as premise for armor upgrade, so you want a single unit to be important alive, and you want weapon upgrade to not be important for your army, which is the opposite of what the "if"" clause contains.
To be frank, I don't see how these 2 sides of the inequality are properly comparable; maybe it's better to just say that you want one to be high and the other to be low.