• Log InLog In
  • Register
Liquid`
Team Liquid Liquipedia
EST 00:46
CET 06:46
KST 14:46
  • Home
  • Forum
  • Calendar
  • Streams
  • Liquipedia
  • Features
  • Store
  • EPT
  • TL+
  • StarCraft 2
  • Brood War
  • Smash
  • Heroes
  • Counter-Strike
  • Overwatch
  • Liquibet
  • Fantasy StarCraft
  • TLPD
  • StarCraft 2
  • Brood War
  • Blogs
Forum Sidebar
Events/Features
News
Featured News
ByuL: The Forgotten Master of ZvT28Behind the Blue - Team Liquid History Book19Clem wins HomeStory Cup 289HomeStory Cup 28 - Info & Preview13Rongyi Cup S3 - Preview & Info8
Community News
Weekly Cups (Feb 16-22): MaxPax doubles0Weekly Cups (Feb 9-15): herO doubles up2ACS replaced by "ASL Season Open" - Starts 21/0258LiuLi Cup: 2025 Grand Finals (Feb 10-16)46Weekly Cups (Feb 2-8): Classic, Solar, MaxPax win2
StarCraft 2
General
Terran AddOns placement How do you think the 5.0.15 balance patch (Oct 2025) for StarCraft II has affected the game? Nexon's StarCraft game could be FPS, led by UMS maker ByuL: The Forgotten Master of ZvT Oliveira Would Have Returned If EWC Continued
Tourneys
PIG STY FESTIVAL 7.0! (19 Feb - 1 Mar) Sparkling Tuna Cup - Weekly Open Tournament SEL Doubles (SC Evo Bimonthly) WardiTV Team League Season 10 RSL Season 4 announced for March-April
Strategy
Custom Maps
Publishing has been re-enabled! [Feb 24th 2026] Map Editor closed ?
External Content
The PondCast: SC2 News & Results Mutation # 515 Together Forever Mutation # 514 Ulnar New Year Mutation # 513 Attrition Warfare
Brood War
General
Soma Explains: JD's Unrelenting Aggro vs FlaSh Recent recommended BW games TvZ is the most complete match up BGH Auto Balance -> http://bghmmr.eu/ ACS replaced by "ASL Season Open" - Starts 21/02
Tourneys
BWCL Season 64 Announcement The Casual Games of the Week Thread [Megathread] Daily Proleagues [LIVE] [S:21] ASL Season Open Day 1
Strategy
Soma's 9 hatch build from ASL Game 2 Fighting Spirit mining rates Simple Questions, Simple Answers Zealot bombing is no longer popular?
Other Games
General Games
Online Quake Live Config Editor Tool Battle Aces/David Kim RTS Megathread Diablo 2 thread Nintendo Switch Thread Path of Exile
Dota 2
The Story of Wings Gaming Official 'what is Dota anymore' discussion
League of Legends
Heroes of the Storm
Simple Questions, Simple Answers Heroes of the Storm 2.0
Hearthstone
Deck construction bug Heroes of StarCraft mini-set
TL Mafia
Vanilla Mini Mafia Mafia Game Mode Feedback/Ideas TL Mafia Community Thread
Community
General
US Politics Mega-thread Things Aren’t Peaceful in Palestine UK Politics Mega-thread YouTube Thread Mexico's Drug War
Fan Clubs
The IdrA Fan Club The herO Fan Club!
Media & Entertainment
[Manga] One Piece [Req][Books] Good Fantasy/SciFi books Anime Discussion Thread
Sports
2024 - 2026 Football Thread Formula 1 Discussion TL MMA Pick'em Pool 2013
World Cup 2022
Tech Support
Laptop capable of using Photoshop Lightroom?
TL Community
The Automated Ban List
Blogs
Unintentional protectionism…
Uldridge
ASL S21 English Commentary…
namkraft
Inside the Communication of …
TrAiDoS
Life Update and thoughts.
FuDDx
How do archons sleep?
8882
James Bond movies ranking - pa…
Topin
Customize Sidebar...

Website Feedback

Closed Threads



Active: 2997 users

The Big Programming Thread - Page 947

Forum Index > General Forum
Post a Reply
Prev 1 945 946 947 948 949 1032 Next
Thread Rules
1. This is not a "do my homework for me" thread. If you have specific questions, ask, but don't post an assignment or homework problem and expect an exact solution.
2. No recruiting for your cockamamie projects (you won't replace facebook with 3 dudes you found on the internet and $20)
3. If you can't articulate why a language is bad, don't start slinging shit about it. Just remember that nothing is worse than making CSS IE6 compatible.
4. Use [code] tags to format code blocks.
Acrofales
Profile Joined August 2010
Spain18224 Posts
February 19 2018 21:45 GMT
#18921
A silly SQL issue popped up in the last 15 minutes of work, I didn't solve it and it's driving me nuts thinking about it. Anybody got any ideas?


SELECT ev.id, user.name, floor((timestamp - <starttime>)/10000) as bin, ev.details
FROM Events ev LEFT JOIN Users user ON ev.userId = user.id
WHERE user.id = <userid> AND timestamp > <starttime> AND timestamp < <endtime>

Returns a pretty list of events (for the test user I was checking: 736 in total. Among them, nothing in bin 278.


SELECT user.name, floor((timestamp - <starttime>)/10000) as bin, COUNT(*) as eventsinbin
FROM Events ev LEFT JOIN Users user ON ev.userId = user.id
WHERE user.id = <userid> AND timestamp > <starttime> AND timestamp < <endtime>
GROUP BY bin

Returns a pretty list of bins and counts of events in them. Bin 278 has 43 events in it

WHY?!
WolfintheSheep
Profile Joined June 2011
Canada14127 Posts
Last Edited: 2018-02-19 22:48:36
February 19 2018 22:04 GMT
#18922
Events.id is an identity key or can it be NULL?

Edit: Nevermind, you're not joining on Events.id anyway. Does the second SELECT actually work? user.name isn't in the aggregate.
Average means I'm better than half of you.
Acrofales
Profile Joined August 2010
Spain18224 Posts
February 19 2018 22:46 GMT
#18923
On February 20 2018 07:04 WolfintheSheep wrote:
Events.id is an identity key or can it be NULL?

Primary key for the events table
WolfintheSheep
Profile Joined June 2011
Canada14127 Posts
February 19 2018 22:51 GMT
#18924
On February 20 2018 07:46 Acrofales wrote:
Show nested quote +
On February 20 2018 07:04 WolfintheSheep wrote:
Events.id is an identity key or can it be NULL?

Primary key for the events table

See edit. Wouldn't you get an error back about user.name? Or are you grouping by that as well and just missed it.

Are you still getting back 736 total events with the second query?
Average means I'm better than half of you.
Acrofales
Profile Joined August 2010
Spain18224 Posts
February 19 2018 23:03 GMT
#18925
On February 20 2018 07:51 WolfintheSheep wrote:
Show nested quote +
On February 20 2018 07:46 Acrofales wrote:
On February 20 2018 07:04 WolfintheSheep wrote:
Events.id is an identity key or can it be NULL?

Primary key for the events table

See edit. Wouldn't you get an error back about user.name? Or are you grouping by that as well and just missed it.

Are you still getting back 736 total events with the second query?

Because I select only one user name it works.

I didn't have time to sum the counts before leaving work. It was the first thing I was going to check tomorrow. That, and make sure there isn't something funky with the event ordering by making absolutely sure I'm not messing up, and order the first query by bin.
WolfintheSheep
Profile Joined June 2011
Canada14127 Posts
February 20 2018 01:45 GMT
#18926
On February 20 2018 08:03 Acrofales wrote:
Show nested quote +
On February 20 2018 07:51 WolfintheSheep wrote:
On February 20 2018 07:46 Acrofales wrote:
On February 20 2018 07:04 WolfintheSheep wrote:
Events.id is an identity key or can it be NULL?

Primary key for the events table

See edit. Wouldn't you get an error back about user.name? Or are you grouping by that as well and just missed it.

Are you still getting back 736 total events with the second query?

Because I select only one user name it works.

I didn't have time to sum the counts before leaving work. It was the first thing I was going to check tomorrow. That, and make sure there isn't something funky with the event ordering by making absolutely sure I'm not messing up, and order the first query by bin.

Well, without a set ORDER BY results are sorted by retrieval time, which by data is entirely arbitrary. Definitely don't assume one ID is blank by default return order.
Average means I'm better than half of you.
phar
Profile Joined August 2011
United States1080 Posts
Last Edited: 2018-02-20 02:49:38
February 20 2018 02:39 GMT
#18927
On February 19 2018 19:26 nunez wrote:
Show nested quote +
On February 18 2018 12:48 phar wrote:
On February 15 2018 19:33 nunez wrote:

in terms of feature completeness they are also quite close. since gcc already has concepts it is an easy choice (disregarding context) for me, and probably for any other advanced c++ programmer who uses template meta-programming. i don't know what 'analysis tools' you're talking about, but the *grinds does not work with the AST. maybe syntax and aesthetics? that is not a big concern for me and my regexi. i only have a tiny familiarity in working with the AST's of both, but i don't think i found any of them daunting.

The gcc AST tends to be a less exact representation of the actual source code compared to clang. So if you're e.g. building a tool to refactor all of a given thing, gcc might yield you some missing pieces.

Not a big deal for most use cases.

you are comparing gcc / clang as compiler front-ends in the context of writing a compiler. spinesheath was comparing compilers in the context of using a compiler. the former is not a use-case in a discussion of the latter, it's irrelevant, and so is the level of abstraction in the AST.

in any case: can you give examples of how GCC 'completely fucked with' the AST and caused you pain? what kind of tool did you try to write?
I'm not talking about writing a compiler, I know almost nothing about that area.

My specific case in mind is various types of refactoring on a codebase that is ~O(hundred million) LoC.

It simply is not possible to do in gcc. Gcc's ast is not complete, and it removes references to variables on occasion. For a trivial example, see the (obviously hella biased) clang/llvm page on comparison: https://clang.llvm.org/comparison.html.

See here for some similar discussion:

https://lwn.net/Articles/629316/

Again, not really a concern for most use-cases.
Who after all is today speaking about the destruction of the Armenians?
Acrofales
Profile Joined August 2010
Spain18224 Posts
February 20 2018 11:02 GMT
#18928
On February 20 2018 10:45 WolfintheSheep wrote:
Show nested quote +
On February 20 2018 08:03 Acrofales wrote:
On February 20 2018 07:51 WolfintheSheep wrote:
On February 20 2018 07:46 Acrofales wrote:
On February 20 2018 07:04 WolfintheSheep wrote:
Events.id is an identity key or can it be NULL?

Primary key for the events table

See edit. Wouldn't you get an error back about user.name? Or are you grouping by that as well and just missed it.

Are you still getting back 736 total events with the second query?

Because I select only one user name it works.

I didn't have time to sum the counts before leaving work. It was the first thing I was going to check tomorrow. That, and make sure there isn't something funky with the event ordering by making absolutely sure I'm not messing up, and order the first query by bin.

Well, without a set ORDER BY results are sorted by retrieval time, which by data is entirely arbitrary. Definitely don't assume one ID is blank by default return order.

I knew that, but from what I was looking at in the list they seemed incremental. Turns out they were not, and the events I was looking for were hidden somewhere else. Crisis resolved
WolfintheSheep
Profile Joined June 2011
Canada14127 Posts
February 20 2018 18:24 GMT
#18929
On February 20 2018 20:02 Acrofales wrote:
Show nested quote +
On February 20 2018 10:45 WolfintheSheep wrote:
On February 20 2018 08:03 Acrofales wrote:
On February 20 2018 07:51 WolfintheSheep wrote:
On February 20 2018 07:46 Acrofales wrote:
On February 20 2018 07:04 WolfintheSheep wrote:
Events.id is an identity key or can it be NULL?

Primary key for the events table

See edit. Wouldn't you get an error back about user.name? Or are you grouping by that as well and just missed it.

Are you still getting back 736 total events with the second query?

Because I select only one user name it works.

I didn't have time to sum the counts before leaving work. It was the first thing I was going to check tomorrow. That, and make sure there isn't something funky with the event ordering by making absolutely sure I'm not messing up, and order the first query by bin.

Well, without a set ORDER BY results are sorted by retrieval time, which by data is entirely arbitrary. Definitely don't assume one ID is blank by default return order.

I knew that, but from what I was looking at in the list they seemed incremental. Turns out they were not, and the events I was looking for were hidden somewhere else. Crisis resolved

I've found that half my issues are resolved by assuming I'm a dumbass.
Average means I'm better than half of you.
nunez
Profile Blog Joined February 2011
Norway4003 Posts
February 20 2018 19:16 GMT
#18930
On February 20 2018 11:39 phar wrote:
Show nested quote +
On February 19 2018 19:26 nunez wrote:
On February 18 2018 12:48 phar wrote:
On February 15 2018 19:33 nunez wrote:

in terms of feature completeness they are also quite close. since gcc already has concepts it is an easy choice (disregarding context) for me, and probably for any other advanced c++ programmer who uses template meta-programming. i don't know what 'analysis tools' you're talking about, but the *grinds does not work with the AST. maybe syntax and aesthetics? that is not a big concern for me and my regexi. i only have a tiny familiarity in working with the AST's of both, but i don't think i found any of them daunting.

The gcc AST tends to be a less exact representation of the actual source code compared to clang. So if you're e.g. building a tool to refactor all of a given thing, gcc might yield you some missing pieces.

Not a big deal for most use cases.

you are comparing gcc / clang as compiler front-ends in the context of writing a compiler. spinesheath was comparing compilers in the context of using a compiler. the former is not a use-case in a discussion of the latter, it's irrelevant, and so is the level of abstraction in the AST.

in any case: can you give examples of how GCC 'completely fucked with' the AST and caused you pain? what kind of tool did you try to write?
I'm not talking about writing a compiler, I know almost nothing about that area.

My specific case in mind is various types of refactoring on a codebase that is ~O(hundred million) LoC.

It simply is not possible to do in gcc. Gcc's ast is not complete, and it removes references to variables on occasion. For a trivial example, see the (obviously hella biased) clang/llvm page on comparison: https://clang.llvm.org/comparison.html.

See here for some similar discussion:

https://lwn.net/Articles/629316/

Again, not really a concern for most use-cases.

i referred to your hypothetical code transformation tool as a compiler. did you try to write this tool yourself?
conspired against by a confederacy of dunces.
Deleted User 3420
Profile Blog Joined May 2003
24492 Posts
February 21 2018 07:05 GMT
#18931
Let's say I was doing vectorized operations with large arrays. My output goes into another, bigger array.

Sometimes the output creates a duplicate, but according to some secondary criteria I will only want to save one of each given output - I don't want duplicates. But i have to discern which to keep. It's probable there will be many duplicates for each output.

So which would be more efficient

1) do all vectorized operations, storing all my output in the huge array. Then sort the array, then filter out the bad duplicates.

2.) save all outputs to a map, along with their index in the array, and check every new output against the map. if it's a duplicate, only keep it if it is the one I want, and if so - remove the old one.


If I was using lists I would go with 2.....
Acrofales
Profile Joined August 2010
Spain18224 Posts
February 21 2018 08:45 GMT
#18932
Depends on lots of things, your data, the programming language, the compiler, your hardware, what you do afterwards with your outcomes, etc.

I'd do whatever is easiest. If that runs into tractability problems, then start optimizing.
Neshapotamus
Profile Blog Joined May 2006
United States163 Posts
Last Edited: 2018-02-21 18:00:03
February 21 2018 17:59 GMT
#18933
On February 21 2018 16:05 travis wrote:
Let's say I was doing vectorized operations with large arrays. My output goes into another, bigger array.

Sometimes the output creates a duplicate, but according to some secondary criteria I will only want to save one of each given output - I don't want duplicates. But i have to discern which to keep. It's probable there will be many duplicates for each output.

So which would be more efficient

1) do all vectorized operations, storing all my output in the huge array. Then sort the array, then filter out the bad duplicates.

2.) save all outputs to a map, along with their index in the array, and check every new output against the map. if it's a duplicate, only keep it if it is the one I want, and if so - remove the old one.


If I was using lists I would go with 2.....


The function is called unique. You should have some built-in matrix function that does that.
phar
Profile Joined August 2011
United States1080 Posts
Last Edited: 2018-02-21 22:23:03
February 21 2018 21:59 GMT
#18934
On February 21 2018 04:16 nunez wrote:
Show nested quote +
On February 20 2018 11:39 phar wrote:
On February 19 2018 19:26 nunez wrote:
On February 18 2018 12:48 phar wrote:
On February 15 2018 19:33 nunez wrote:

in terms of feature completeness they are also quite close. since gcc already has concepts it is an easy choice (disregarding context) for me, and probably for any other advanced c++ programmer who uses template meta-programming. i don't know what 'analysis tools' you're talking about, but the *grinds does not work with the AST. maybe syntax and aesthetics? that is not a big concern for me and my regexi. i only have a tiny familiarity in working with the AST's of both, but i don't think i found any of them daunting.

The gcc AST tends to be a less exact representation of the actual source code compared to clang. So if you're e.g. building a tool to refactor all of a given thing, gcc might yield you some missing pieces.

Not a big deal for most use cases.

you are comparing gcc / clang as compiler front-ends in the context of writing a compiler. spinesheath was comparing compilers in the context of using a compiler. the former is not a use-case in a discussion of the latter, it's irrelevant, and so is the level of abstraction in the AST.

in any case: can you give examples of how GCC 'completely fucked with' the AST and caused you pain? what kind of tool did you try to write?
I'm not talking about writing a compiler, I know almost nothing about that area.

My specific case in mind is various types of refactoring on a codebase that is ~O(hundred million) LoC.

It simply is not possible to do in gcc. Gcc's ast is not complete, and it removes references to variables on occasion. For a trivial example, see the (obviously hella biased) clang/llvm page on comparison: https://clang.llvm.org/comparison.html.

See here for some similar discussion:

https://lwn.net/Articles/629316/

Again, not really a concern for most use-cases.

i referred to your hypothetical code transformation tool as a compiler. did you try to write this tool yourself?


Ah gotcha, no it's definitely not a compiler. It relies on AST info extracted from the compiler but can't itself compile code. There's ~dozens of people working on this at my place. Aside from a few of the tools nobody writes them by themselves, it's always a team effort.

I wish I was smart enough to write this by myself lol, maybe I would be able to employ myself ha.

Also it is not a hypothetical tool lol, it works and is in active use. We're still mucking with it always, and will be using it or a similar tool more in the future, but we do use it now too.

It will become a tricky problem if we ever start supporting codebases that explicitly use gcc, icc etc. We'll see what happens then, idk.
Who after all is today speaking about the destruction of the Armenians?
nunez
Profile Blog Joined February 2011
Norway4003 Posts
February 21 2018 23:42 GMT
#18935
our compiler-concepts differ.
conspired against by a confederacy of dunces.
Silvanel
Profile Blog Joined March 2003
Poland4742 Posts
February 22 2018 09:22 GMT
#18936
So i have two parts of my test Application. One written in C# the other (main) in Python. Whats the best way to exchange data between them? I need both parts of app to talk to each other in "close" to real time conditions (the max delay i can allow i think is around 1s).
Pathetic Greta hater.
Acrofales
Profile Joined August 2010
Spain18224 Posts
Last Edited: 2018-02-22 10:33:40
February 22 2018 10:32 GMT
#18937
On February 22 2018 18:22 Silvanel wrote:
So i have two parts of my test Application. One written in C# the other (main) in Python. Whats the best way to exchange data between them? I need both parts of app to talk to each other in "close" to real time conditions (the max delay i can allow i think is around 1s).

The easiest alternative I can think of is to simply open a socket-based connection between the two processes: it's not the fastest form of communication, but 1s is an eternity.
Excludos
Profile Blog Joined April 2010
Norway8233 Posts
February 22 2018 14:04 GMT
#18938
So (I might have mentioned this earlier) our firm doesn't really have any testing policy. Our only testing is done in the form of manually checking that shit works after coding. While this will work to some extent, it's not a super good practice.

So one of my colleagues came up with the idea to run a workshop with everyone to teach people how to set up proper tests and to apply some good practices. The conversation with the boss went as follows:

"No".
"Why not?"
"We don't have time right now".
"When will we have time for this?"
"Well everything is a bit unstable at the moment. If we get everything more stable then we'll have ti-" "DO YOU NOT SEE THE PROBLEM HERE?!"
phar
Profile Joined August 2011
United States1080 Posts
February 22 2018 16:15 GMT
#18939
On February 22 2018 08:42 nunez wrote:
our compiler-concepts differ.

Ok sure, possibly because I know almost nothing about building an actual compiler.
Who after all is today speaking about the destruction of the Armenians?
sabas123
Profile Blog Joined December 2010
Netherlands3122 Posts
February 22 2018 18:55 GMT
#18940
On February 22 2018 23:04 Excludos wrote:
So (I might have mentioned this earlier) our firm doesn't really have any testing policy. Our only testing is done in the form of manually checking that shit works after coding. While this will work to some extent, it's not a super good practice.

So one of my colleagues came up with the idea to run a workshop with everyone to teach people how to set up proper tests and to apply some good practices. The conversation with the boss went as follows:

"No".
"Why not?"
"We don't have time right now".
"When will we have time for this?"
"Well everything is a bit unstable at the moment. If we get everything more stable then we'll have ti-" "DO YOU NOT SEE THE PROBLEM HERE?!"

Aaaahhh, I remember having a similar conversation once. Good times....
The harder it becomes, the more you should focus on the basics.
Prev 1 945 946 947 948 949 1032 Next
Please log in or register to reply.
Live Events Refresh
Next event in 3h 14m
[ Submit Event ]
Live Streams
Refresh
StarCraft 2
WinterStarcraft520
NeuroSwarm 207
Livibee 82
Ketroc 49
StarCraft: Brood War
Sea 13517
GuemChi 3879
PianO 888
Leta 312
NaDa 44
Jaeyun 38
Icarus 10
League of Legends
JimRising 782
Counter-Strike
Stewie2K433
Other Games
summit1g10554
C9.Mang0323
RuFF_SC2150
Mew2King47
Organizations
Other Games
gamesdonequick796
Counter-Strike
PGL147
StarCraft 2
Blizzard YouTube
StarCraft: Brood War
BSLTrovo
sctven
[ Show 16 non-featured ]
StarCraft 2
• davetesta25
• Light_VIP 18
• Mapu2
• AfreecaTV YouTube
• intothetv
• Kozan
• IndyKCrew
• LaughNgamezSOOP
• Migwel
• sooper7s
StarCraft: Brood War
• Azhi_Dahaki11
• BSLYoutube
• STPLYoutube
• ZZZeroYoutube
League of Legends
• Rush1612
• Lourlo1578
Upcoming Events
Replay Cast
3h 14m
Wardi Open
6h 14m
Monday Night Weeklies
11h 14m
Replay Cast
18h 14m
Replay Cast
2 days
Replay Cast
2 days
The PondCast
3 days
KCM Race Survival
3 days
Replay Cast
3 days
Ultimate Battle
4 days
Light vs ZerO
[ Show More ]
Replay Cast
4 days
CranKy Ducklings
5 days
Replay Cast
5 days
Sparkling Tuna Cup
6 days
Replay Cast
6 days
Liquipedia Results

Completed

Acropolis #4 - TS5
PiG Sty Festival 7.0
Underdog Cup #3

Ongoing

KCM Race Survival 2026 Season 1
Jeongseon Sooper Cup
Spring Cup 2026
WardiTV Winter 2026
Nations Cup 2026
ESL Pro League S23 Stage 1&2
PGL Cluj-Napoca 2026
IEM Kraków 2026
BLAST Bounty Winter 2026
BLAST Bounty Winter Qual
eXTREMESLAND 2025

Upcoming

ASL Season 21: Qualifier #1
ASL Season 21: Qualifier #2
ASL Season 21
Acropolis #4 - TS6
Acropolis #4
IPSL Spring 2026
CSLAN 4
HSC XXIX
uThermal 2v2 2026 Main Event
Bellum Gens Elite Stara Zagora 2026
RSL Revival: Season 4
NationLESS Cup
Asian Champions League 2026
IEM Atlanta 2026
PGL Astana 2026
BLAST Rivals Spring 2026
CCT Season 3 Global Finals
FISSURE Playground #3
IEM Rio 2026
PGL Bucharest 2026
Stake Ranked Episode 1
BLAST Open Spring 2026
ESL Pro League S23 Finals
TLPD

1. ByuN
2. TY
3. Dark
4. Solar
5. Stats
6. Nerchio
7. sOs
8. soO
9. INnoVation
10. Elazer
1. Rain
2. Flash
3. EffOrt
4. Last
5. Bisu
6. Soulkey
7. Mini
8. Sharp
Sidebar Settings...

Advertising | Privacy Policy | Terms Of Use | Contact Us

Original banner artwork: Jim Warren
The contents of this webpage are copyright © 2026 TLnet. All Rights Reserved.