• Log InLog In
  • Register
Liquid`
Team Liquid Liquipedia
EDT 08:31
CEST 14:31
KST 21:31
  • Home
  • Forum
  • Calendar
  • Streams
  • Liquipedia
  • Features
  • Store
  • EPT
  • TL+
  • StarCraft 2
  • Brood War
  • Smash
  • Heroes
  • Counter-Strike
  • Overwatch
  • Liquibet
  • Fantasy StarCraft
  • TLPD
  • StarCraft 2
  • Brood War
  • Blogs
Forum Sidebar
Events/Features
News
Featured News
Tournament Spotlight: FEL Cracow 20257Power Rank - Esports World Cup 202577RSL Season 1 - Final Week9[ASL19] Finals Recap: Standing Tall15HomeStory Cup 27 - Info & Preview18
Community News
Google Play ASL (Season 20) Announced24BSL Team Wars - Bonyth, Dewalt, Hawk & Sziky teams10Weekly Cups (July 14-20): Final Check-up0Esports World Cup 2025 - Brackets Revealed19Weekly Cups (July 7-13): Classic continues to roll8
StarCraft 2
General
Power Rank - Esports World Cup 2025 Tournament Spotlight: FEL Cracow 2025 #1: Maru - Greatest Players of All Time I offer completely free coaching services What tournaments are world championships?
Tourneys
FEL Cracov 2025 (July 27) - $10,000 live event Esports World Cup 2025 $25,000 Streamerzone StarCraft Pro Series announced $5,000 WardiTV Summer Championship 2025 WardiTV Mondays
Strategy
How did i lose this ZvP, whats the proper response
Custom Maps
External Content
Mutation #239 Bad Weather Mutation # 483 Kill Bot Wars Mutation # 482 Wheel of Misfortune Mutation # 481 Fear and Lava
Brood War
General
Google Play ASL (Season 20) Announced [Update] ShieldBattery: 2025 Redesign Dewalt's Show Matches in China BGH Auto Balance -> http://bghmmr.eu/ BW General Discussion
Tourneys
[Megathread] Daily Proleagues [BSL20] Non-Korean Championship 4x BSL + 4x China CSL Xiamen International Invitational [CSLPRO] It's CSLAN Season! - Last Chance
Strategy
Simple Questions, Simple Answers [G] Mineral Boosting Does 1 second matter in StarCraft?
Other Games
General Games
Stormgate/Frost Giant Megathread Nintendo Switch Thread Total Annihilation Server - TAForever [MMORPG] Tree of Savior (Successor of Ragnarok) Path of Exile
Dota 2
Official 'what is Dota anymore' discussion
League of Legends
Heroes of the Storm
Simple Questions, Simple Answers Heroes of the Storm 2.0
Hearthstone
Heroes of StarCraft mini-set
TL Mafia
TL Mafia Community Thread Vanilla Mini Mafia
Community
General
US Politics Mega-thread UK Politics Mega-thread Stop Killing Games - European Citizens Initiative Things Aren’t Peaceful in Palestine Russo-Ukrainian War Thread
Fan Clubs
INnoVation Fan Club SKT1 Classic Fan Club!
Media & Entertainment
[\m/] Heavy Metal Thread Anime Discussion Thread Movie Discussion! [Manga] One Piece Korean Music Discussion
Sports
2024 - 2025 Football Thread Formula 1 Discussion TeamLiquid Health and Fitness Initiative For 2023 NBA General Discussion
World Cup 2022
Tech Support
Installation of Windows 10 suck at "just a moment" Computer Build, Upgrade & Buying Resource Thread
TL Community
TeamLiquid Team Shirt On Sale The Automated Ban List
Blogs
Ping To Win? Pings And Their…
TrAiDoS
momentary artworks from des…
tankgirl
from making sc maps to makin…
Husyelt
StarCraft improvement
iopq
Socialism Anyone?
GreenHorizons
Eight Anniversary as a TL…
Mizenhauer
Customize Sidebar...

Website Feedback

Closed Threads



Active: 677 users

c++ help?

Blogs > tossinYoSalad
Post a Reply
1 2 3 Next All
tossinYoSalad
Profile Blog Joined May 2009
United States215 Posts
Last Edited: 2009-10-14 02:15:20
October 14 2009 02:01 GMT
#1
Ok, so this project is due in 2 hours, and I've been working on it all day. It's pretty much done but it's just not working and I just can't stare at it any more. Can someone help?

The project is basically analyzing contiguous spaces in a two-dimensional array (find the blobs). A blob is 2 or more contiguous spaces in the array. I've figured out how to find the blobs using a stack, and I think I implemented it correctly but it's not working for some reason. The code hangs within the while loop so I'm assuming something in there is wrong. here is the code:

http://pastebin.com/d30e116f3

^^pastebin now.

I know its way over commented, I'm a total noob at c++ (mostly code in java,asm, and python) and it got confusing with braces and shit. I also know this could be done way more efficiently but I don't really care at this point, I just need it to work. The following DOES work: importing grid from text file, displaying the grid, and everything else. the above method hangs in the while loop and I can't figure out why. Help PLEASE!

b3h47pte
Profile Blog Joined May 2007
United States1317 Posts
Last Edited: 2009-10-14 02:05:19
October 14 2009 02:05 GMT
#2
Use http://pastebin.com/
it hurts my eyes looking at that...>>
fabiano
Profile Blog Joined August 2009
Brazil4644 Posts
October 14 2009 02:06 GMT
#3
with no identation its impossible to read anything
"When the geyser died, a probe came out" - SirJolt
tossinYoSalad
Profile Blog Joined May 2009
United States215 Posts
October 14 2009 02:06 GMT
#4
http://pastebin.com/m588911d8

sorry, wish tl had code tags lol.
Eti307
Profile Blog Joined March 2004
Canada3442 Posts
October 14 2009 02:08 GMT
#5
Wow that's way to messy, sorry I'm not touching that
was the //startif //endif comments really necessary? lol

Where exactly does it hang? use the debugger, might give you a clue
tossinYoSalad
Profile Blog Joined May 2009
United States215 Posts
October 14 2009 02:12 GMT
#6
On October 14 2009 11:08 Eti307 wrote:
Wow that's way to messy, sorry I'm not touching that
was the //startif //endif comments really necessary? lol

Where exactly does it hang? use the debugger, might give you a clue


the startif endif i put it so i could check and see if i was missing a bracket when i was fixing syntax errors. i can clean it real fast.
yenta
Profile Blog Joined April 2006
Poland1142 Posts
October 14 2009 02:12 GMT
#7
What are the INPUTs and OUTPUTs of this function supposed to be?
Trutacz Practice Discord - https://discord.gg/PWF7Pv
Eti307
Profile Blog Joined March 2004
Canada3442 Posts
October 14 2009 02:16 GMT
#8
On October 14 2009 11:12 tossinYoSalad wrote:
Show nested quote +
On October 14 2009 11:08 Eti307 wrote:
Wow that's way to messy, sorry I'm not touching that
was the //startif //endif comments really necessary? lol

Where exactly does it hang? use the debugger, might give you a clue


the startif endif i put it so i could check and see if i was missing a bracket when i was fixing syntax errors. i can clean it real fast.


instead of doing that just type in both brackets each and everytime you are using something with brackets. Prevents those type of errors
tossinYoSalad
Profile Blog Joined May 2009
United States215 Posts
Last Edited: 2009-10-14 02:21:40
October 14 2009 02:16 GMT
#9
On October 14 2009 11:12 yenta wrote:
What are the INPUTs and OUTPUTs of this function supposed to be?


all it does is count the number of blobs and keep track of the recursion depth. numBlobs is incremented immediately after the while loop and recDepth is incremented at the end of the function.

there is no input it acts on a grid held in the class (just a two-dim array of ints) its called gridCopy. theGrid is the same thing only its an arr of chars (this teacher is psycho, i had to do it this way)
i know its a horrible implementation believe me.
tossinYoSalad
Profile Blog Joined May 2009
United States215 Posts
October 14 2009 02:17 GMT
#10
On October 14 2009 11:16 Eti307 wrote:
Show nested quote +
On October 14 2009 11:12 tossinYoSalad wrote:
On October 14 2009 11:08 Eti307 wrote:
Wow that's way to messy, sorry I'm not touching that
was the //startif //endif comments really necessary? lol

Where exactly does it hang? use the debugger, might give you a clue


the startif endif i put it so i could check and see if i was missing a bracket when i was fixing syntax errors. i can clean it real fast.


instead of doing that just type in both brackets each and everytime you are using something with brackets. Prevents those type of errors


ya i do, i also needed to put a a few lines in specific places at the end and there were 5 braces in a row at the end lol.
yenta
Profile Blog Joined April 2006
Poland1142 Posts
October 14 2009 02:29 GMT
#11
On October 14 2009 11:16 tossinYoSalad wrote:
Show nested quote +
On October 14 2009 11:12 yenta wrote:
What are the INPUTs and OUTPUTs of this function supposed to be?


all it does is count the number of blobs and keep track of the recursion depth. numBlobs is incremented immediately after the while loop and recDepth is incremented at the end of the function.

i know its a horrible implementation believe me.


Rewrite it like this:

RECURSIVE CALLER
Initialize count
Initialize array of array with flags (w/e you want)
FOR( 0...x )
FOR( 0..y )
if point @ x,y is unchecked & x.y is a space, call recursive worker
//FOR
//FOR
return w/e

RECURSIVE WORKER ( root, current_x, current_y, pointer to 2D array, ref to count )
base case:
return if out of bounds
return if space you're looking has been marked 'looked at'
recursive case:
count adj spaces by calling self with: ( x-1,y ), ( x+1, y), (x, y+1), (x, y-1) + diagonals if they count.
if adj spaces > 0 & root == true, increment counter //endif
mark current space as read
END
Trutacz Practice Discord - https://discord.gg/PWF7Pv
tossinYoSalad
Profile Blog Joined May 2009
United States215 Posts
October 14 2009 02:34 GMT
#12
On October 14 2009 11:29 yenta wrote:
Show nested quote +
On October 14 2009 11:16 tossinYoSalad wrote:
On October 14 2009 11:12 yenta wrote:
What are the INPUTs and OUTPUTs of this function supposed to be?


all it does is count the number of blobs and keep track of the recursion depth. numBlobs is incremented immediately after the while loop and recDepth is incremented at the end of the function.

i know its a horrible implementation believe me.


Rewrite it like this:

RECURSIVE CALLER
Initialize count
Initialize array of array with flags (w/e you want)
FOR( 0...x )
FOR( 0..y )
if point @ x,y is unchecked & x.y is a space, call recursive worker
//FOR
//FOR
return w/e

RECURSIVE WORKER ( root, current_x, current_y, pointer to 2D array, ref to count )
base case:
return if out of bounds
return if space you're looking has been marked 'looked at'
recursive case:
count adj spaces by calling self with: ( x-1,y ), ( x+1, y), (x, y+1), (x, y-1) + diagonals if they count.
if adj spaces > 0 & root == true, increment counter //endif
mark current space as read
END


thanks alot, what do you mean by root though? and because the 2d array is a class var i dont need to pass it though do i?
Slithe
Profile Blog Joined February 2007
United States985 Posts
Last Edited: 2009-10-14 02:39:04
October 14 2009 02:38 GMT
#13
I only very briefly skimmed it so I may be way off, but it looks like your bounds checking is wrong?

Your Code:
if (rowPtr-1 > 0)
if(rowPtr+1 < theGrid.getRows())

I'm assuming you're trying to make sure that 0 <= rowPtr < theGrid.getRows(). If that's the case, then shouldn't it be:

if (rowPtr+1 > 0)
if(rowPtr < theGrid.getRows())
tossinYoSalad
Profile Blog Joined May 2009
United States215 Posts
Last Edited: 2009-10-14 02:50:38
October 14 2009 02:42 GMT
#14
On October 14 2009 11:38 Slithe wrote:
I only very briefly skimmed it so I may be way off, but it looks like your bounds checking is wrong?

Your Code:
if (rowPtr-1 > 0)
if(rowPtr+1 < theGrid.getRows())

I'm assuming you're trying to make sure that 0 <= rowPtr < theGrid.getRows(). If that's the case, then shouldn't it be:

if (rowPtr+1 > 0)
if(rowPtr < theGrid.getRows())


uhh you were sorta right, but you DID point out an error it needs to be if(rowPtr-1 >= 0) otherwise itll never enter those code segments on the leftmost or rightmost bounds.

but yes it needs to be within the bounds of [0,theGrid.getRows()], but because it can only exceed the left bound on a -1, and it can only exceed the right bound on a +1 i ommited those calls.

fixed it to that and still didnt work. I think its a stack error in the original code, but now im rewriting with yenta's suggestion, only thing i dont get is how to actually count the blobs using that method, i can get it to pass over all the blocks, but no way to tell when the end of a blob has been reached.
FaCE_1
Profile Blog Joined December 2006
Canada6172 Posts
October 14 2009 03:02 GMT
#15
due in 2 hours.. if it was due in 2 days, i could help
n_n
tossinYoSalad
Profile Blog Joined May 2009
United States215 Posts
October 14 2009 03:09 GMT
#16
http://pastebin.com/d3e835a75

its been updated. its almost done, can anyone help finish it?
AeTheReal
Profile Joined June 2009
United States108 Posts
October 14 2009 03:22 GMT
#17
Well, that's a major change from when I started looking at it...

As far as I can tell, the previous version of the code did not work because you never modified the value of a cell when you added it to the stack in the while loop. And since you keep on adding more items to the stack which each added more since nothing was being ruled out on subsequent loops, the while loop never ends. Also, you are probably supposed to check your bounds to be "var >= 0" instead of "var > 0" unless you don't need to check the 0 index for some reason.

In your new code your upper bound should be comparing ">=" theGrid.getRows() instead. Same for the .getCols() one.

else if(gridCopy[curr_x][curr_y] == 0){return;}

Use double equal signs for comparisons. Common mistake.

gridCopy[curr_x][curr_y] = 0;

That should go before you make the recursive calls or you'll get the same error.


Hope this helps.
SonuvBob
Profile Blog Joined October 2006
Aiur21549 Posts
Last Edited: 2009-10-14 03:43:16
October 14 2009 03:29 GMT
#18
No idea what this thing is supposed to do, but your counter doesn't increment.

edit: oh, didn't read the whole OP I guess
Administrator
AeTheReal
Profile Joined June 2009
United States108 Posts
October 14 2009 03:33 GMT
#19
I'm pretty sure that's supposed to count the number of blobs. Unfortunately, the code doesn't ever determine whether each location is part of a blob or not.
yenta
Profile Blog Joined April 2006
Poland1142 Posts
October 14 2009 03:35 GMT
#20
On October 14 2009 11:34 tossinYoSalad wrote:
Show nested quote +
On October 14 2009 11:29 yenta wrote:
On October 14 2009 11:16 tossinYoSalad wrote:
On October 14 2009 11:12 yenta wrote:
What are the INPUTs and OUTPUTs of this function supposed to be?


all it does is count the number of blobs and keep track of the recursion depth. numBlobs is incremented immediately after the while loop and recDepth is incremented at the end of the function.

i know its a horrible implementation believe me.


Rewrite it like this:

RECURSIVE CALLER
Initialize count
Initialize array of array with flags (w/e you want)
FOR( 0...x )
FOR( 0..y )
if point @ x,y is unchecked & x.y is a space, call recursive worker
//FOR
//FOR
return w/e

RECURSIVE WORKER ( root, current_x, current_y, pointer to 2D array, ref to count )
base case:
return if out of bounds
return if space you're looking has been marked 'looked at'
recursive case:
count adj spaces by calling self with: ( x-1,y ), ( x+1, y), (x, y+1), (x, y-1) + diagonals if they count.
if adj spaces > 0 & root == true, increment counter //endif
mark current space as read
END


thanks alot, what do you mean by root though? and because the 2d array is a class var i dont need to pass it though do i?

look at this:
http://pastebin.com/m7c4ab47d
Trutacz Practice Discord - https://discord.gg/PWF7Pv
1 2 3 Next All
Please log in or register to reply.
Live Events Refresh
FEL
09:00
Cracow 2025
Clem vs Krystianer
uThermal vs SKillousLIVE!
Reynor vs MaNa
Lambo vs Gerald
RotterdaM1478
ComeBackTV 1459
IndyStarCraft 512
CranKy Ducklings188
WardiTV167
Rex111
3DClanTV 111
LiquipediaDiscussion
[ Submit Event ]
Live Streams
Refresh
StarCraft 2
RotterdaM 1478
IndyStarCraft 512
Rex 111
BRAT_OK 54
ProTech53
MindelVK 27
StarCraft: Brood War
Britney 45808
Horang2 8300
Hyuk 5706
EffOrt 1059
Hyun 987
Barracks 959
Soma 713
Mini 706
Rush 670
BeSt 669
[ Show more ]
Soulkey 645
Larva 630
firebathero 445
Stork 382
Last 265
Dewaltoss 85
ZerO 79
Sharp 60
Free 59
sorry 44
Sea.KH 36
Movie 34
sSak 30
Shinee 29
sas.Sziky 27
Noble 26
soO 24
zelot 16
Icarus 14
yabsab 14
ajuk12(nOOB) 12
Sacsri 11
Terrorterran 1
Dota 2
qojqva2193
XcaliburYe615
Counter-Strike
sgares300
oskar73
Heroes of the Storm
Khaldor275
Other Games
B2W.Neo1678
Beastyqt942
Hui .233
DeMusliM208
Fuzer 120
QueenE43
ZerO(Twitch)15
Organizations
StarCraft 2
Blizzard YouTube
StarCraft: Brood War
BSLTrovo
sctven
[ Show 16 non-featured ]
StarCraft 2
• Berry_CruncH349
• tFFMrPink 11
• intothetv
• LaughNgamezSOOP
• AfreecaTV YouTube
• sooper7s
• Migwel
• Kozan
• IndyKCrew
StarCraft: Brood War
• STPLYoutube
• ZZZeroYoutube
• BSLYoutube
Dota 2
• C_a_k_e 3740
• WagamamaTV885
League of Legends
• Nemesis2159
• Jankos1246
Upcoming Events
BSL20 Non-Korean Champi…
1h 29m
BSL20 Non-Korean Champi…
5h 29m
Bonyth vs Zhanhun
Dewalt vs Mihu
Hawk vs Sziky
Sziky vs QiaoGege
Mihu vs Hawk
Zhanhun vs Dewalt
Fengzi vs Bonyth
Sparkling Tuna Cup
1d 21h
WardiTV European League
2 days
Online Event
2 days
uThermal 2v2 Circuit
3 days
The PondCast
3 days
Replay Cast
4 days
Korean StarCraft League
5 days
CranKy Ducklings
5 days
[ Show More ]
Sparkling Tuna Cup
6 days
Liquipedia Results

Completed

CSLPRO Last Chance 2025
Esports World Cup 2025
Murky Cup #2

Ongoing

Copa Latinoamericana 4
Jiahua Invitational
BSL 20 Non-Korean Championship
BSL 20 Team Wars
FEL Cracov 2025
CC Div. A S7
Underdog Cup #2
IEM Cologne 2025
FISSURE Playground #1
BLAST.tv Austin Major 2025
ESL Impact League Season 7
IEM Dallas 2025
PGL Astana 2025
Asian Champions League '25

Upcoming

ASL Season 20: Qualifier #1
ASL Season 20: Qualifier #2
ASL Season 20
CSLPRO Chat StarLAN 3
BSL Season 21
RSL Revival: Season 2
Maestros of the Game
SEL Season 2 Championship
WardiTV Summer 2025
uThermal 2v2 Main Event
HCC Europe
ESL Pro League S22
StarSeries Fall 2025
FISSURE Playground #2
BLAST Open Fall 2025
BLAST Open Fall Qual
Esports World Cup 2025
BLAST Bounty Fall 2025
BLAST Bounty Fall Qual
TLPD

1. ByuN
2. TY
3. Dark
4. Solar
5. Stats
6. Nerchio
7. sOs
8. soO
9. INnoVation
10. Elazer
1. Rain
2. Flash
3. EffOrt
4. Last
5. Bisu
6. Soulkey
7. Mini
8. Sharp
Sidebar Settings...

Advertising | Privacy Policy | Terms Of Use | Contact Us

Original banner artwork: Jim Warren
The contents of this webpage are copyright © 2025 TLnet. All Rights Reserved.