| Blogs > tossinYoSalad |
|
prOxi.swAMi
Australia3091 Posts
A tip for writing procedurally complex code like that is to employ comment-first coding which allows you to understand exactly what it is you need to do before you even write it. This code was obviously written "as you went along". Start fresh, write a bunch of pseudocode in comments, then all you should have to do is fill in the logic under the comments. | ||
|
tossinYoSalad
United States215 Posts
On October 14 2009 12:48 prOxi.swAMi wrote: Wow, that's messy :S needs mass refactoring. A tip for writing procedurally complex code like that is to employ comment-first coding which allows you to understand exactly what it is you need to do before you even write it. This code was obviously written "as you went along". Start fresh, write a bunch of pseudocode in comments, then all you should have to do is fill in the logic under the comments. uhh were you looking at the most recent version? cuz its very simple now lol. and.. this is due in 10 mins so i dont really have time to do it. its logically correct, ive had 4 people look at it and agree, but for some reason its endlessly looping between 4 method calls and.. well idk. ill just submit it as is and hope for the best. oddly enough correctness is NOT a huge part of our project grades. thanks for help everyone, especially yenta. | ||
|
SonuvBob
Aiur21552 Posts
On October 14 2009 12:53 tossinYoSalad wrote: oddly enough correctness is NOT a huge part of our project grades. Yeah, I'd take clean code that doesn't quite work over that mess you started with any day. Adding anything to that would be a nightmare, but fixing the newer version should be easy. | ||
|
tossinYoSalad
United States215 Posts
On October 14 2009 12:56 SonuvBob wrote: Did you move gridCopy[curr_x][curr_y] = 0; to before the recursive calls? yes i did  edit: haha well thats what i get when i wait till last day to do programming assignments. this is like the 10th class ive taken involving programming and this is the only assignment ive EVER had problems with. | ||
|
yenta
Poland1143 Posts
quoting myself incase you missed the solution i posted :p | ||
|
tossinYoSalad
United States215 Posts
On October 14 2009 13:00 yenta wrote: quoting myself incase you missed the solution i posted :p holy shit i didnt see that before lol. thanks man but its too late now. you can see my final solution at http://pastebin.com/d3918f10e. i modified your solution slightly to simply have every call of processWork mark off an entire blob and then every iteration of the loop in processGrid increment the number of blobs. | ||
|
ph33r
Canada58 Posts
you have an assignment instead of condition | ||
|
tossinYoSalad
United States215 Posts
![[image loading]](http://i80.photobucket.com/albums/j175/darkness5723/proj2working.png) hey if anyone is curious.. i fixed it, 10 minutes after project was due. sonovbob found the broken code like 10 posts back i just missed it lol. it was the comparison == , and i was using =. fucking stupid c++ compiler should catch that lol. anyway... thats what it does. | ||
|
AeTheReal
United States108 Posts
On October 14 2009 13:14 tossinYoSalad wrote: sonovbob found the broken code like 10 posts back i just missed it lol. ... did he now? | ||
|
Slithe
United States985 Posts
| ||
|
imDerek
United States1944 Posts
| ||
|
GogoKodo
Canada1785 Posts
On October 14 2009 13:14 tossinYoSalad wrote: hey if anyone is curious.. i fixed it, 10 minutes after project was due. sonovbob found the broken code like 10 posts back i just missed it lol. it was the comparison == , and i was using =. fucking stupid c++ compiler should catch that lol. anyway... thats what it does. It's not a compile error so it shouldn't catch that. Doing assignment within a conditional is a pretty normal thing to do. If you want some help from the compiler I believe there are certain warning flags you can set that will give a warning if you do not parenthesize the assignment within the conditional. if( something = newSomething) ... Could be set up to give you a compiler warning which would then go away if it was changed to if( (something = newSomething) ) ... Can't remember the exact flag you need but I'm sure you can google it easily enough. | ||
|
tossinYoSalad
United States215 Posts
yes.. yes.. he did. as to the assignment within a conditional, yeah i know its a legal operation i was just mad that i didnt catch it lol. I normally don't mess that up so I don't think to check it. also, when would you need to do an assignment within a conditional? i cant really find a use for that.. | ||
|
SonuvBob
Aiur21552 Posts
I must've used my admin powers to post it as someone else. | ||
|
EtherealDeath
United States8366 Posts
On October 14 2009 13:14 tossinYoSalad wrote: hey if anyone is curious.. i fixed it, 10 minutes after project was due. sonovbob found the broken code like 10 posts back i just missed it lol. it was the comparison == , and i was using =. fucking stupid c++ compiler should catch that lol. anyway... thats what it does. Recursion depth 534 o.O Didn't read the code, though that seems like a lot of recursion. Prolly would've done it by recursively calling hasBlobProperty() and having the outer layer go through every array position that hasn't already been marked as having a part of a blob there, and the second layer would keep track of the # of blobs. But apparently your method works so it's all good =) | ||
|
Amnesia
United States3818 Posts
Is C++ hard to learn? | ||
|
EtherealDeath
United States8366 Posts
EDIT: Although, if I recall correctly C# can execute up to 40 times slower than C++, and the JVM means Java is slower as well (but you would learn the details yourself in a Java course). Of course, efficiency usually won't matter too much... though I think most games are not made with Java/C# (WoW for instance is written in C++), but you would use a lot of C# and Java in other programming jobs. | ||
|
GogoKodo
Canada1785 Posts
On October 14 2009 15:31 tossinYoSalad wrote: yes.. yes.. he did. as to the assignment within a conditional, yeah i know its a legal operation i was just mad that i didnt catch it lol. I normally don't mess that up so I don't think to check it. also, when would you need to do an assignment within a conditional? i cant really find a use for that.. I don't think it's ever a necessity (could be wrong), it's just a nice convenience for a lot of things. | ||
|
Disregard
China10252 Posts
| ||
|
Slithe
United States985 Posts
Regarding the assignment inside a conditional, here's random example code where it might be used: char[] str = "Hello TeamLiquid!" char c; for (int i = 0; (c=str[i]) != 0; i++) { printf("Letter: %c", c); } From a stylistic point of view, I don't think it's usually a particularly good idea, but it would be inconsistent to treat the assignment differently just because it was placed inside a conditional statement. | ||
| ||
StarCraft 2 StarCraft: Brood War Dota 2 Counter-Strike Other Games |
|
Big Brain Bouts
Rex vs INexorable
GgMaChine vs HeRoMaRinE
Reynor vs herO
Online Event
AI Arena Tournament
BSL: Ladder Tournament
Sparkling Tuna Cup
Patches Events
BSL Open Qualifier
BSL Open Qualifier
OSC
WardiTV Weekly
[ Show More ] |
|
|
EPT
