Not sure how this works with replacements but we have two (if you've already worked this out with oneg, disregard)

raynpelikoneet is in for VA

and

Bill Murray is in for beneather

Xatalos

Finland9675 Posts

August 21 2015 07:25 GMT

#162

It's supposed to be handled like this: you go to the "main menu" (Go Back), then delete the whole game and create it again with the new players.

Xatalos

Finland9675 Posts

August 21 2015 07:26 GMT

#163

New players = other current alive players + replacement players - replaced players

If someone dies, then you can simply remove that player in the game view.

Onegu

United States9699 Posts

August 21 2015 07:47 GMT

#164

On August 21 2015 13:40 rsoultin wrote:
Not sure how this works with replacements but we have two (if you've already worked this out with oneg, disregard)

raynpelikoneet is in for VA

and

Bill Murray is in for beneather

How cute you think onegu actually does host work. That is why he has you.

Xatalos

Finland9675 Posts

August 21 2015 09:56 GMT

#165

:D:D

rsoultin

Netherlands15308 Posts

August 21 2015 13:18 GMT

#166

@.@ it would be more funny if it wasn't true lol ;o;

Keirathi

United States4679 Posts

August 21 2015 15:14 GMT

#167

Since you already have a way to remove a player from an ongoing game, why not also add a way to add a player to currently running game!? Then you can handle replacements without all the deleting-the-game stuff.

Maybe it's not as simple as I make it sound, though

Xatalos

Finland9675 Posts

August 21 2015 20:43 GMT

#168

I guess that could be done as well......

Keirathi

United States4679 Posts

August 22 2015 00:14 GMT

#169

Hmm, Xata, do you have any ideas why I'm getting a compiler error when I try to run the app locally (or even push to heroku)?

When I run "lein ring server" it starts loading all of the dependencies, then it gets tot he part about compiling the clojure stuff, and it fails at either /src/mafia-votecount/models.clj or /src/lobos/config.clj with a NullPointerException.

Edit: Here's the pastebin of the error message if it makes any sense to you

http://pastebin.com/raw.php?i=K3bgQssq

Edit2: Oh, I think I just needed to change the db-uri subname in the files. But now I'm running into another problem.

(def db
(let [db-uri (java.net.URI. (System/getenv "DATABASE_URL"))]
(->> (string/split (.getUserInfo db-uri) #":")
(#(identity {:db (last (string/split (System/getenv "DATABASE_URL") #"\/"))
:classname "org.postgresql.Driver"
:subprotocol "postgresql"
:user (% 0)
:password (% 1)
:subname "//ec2-54-197-253-142.compute-1.amazonaws.com:5432/dfnp55jvc64kc4"})))))

I changed the subname to use my heroku link, but now I get "org.postgresql.util.PSQLException: FATAL: password authentication failed for user"

This is a bit frustrating since I have it set up like yours. I must just be missing something, since I have it set up like yours and the "DATABASE_URL" is listed in my config variables from the app page in the heroku dashboard. :\

Nevermind all of this, I'm an idiot. I changed the subname locally but forgot to commit the changes before I tried to push.

Herp derp.

Xatalos

Finland9675 Posts

August 22 2015 11:53 GMT

#170

Ah yeah.. Sorry, the text in the README is outdated. It's set to use a Heroku DB now, not a local H2 database anymore.

You got it working now by creating your own Heroku DB though?

Keirathi

United States4679 Posts

August 22 2015 16:38 GMT

#171

no, I never could get it to work right and I eventually just gave up.

The problem I was having when I gave up was that I couldn't figure out how to run the migrations script to create the db tables/etc, so my app was just crashing as soon as I tried to load it every time

Xatalos

Finland9675 Posts

August 22 2015 18:54 GMT

#172

Hmm... I'm not actually sure either since my friend created the tables.

I'll get back to you later.

Xatalos

Finland9675 Posts

August 22 2015 19:22 GMT

#173

I didn't notice any bug so I just tried to re-enter the game and now it correctly shows "Day 2 Votecount". Maybe someone re-entered the game with an incorrect host name or something? Not really sure anymore since I forgot to check that possibility.

Xatalos

Finland9675 Posts

August 24 2015 21:12 GMT

#174

Okay, Keirathi... Sorry for the delay, but after trying out various options, I think the best (or at least the easiest) solution is just to follow these steps to test stuff locally:

1) Install leiningen ("brew install leiningen" for OS X and something similar for Linux, I'd assume... not sure about Windows)

2) Clone the Git repository (git clone https://github.com/Xatalos/mafia-votecount - or whatever the address of your forked repository is in case you intended to make a pull request from a fork)

3) Now copy that folder and rename the new folder as something like mafia-votecount-local. Once that's done, go to the new folder and replace these files with the following contents:

project.clj: http://pastebin.com/A7sSdFMe

src/lobos/config.clj: http://pastebin.com/k9YdKbEm

src/mafia_votecount/models.clj: http://pastebin.com/zScESAt1

4) Now you're using a completely functional, empty, local H2 database (all data is stored on your own computer). Just type "lein ring server" and you're ready to go for testing any changes locally (no need for Heroku or anything).

Keirathi

United States4679 Posts

August 24 2015 21:29 GMT

#175

Sweet, got it running. Thanks!

I'll play around with it and see what I can come up with :D

Xatalos

Finland9675 Posts

August 25 2015 10:16 GMT

#176

Okay

Assuming you've made a fork, you can then just copy your changes to the actual forked folder and make a pull request. If there's something you noticed to fix/add, I mean.

Right now there are a couple of issues remaining that could be nice to fix at some point (if you wanted ideas haha):

1) Ordering for the votecount targets (by the amount of voters they have)
2) Get night start games working (currently you can work around the issue by simply not making a correctly formatted N0 post, but naturally it would be nicer if everything worked automatically)
3) Some sort of authentication system (perhaps just requiring some single password for editing the database?)
4) A button for adding new players to a game or something like that

Xatalos

Finland9675 Posts

August 25 2015 10:38 GMT

#177

Oh, and about the migrations script... If you want to try running your own Heroku app, then I think it went something like just running the "(migrations)" command once you've loaded the functions in migrations.clj. That should create the tables...