• Log InLog In
• Register

Mafia Votecount Tool - Page 11

Post a Reply Prev 1 9 10 11 12 13 Next All

Xatalos Finland9675 Posts August 25 2015 20:23 GMT #201 I ended up just manually picking the relevant changes and pushing them myself. Sorry about that, but please make it easier to accept the pull request in the future :D

Keirathi United States4679 Posts August 25 2015 20:27 GMT #202 I don't know that there's anything I can do to make it easier, lol. You're pretty much always going to have to do some manual merging to get around the database stuff unless I can get the heroku version working on my end. I think a lot of it is that you are using Mac? Linux? And the line ending are saved differently. That's why i lot of those blank lines were highlighted, etc, i think. Maybe I can fix that? Not sure.

Xatalos Finland9675 Posts August 25 2015 20:37 GMT #203 I guess you could create a separate mafia-votecount-local folder or something, test your stuff there and then copy-paste the relevant changes to the "real" folder? That's what I basically ended up doing anyway

Xatalos Finland9675 Posts August 25 2015 20:40 GMT #204 In any case, all the relevant changes were nice. Be sure to pull these changes before continuing btw

Xatalos Finland9675 Posts August 25 2015 20:41 GMT #205 Wait... one of my commits after the first one broke it...

Keirathi United States4679 Posts August 25 2015 20:47 GMT #206 :\

Xatalos Finland9675 Posts August 25 2015 20:55 GMT #207 Now its seems to work again. Good job Nice addition to get the delete etc. buttons working properly.

Xatalos Finland9675 Posts August 25 2015 20:57 GMT #208 And yeah, remember to pull hahaha

Xatalos Finland9675 Posts August 25 2015 21:01 GMT #209 Or you can basically just copy that single styling change to your local test folder if you want.

Xatalos Finland9675 Posts August 27 2015 12:13 GMT #210 Merged... Nice work. I tried to do that same sorting thing at some point earlier but moved onto other things when I ran into some problems with it. Looks like it's functional now.

Keirathi United States4679 Posts August 27 2015 16:43 GMT #211 It's not perfect. It doesn't solve the situation that sometimes happens in plurality where the day ends and 2 people have the same number of votes. In that case, the host will still have to manually figure out who is lynched. But it's better than having to sort it all manually!

Xatalos Finland9675 Posts August 27 2015 18:26 GMT #212 That's true.

Xatalos Finland9675 Posts August 27 2015 18:31 GMT #213 Actually it's possible to solve that situation as well... Something like this? Check if the second target in the sorted targets list has the same amount of votes as the first. If yes, then go through the votes for that day and see which of the targets has the later last vote. If that target is first in the target list, then switch places of the first and second targets. That might work out well enough?

Xatalos Finland9675 Posts August 27 2015 18:32 GMT #214 Although that wouldn't work if there were more than two with the same amount of votes... Would have to go through every target in the sorted targets list I guess until the voters length wasn't equal to that of the first target?

Keirathi United States4679 Posts August 27 2015 19:04 GMT #215 Still doesn't work. Imagine this situation: Player A gets a 5th vote at 5:00. Then a 6th vote at 6:30. Player B gets a 5th vote at 6:00. Then the person who voted for Player A at 5:00 unvotes. Now Player A and Player B are tied at 5 votes, Player A should be lynched because they reached 5 votes first, but Player A's last vote is technically after Player B's. I've tried thinking through it, but I can't really think of any easy, logical way to solve the problem.

Xatalos Finland9675 Posts August 27 2015 19:29 GMT #216 Are you sure it works that way? I guess.. Hm.

Keirathi United States4679 Posts August 27 2015 20:56 GMT #217 Yea, I'm pretty sure. So thinking about it more, I think the way to go about it would be to find the number of votes that players are tied at, then loop through all the votes to findt he last time that they were ever under that number of votes, and compare those times between players to determine the order. For instance, if Player A and Player B were tied at 3 votes, then you do a scan of all votes where A was the target. T: vote A (1:00) - 1 U: vote A (2:00) - 2 V: vote A (3:00) - 3 U: Unvote A (4:00) - 2 W: vote A (5:00) - 3 X: vote A (6:00) - 4 V: unvote A (7:00); - 3 Y: vote A (8:00) - 4 Z: vote A (9:00) - 5 Z: unvote A (10:00) - 4 Y: unvote A (11:00) - 3 Now lets say we're doing a vote count now. We see that A never dropped below 3 votes since 5:00 Compare that time with the same analysis of Player B, and sort them based on whoever was first. Since (I think?) the votes are ordered in the database by when they appear, you don't really need time, just the index of the vote and compare them. It's not going to be simple, but I think it can be done?

Xatalos Finland9675 Posts August 27 2015 21:17 GMT #218 Yeah there's no time for the votes, but they're put into the database in the same order they're scanned so basically you get the vote order by just going through them (or comparing the vote id). Here's an example of how the database looks like: id | game | day | index | voter | target ------+------------------------------------------+-----+-------+----------------+----------------- 2500 | 492852-the-new-personality-voting-thread | 1 | 3 | ritoky | fidei86 2501 | 492852-the-new-personality-voting-thread | 1 | 4 | geript | ritoky 2502 | 492852-the-new-personality-voting-thread | 1 | 5 | Fecalfeast | damdred 2503 | 492852-the-new-personality-voting-thread | 1 | 6 | Damdred | fecalfeast 2504 | 492852-the-new-personality-voting-thread | 1 | 7 | Fecalfeast | 2505 | 492852-the-new-personality-voting-thread | 1 | 7 | Fecalfeast | judgejudy 2506 | 492852-the-new-personality-voting-thread | 1 | 8 | Fecalfeast | 2507 | 492852-the-new-personality-voting-thread | 1 | 8 | Fecalfeast | damdred 2508 | 492852-the-new-personality-voting-thread | 1 | 9 | Chezinu | ritoky 2509 | 492852-the-new-personality-voting-thread | 1 | 10 | Chezinu

Xatalos Finland9675 Posts August 27 2015 21:19 GMT #219 By the way, if the target is empty, it just means it's an unvote.

Xatalos Finland9675 Posts August 27 2015 21:21 GMT #220 The "id" is what truly separates the votes from each other (and they're in the order of being given), while the "index" means the index of the post where the vote was given.

Prev 1 9 10 11 12 13 Next All

Please log in or register to reply.