I'm pretty sure wLauncher just reads the InstallPath from the registry which is located here: HKEY_CURRENT_USER\Software\Blizzard Entertainment\Starcraft
For your exe file above, edit it so that it looks for the iccup.ini file in the same directory rather than the registry. Also, any reason why 2 dialog boxes appear?

quirinus

Croatia2489 Posts

April 06 2013 04:27 GMT

#22

2 dialog boxes? Which ones? What do they say?

It looks in the registry (first 32 bit, then 64 bit) for the folder where the iCCup Launcher is installed (the Launcher uninstall reg key has the path).

If it finds it in registry, it just assumes the ini file is in that folder, and checks if it's really present.
If it's there, it proceeds to read the MainExe under the BW section, and adds ddemulate.
If it doesn't find the ini file in that location, i opens up an "open file" dialog so you can select it.
If it doesn't find it in the registry, it opens up an "open file" dialog so you can select it.

In both cases if you don't select the file, or it's not named right, it gives an error and shuts down.
It also gives an error if it can't read the section/key and then shuts down as well.

Edit: LOL how didn't I think of that, yea the wLauncher probably searches the registry every time it starts. Lame. It's going to be harder to fix it like that.

xboi209

United States1173 Posts

April 06 2013 05:27 GMT

#23

It's the one that asks you if you want to run it or not, before admin privs. are requested.

quirinus

Croatia2489 Posts

April 06 2013 17:03 GMT

#24

One asks if you want to run it in admin mode, and the other asks for permission to edit the ini file. It's normal for unlisted programs I think. Say "Yes" to both.

xboi209

United States1173 Posts

April 06 2013 18:12 GMT

#25

I meant that I see 2 of these before admin privileges are requested:
[image loading]

EDIT: Figured it out, if you right click and run as admin, only one of those boxes appear but if you just plainly run it, 2 will appear.
And still, could you just edit it so that it only looks in the current directory and silently run

quirinus

Croatia2489 Posts

April 06 2013 21:29 GMT

#26

Of course, the first line in the code makes it ask for admin privileges. Most of AutoIt scripts get blocked by Windows without that. You also need admin privileges to edit stuff in the program files, haven't really tried running without it, but I think it wouldn't work. If you removed it, I think windows would still make one additional dialog box, depending on your security/privacy/trust settings.

Why would I make it run only in the current directory? The point of the script is that the script finds the ini file automatically, so people don't need to look for it themselves. If it can't find the ini file it simply asks for you to select it.

Why would you make it run silently if it's a stand-alone patch? Usually when you run a patch you want to know the result. I'm not sure what you mean with silent. For me silent is that it doesn't produce any programmed message boxes (results/errors). Windows message boxes are another thing, I don't include them in the silent description.

Here's the version you asked for, though:
exe file
script file

It doesn't ask for any admin rights, and edits only the ini file in the folder it's in.

Code:
+ Show Spoiler [silent mode, only in folder] +

;Made by Quirinus from [url=http://www.teamliquid.net]www.teamliquid.net[/url]
;http://www.teamliquid.net/forum/viewmessage.php?topic_id=406058
;6th April 2013.
;This script adds "ddemulate" to the StarCraft path that iCCup Launcher uses to start StarCraft.
;This fixes dissapearing rank icons on iCCup for most users. Some users report increased loading time for StarCraft.

;has to be in the folder where iccup.ini is (iccup launcher folder)
$ini_path = @WorkingDir & "\iccup.ini"

If (FileExists($ini_path) == 1) Then
   $bw_section = "StarCraft: Brood War"
   $bw_key = "MainExe"
   $bw_path_value = IniRead($ini_path, $bw_section, $bw_key, "Not_Found")
   If ($bw_path_value == "Not_Found") Then
	  Exit
   EndIf

   ;===== Applies the patch if it's not there already =====
   If (StringInStr($bw_path_value, '"ddemulate"') == 0) Then
	  $bw_path_value = $bw_path_value & ' "ddemulate"'
	  IniWrite($ini_path, $bw_section, $bw_key, $bw_path_value)
   EndIf
EndIf
Exit

JohnBall

Brazil1272 Posts

April 06 2013 22:35 GMT

#27

Hey, I was skeptical at first but I'm posting here to confirm that this fix indeed works. Thanks a lot OP.

xboi209

United States1173 Posts

April 06 2013 23:03 GMT

#28

I don't mind having it ask for admin privileges but 2 security warning dialogs are annoying. I'm going to pack this with a batch file that I'm making for iCCup. It'll include a bunch of fixes for Starcraft and it's going to be uploaded on iCCup's website

quirinus

Croatia2489 Posts

April 07 2013 01:41 GMT

#29

On April 07 2013 08:03 xboi209 wrote:
I don't mind having it ask for admin privileges but 2 security warning dialogs are annoying. I'm going to pack this with a batch file that I'm making for iCCup. It'll include a bunch of fixes for Starcraft and it's going to be uploaded on iCCup's website

Ah awesome, that explains it then.

xboi209

United States1173 Posts

April 07 2013 01:44 GMT

#30

I do need help with my batch file though, there's 2 problems with it:
1) My registry is being overwritten even though there's a check to see if the key exists or not
2) The code checks for the value of the key and if the value is incorrect, it checks another value, the value is always considered correct however

+ Show Spoiler +

:na
reg query "%regpath%" /v "%regvalue%">nul || echo Game Data Port does not exist, setting Game Data Port to 6112 & REG ADD "HKCU\Software\Battle.net\Configuration" /v "Game Data Port" /t "REG_DWORD" /d "6112" /f>Nul & goto 6112

:6112
reg query "%regpath%" /v "%regvalue%" | find /i "17e0">nul
if errorlevel 0 (
Start UPNPConsole.exe add "6112" "UDP" "6112" "True" "StarCraft"
echo Opened port 6112 via UPNP
netsh advfirewall firewall add rule name="Starcraft 6112" dir=in action=allow protocol=UDP localport=6112>nul
echo Created firewall rule for port 6112
set 6112=6112
goto starcraftx1
) else (
goto 6113
)

I'd highly appreciate it if you can help me out on this one

quirinus

Croatia2489 Posts

April 07 2013 02:47 GMT

#31

There's also Battle.net\Configuration in the 64 bit part of the reg, dunno if it's important or not.

No idea on the batch file (as I said, I don't know batch very well :<), I'll try to take a deeper look into it later. The first line under :na seems to be broken in two though.

xboi209

United States1173 Posts

April 07 2013 03:06 GMT

#32

Fixed the post, wasn't broken in my batch file.

EDIT:
I fixed my first problem, guess I needed to look at that a bit more but here is the correct code
+ Show Spoiler +

:na
reg query "%regpath%" /v "%regvalue%"2>nul
if errorlevel 1 (
echo Game Data Port does not exist, setting Game Data Port to 6112
REG ADD "HKCU\Software\Battle.net\Configuration" /v "Game Data Port" /t "REG_DWORD" /d "6112">nul
goto 6112
) else (
goto 6112
)

EDIT2: fixed the second problem :D

quirinus

Croatia2489 Posts

April 07 2013 19:09 GMT

#33

On April 07 2013 12:06 xboi209 wrote:
Fixed the post, wasn't broken in my batch file.

EDIT:
I fixed my first problem, guess I needed to look at that a bit more but here is the correct code
+ Show Spoiler +

EDIT2: fixed the second problem :D

Awesome! :D

Are you sure it's just enough to change it there and nowhere else?

dM-White

Chile341 Posts

April 07 2013 19:26 GMT

#34

awesome! worked!! thanks dude!
can you do the same for Wlauncher and fix fish server icons t.t ???

regards

quirinus

Croatia2489 Posts

April 07 2013 19:41 GMT

#35

On April 08 2013 04:26 dM-White wrote:
awesome! worked!! thanks dude!
can you do the same for Wlauncher and fix fish server icons t.t ???

regards

Yea, I was trying, but wLauncher is more fucked up, so it's harder with my limited knowledge. I'm still pondering on a solution...

Maybe xboi has an idea.

xboi209

United States1173 Posts

April 07 2013 20:43 GMT

#36

If wLauncher was translated into English then I would at least take a quick look.

Rekzr

Australia92 Posts

May 28 2013 20:08 GMT

#37

How did you guys go with doing the same for fish, I have just spent the entire night trying to fix this one. cant see the rank numbers displaying, I cant find anyway to ddemulate sc in wlauncher.

quirinus

Croatia2489 Posts

May 28 2013 20:19 GMT

#38

On May 29 2013 05:08 Rekzr wrote:
How did you guys go with doing the same for fish, I have just spent the entire night trying to fix this one. cant see the rank numbers displaying, I cant find anyway to ddemulate sc in wlauncher.

We didn't. :<
wlauncher is gay like that