• Log InLog In
  • Register
Liquid`
Team Liquid Liquipedia
EST 13:31
CET 19:31
KST 03:31
  • Home
  • Forum
  • Calendar
  • Streams
  • Liquipedia
  • Features
  • Store
  • EPT
  • TL+
  • StarCraft 2
  • Brood War
  • Smash
  • Heroes
  • Counter-Strike
  • Overwatch
  • Liquibet
  • Fantasy StarCraft
  • TLPD
  • StarCraft 2
  • Brood War
  • Blogs
Forum Sidebar
Events/Features
News
Featured News
Team Liquid Map Contest #2312[ASL22] Finals Preview: Sweet Victory!12[ASL22] Ro4 Preview: Mirror Mirror6[ASL22] Ro8 Preview: Within Reach5[ASL22] Ro8 Preview: In A Tizzy11
Community News
Weekly Cups (Nov 9-15): Clem and herO take over6Dark completes military service, returns to SC217[BSL23] RO16 Group Stage20Weekly Cups (Nov 2-8): herO back on top?2Weekly Cups (Oct 26 - Nov 1): MaxPax, herO, Solar win0
StarCraft 2
General
Weekly Cups (Nov 9-15): Clem and herO take over SC4ALL: II Indiegogo Campaign Announcement No more SC2 streamers on team liquid? Team Liquid Map Contest #23 StarCraft open world shooter announced at BlizzCon
Tourneys
RSL goes to London! 2026 Offline Finals Nov 21-22 soO & FanTaSy return! SC2 Kevin Scrim 4v4 (Nov 16) Sparkling Tuna Cup - Weekly Open Tournament Sea Duckling Open (Global, Bronze-Diamond) Dark returns! GSL CK #7 4v4 Team Battle (Nov 19)
Strategy
[H] ZvP Mid-Late Game: Stalkers Collossi HT
Custom Maps
[G] How to playtest arcade maps Starcraft 2 Advance [D] the control group Simple Questions/Answers
External Content
The PondCast: SC2 News & Results Mutation # 552 Secret Storm Mutation # 551 Robotic Revival Mutation # 550 Graveyard Shift
Brood War
General
List of top players active on ShieldBattery SC4ALL: II Indiegogo Campaign Announcement XUN appreciation thread BW General Discussion Potentially helpful Shield Battery feedback.
Tourneys
$3,000 Sijosae Tier 2,3,4 Cup (Nov 23-24 2026) [BSL23] Ro16 Group B - Saturday 21:00 CET 2v2v2v2 Tournament Stage 2: Players KCM Race Survival 2026 Season 4
Strategy
Pluto's TvP 5Marine 2Medic Push Simple Questions, Simple Answers Infested Terran strategies in 2026 Nuke strategy worked in K-League 2026-11-09
Other Games
General Games
Nintendo Switch Thread The PlayStation 5 Stormgate/Frost Giant Megathread Warcraft III: The Frozen Throne Free Space RTS Game, optimised f. Phone/Tablet etc
Dota 2
League of Legends
[TL LoL EUW IHs] Teemo shall perish
Heroes of the Storm
Heroes of the Storm 2.0
Hearthstone
Deck construction bug
TL Mafia
TL Mafia Community Thread
Community
General
The Games Industry And ATVI US Politics Mega-thread Russo-Ukrainian War Thread Things Aren’t Peaceful in Palestine Trading/Investing Thread
Fan Clubs
Fan Club Resource Thread Reynor Fan Club The Flash Fan Club
Media & Entertainment
Movie Discussion! Anime Discussion Thread [Manga] One Piece
Sports
Football (Soccer) Thread TeamLiquid Health and Fitness Initiative For 2023
World Cup 2022
Tech Support
Computer Build, Upgrade & Buying Resource Thread
TL Community
The Automated Ban List Recent Gifted Posts
Blogs
The time I organised my…
AssyrianKing
Why I built Repalyzer (1.1.…
BlueStar
Innovate or Game Over?
TrAiDoS
ShieldBattery on Mac
Kraekkling
Can Bots Beat Pros?? Starcr…
namkraft
James Bond movies ranking - pa…
Topin
StarCraft improvement
iopq
Socialism Anyone?
GreenHorizons
Customize Sidebar...

Website Feedback

Closed Threads



Active: 13024 users

My colleagues just reminded me why i quit - Page 2

Blogs > Deleted User 101379
Post a Reply
Prev 1 2 3 Next All
Integra
Profile Blog Joined January 2008
Sweden5626 Posts
September 10 2012 22:27 GMT
#21
On September 11 2012 07:21 Geiko wrote:
Show nested quote +
On September 11 2012 07:15 Integra wrote:
On September 11 2012 07:10 Geiko wrote:
On September 10 2012 19:01 Morfildur wrote:

Now i ordered the two guys responsible to fix that ASAP. They started with changing the code to:

if (MOBILE_TEMPLATE == 'true')
{
...
}


I wanted to punch them sooooo hard.
Luckily i'm out of here at the end of the month...


So, not being a programmer myself, why doesn't their solution work ?

The problem is that they are using string operators when they should be using boolean. It clearly demonstrates that they have no fucking idea of what they are doing.

EDIT; let me clarify.

When you want to actually want to type something, like some sort of output to the user for example you would use a string, like this:

$string =' hello this is a message to the user';
echo $string;

However in this case they are simply to evaluate what path to take in a condition:

IF ($condition==true) {

}

In this case using a string makes no sense and a boolean should be used instead.



Ok that's what I thought too.

But after making the mistake to use strings instead of booleans, isn't it faster to fix the bug like they did, rather than change the type of the variable and risk having bugs every other place where the variable was used ?

No, not if they used proper OOP encapsulation... which probably is sketchy.... you could do refactoring that comes with any professional editor so it should not be a problem. Also the benefit from keeping the bad code is only short term, the long term effect is that it will cost more time.

There is also a programmers standpoint on this. The code becomes "dumb" and you won't be able to read anything from it. Every time someone uses a string it's understood that its suppose to be used in some sort of output, thus you can predict what the code does, it becomes more easy to read and navigate in it. Once you start mixing it up you don't know wtf people are intending with the codes anymore. it becomes impossible to actually understand it. Never mind even trying to debug or add more code to it later... Further Strings takes more memory and process power to process compared to booleans.
"Dark Pleasure" | | I survived the Locust war of May 3, 2014
Loser777
Profile Blog Joined January 2008
1931 Posts
September 10 2012 23:12 GMT
#22
I don't think you could get through the first class of any programming major at any school like that... Given that most schools teach the boolean type before strings and that one often needs to use some sort of string library before that kind of code will even compile.

I'm just going to turn a blind eye and pretend that those kinds of coders only exist in web design for now.


6581
tofucake
Profile Blog Joined October 2009
Hyrule19274 Posts
September 10 2012 23:58 GMT
#23
lol

it's PHP

a variable is any type

you can do
$foo = true;
$foo = 12.381;
$foo = "bar";
$foo = 4;
$foo = array()

and get no errors...not even any warnings
Liquipediaasante sana squash banana
dartoo
Profile Joined May 2010
India2889 Posts
September 11 2012 00:26 GMT
#24
lol.I've certainly seen stuff like that at my job too. and my first reaction was...oh these guys must be entry level programmers/just getting off the block, and often when you correct them..in a maybe slightly harsh tone they really start to lose their stuff .
Release
Profile Blog Joined October 2010
United States4397 Posts
September 11 2012 02:45 GMT
#25
LOLOLOLOL

I'm in my first month of Comp Sci at school and i understand this...
☺
The_LiNk
Profile Blog Joined July 2010
Canada863 Posts
September 11 2012 05:20 GMT
#26
I've been learning PHP over the course of the month and it's entertaining to be able to read the codes and shake my head to this. I can't imagine making such...mistakes.
Deleted User 61629
Profile Blog Joined March 2010
1664 Posts
September 11 2012 05:29 GMT
#27
--- Nuked ---
Deleted User 101379
Profile Blog Joined August 2010
4849 Posts
September 11 2012 08:45 GMT
#28
On September 11 2012 07:10 Geiko wrote:
Show nested quote +
On September 10 2012 19:01 Morfildur wrote:

Now i ordered the two guys responsible to fix that ASAP. They started with changing the code to:

if (MOBILE_TEMPLATE == 'true')
{
...
}


I wanted to punch them sooooo hard.
Luckily i'm out of here at the end of the month...


So, not being a programmer myself, why doesn't their solution work ?


Their solution works but next time another programmer works with that and gets told "that constant is always either true or false" he writes "if (MOBILE_TEMPLATE == true)" and wonders why it doesn't work the way he thinks it would.

Yes, changing true to "true" fixes this bug initially but by not fixing the original problem you invite a huge mess of possible future bugs that are hard to trace. Suddenly you never know if anything is true or "true" and the whole code becomes a mess where every time you add or change a line of code you have to triple-check to make sure it actually works.
Talin
Profile Blog Joined September 2010
Montenegro10532 Posts
September 11 2012 12:10 GMT
#29
At first I was thinking like "well this happens all the time due to carelessness, it's just funny that they couldn't find it", but then I read the last part and the "solution" and it did make me chuckle.
cascades
Profile Blog Joined October 2009
Singapore6122 Posts
Last Edited: 2012-09-11 14:33:22
September 11 2012 14:33 GMT
#30
Is entertaining want more. Will give cookie and stars.
HS: cascades#1595 || LoL: stoppin
BrTarolg
Profile Blog Joined June 2009
United Kingdom3579 Posts
September 11 2012 15:20 GMT
#31
I have never even studied programming beyond being forced to write stupid bits of excel VBA and making othello and java

And i can still understand this lol

Though i made some waaay more horrible mistakes when i first wrote othello hahahaha

But its mainly because nobody taught me anything so i didn't know where to even start, to get a working piece of logic together was already a miracle for me
teamamerica
Profile Blog Joined July 2010
United States958 Posts
September 11 2012 18:03 GMT
#32
PHP lol. There used to be a bug in their md5 digest function where when you passed a string and a salt, it just returned the salt.
RIP GOMTV. RIP PROLEAGUE.
13k
Profile Joined November 2009
Brazil16 Posts
Last Edited: 2012-09-11 19:18:51
September 11 2012 19:05 GMT
#33
Coming from the Ruby community and seeing many noobs adopting Rails (kinda) successfully, I'd mostly advocate towards using easy to use frameworks that are opinionated enough to force people to not make certain mistakes (avoids mistakes by doing things right instead of letting inexperienced programmers do it).

Such platforms that presents concepts like DRY, convention over configuration and MVC to the newcomer, in a easy way, are doing a great job educating while being useful. Even following tutorials that do not explain shit about what's going on already does good by practicing those concepts blindly.

Another point is to use languages/frameworks that does most things for the user. Less code from inexperienced people equals less bugs.

For PHP frameworks, anything between CakePHP, CodeIgniter and Symphony are good choices (refer to http://www.phpframeworks.com and http://en.wikipedia.org/wiki/Comparison_of_web_application_frameworks for more tho)

Edit: All that said, I understand that the majority of times you don't have the choice to either adopt or not certain technologies (boss won't let, project already started, etc). But you can always try to make it happen next time (and there's always a next time).
Dream is destiny
Deleted User 101379
Profile Blog Joined August 2010
4849 Posts
September 11 2012 19:22 GMT
#34
On September 12 2012 04:05 13k wrote:
Coming from the Ruby community and seeing many noobs adopting Rails (kinda) successfully, I'd mostly advocate towards using easy to use frameworks that are opinionated enough to force people to not make certain mistakes (avoids mistakes by doing things right instead of letting inexperienced programmers do it).

Such platforms that presents concepts like DRY, convention over configuration and MVC to the newcomer, in a easy way, are doing a great job educating while being useful. Even following tutorials that do not explain shit about what's going on already does good by practicing those concepts blindly.

Another point is to use languages/frameworks that does most things for the user. Less code from inexperienced people equals less bugs.

For PHP frameworks, anything between CakePHP, CodeIgniter and Symphony are good choices (refer to http://www.phpframeworks.com and http://en.wikipedia.org/wiki/Comparison_of_web_application_frameworks for more tho)


Well, 6 month ago there were talks about our company using a framework for future projects.
Sadly, the head of the department doesn't trust frameworks "because they might have bugs that could be used by hackers" so we still haven't adapted any.

No, i'm not kidding.
PassiveAce
Profile Blog Joined February 2011
United States18076 Posts
September 11 2012 20:25 GMT
#35
You should write a letter about everything you think about the place and the people and tape it to your boss' door when you leave.
Call me Marge Simpson cuz I love you homie
13k
Profile Joined November 2009
Brazil16 Posts
Last Edited: 2012-09-12 10:39:46
September 12 2012 10:32 GMT
#36
On September 12 2012 04:22 Morfildur wrote:

Well, 6 month ago there were talks about our company using a framework for future projects.
Sadly, the head of the department doesn't trust frameworks "because they might have bugs that could be used by hackers" so we still haven't adapted any.

No, i'm not kidding.


oh man... that's so sad in so many levels. employing cheap developers that don't understand boolean logic or operator precedence, for example, is so, so much more dangerous... it's also costs so much more, given that you'll inevitably end up in the dreaded 20% feature / 80% bugfix cycle...

it would make sense if they are talking about paying thousands for licenses, but there are so many professional quality open source / free frameworks out there.

it really surprises me tho, that companies still don't use everything they can to ship as fast and as cheaply as possible... I sometimes thought companies were certainly profiting from open source frameworks and still not "paying back" anything in the form of contribution or sponsoring, etc... I guess I was wrong
Dream is destiny
zatic
Profile Blog Joined September 2007
Zurich15366 Posts
September 12 2012 13:15 GMT
#37
Frameworks are not the solution to shitty programmers though. The same guys will also implement the framework - and do just as much wrong as if they would code stuff themselves.

In the end, you just need able programmers, whether you code from scratch or implement based on a framework.
ModeratorI know Teamliquid is known as a massive building
obesechicken13
Profile Blog Joined July 2008
United States10467 Posts
September 12 2012 15:30 GMT
#38
On September 12 2012 19:32 13k wrote:
Show nested quote +
On September 12 2012 04:22 Morfildur wrote:

Well, 6 month ago there were talks about our company using a framework for future projects.
Sadly, the head of the department doesn't trust frameworks "because they might have bugs that could be used by hackers" so we still haven't adapted any.

No, i'm not kidding.


oh man... that's so sad in so many levels. employing cheap developers that don't understand boolean logic or operator precedence, for example, is so, so much more dangerous... it's also costs so much more, given that you'll inevitably end up in the dreaded 20% feature / 80% bugfix cycle...

it would make sense if they are talking about paying thousands for licenses, but there are so many professional quality open source / free frameworks out there.

it really surprises me tho, that companies still don't use everything they can to ship as fast and as cheaply as possible... I sometimes thought companies were certainly profiting from open source frameworks and still not "paying back" anything in the form of contribution or sponsoring, etc... I guess I was wrong

Can you type out that last paragraph again? I don't understand what you said.
I think in our modern age technology has evolved to become more addictive. The things that don't give us pleasure aren't used as much. Work was never meant to be fun, but doing it makes us happier in the long run.
Deleted User 61629
Profile Blog Joined March 2010
1664 Posts
September 12 2012 15:55 GMT
#39
--- Nuked ---
obesechicken13
Profile Blog Joined July 2008
United States10467 Posts
Last Edited: 2012-09-12 19:45:43
September 12 2012 19:42 GMT
#40
On September 13 2012 00:55 Inori wrote:
Show nested quote +
On September 12 2012 22:15 zatic wrote:
Frameworks are not the solution to shitty programmers though. The same guys will also implement the framework - and do just as much wrong as if they would code stuff themselves.

In the end, you just need able programmers, whether you code from scratch or implement based on a framework.

But they do teach best practices to those that are open to learning.

And worst case scenario with a framework you get semi-working semi-hackish code that at least on some levels is secure and bug-free as opposed to one big security hole, filled with spaghetti code hell that some newbie developers produce.

Some of the vulnerabilities in frameworks become well known whereas with self built code, you don't exactly know the vulnerabilities are. I'm mostly thinking of joomla as a cms because it's written as a framework, and yet it has addons that are vulnerabilities.

I think it's like how people build viruses for Windows.

Frameworks provide a lot of code that you don't have to write though and there are often addons or tutorials to do things in frameworks that are more standardized than starting from scratch. Do you ever find that frameworks are like black boxes though?
I think in our modern age technology has evolved to become more addictive. The things that don't give us pleasure aren't used as much. Work was never meant to be fun, but doing it makes us happier in the long run.
Prev 1 2 3 Next All
Please log in or register to reply.
Live Events Refresh
IPSL
02:00
Ro16 Group A
Ret vs ggnore13
nOmaD vs Aether
Airneanach83
Liquipedia
RSL Revival
22:00
Offline Finals: Playoffs
Clem vs RogueLIVE!
Serral vs herO
Tasteless1977
ComeBackTV 1709
RotterdaM974
IntoTheiNu 749
TaKeTV 524
IndyStarCraft 430
LamboSC2201
kabyraGe 192
Rex87
3DClanTV 50
LiquipediaDiscussion
[ Submit Event ]
Live Streams
Refresh
StarCraft 2
Tasteless 1977
RotterdaM 974
IndyStarCraft 430
LamboSC2 201
ProTech133
Liquid`TLO 87
Rex 87
BRAT_OK 41
SHIN 32
StarCraft: Brood War
Britney 31356
actioN 302
Dewaltoss 121
sSak 27
Hm[arnc] 25
Noble 10
Dota 2
Gorgc8650
XaKoH 388
League of Legends
KnowMe484
Counter-Strike
pashabiceps1140
Heroes of the Storm
Khaldor437
Other Games
singsing4793
Grubby2521
FrodaN1105
Beastyqt536
B2W.Neo395
Mew2King91
Railgan11
febbydoto1
Organizations
Other Games
EGCTV852
gamesdonequick799
[ Show 15 non-featured ]
StarCraft 2
• Adnapsc2 9
• Reevou 4
• AfreecaTV YouTube
• intothetv
• Kozan
• IndyKCrew
• Migwel
StarCraft: Brood War
• Pr0nogo 3
• BSLYoutube
• STPLYoutube
• ZZZeroYoutube
Dota 2
• WagamamaTV625
League of Legends
• Nemesis3183
Other Games
• imaqtpie534
• Shiphtur435
Upcoming Events
BSL
1h 30m
Bonyth vs Doodle
Kyrie vs Jimin
Replay Cast
4h 30m
Tournament
13h 30m
WardiTV Weekly
17h 30m
Ultimate Battle
17h 30m
Bisu vs Light
Kung Fu Cup
1d 16h
Solar vs Classic
ByuN vs SHIN
PiGosaur Cup
2 days
The PondCast
3 days
KCM Race Survival
3 days
Liquipedia Results

Completed

Proleague 2026-11-17
Blizzard Classic Cup 2026
HCC Season 3

Ongoing

Acropolis #5
KCM Race Survival 2026 Season 4
International ShieldBattery League
BSL Season 23
IPSL Winter 2026-27
RSL Offline Finals
Calamity Cup Div. A Season 8
Underdog Cup 2026 Div 2-3
Stake Ranked Episode 6
BLAST Rivals Fall 2026
IEM Beijing 2026
PGL Masters Bucharest 2026
Stake Ranked Episode 5
1win Private Club #2
Thunderpick World Champ. '26
ESL Pro League Season 24
Stake Ranked Episode 4
1win Private Club #1
Logitech G Play Connect 2026
SL StarSeries Fall 2026
FISSURE Playground #3

Upcoming

CSL Season 23: Qualifier 1
Sector 591
Sijosae Cup
CSL Season 23: Qualifier 2
YSL S4
SC4ALL II: Brood War
CSL 2026 Winter (S23) - 3v3
HSC XXX
Stellar Fest 2: Lunar Cup
StarCraft2 Weekly Open Tournament 2026 Grand Finals
SC4ALL II: StarCraft II
Kung Fu Cup 2026 Grand Finals
IEM Kraków 2027
PGL Bucharest 2027
BLAST Bounty Winter 2027
PGL Major Singapore 2026
TLPD

1. ByuN
2. TY
3. Dark
4. Solar
5. Stats
6. Nerchio
7. sOs
8. soO
9. INnoVation
10. Elazer
1. Rain
2. Flash
3. EffOrt
4. Last
5. Bisu
6. Soulkey
7. Mini
8. Sharp
Sidebar Settings...

Advertising | Privacy Policy | Terms Of Use | Contact Us

Original banner artwork: Jim Warren
The contents of this webpage are copyright © 2026 TLnet. All Rights Reserved.