looks really great.
one small thing i noticed. The lettering is not centered in the box on the left side:
e.g. http://aligulac.com/players/48-INnoVation/

TheBB

Switzerland5133 Posts

September 26 2013 16:40 GMT

#242

On September 27 2013 01:31 StarGalaxy wrote:
looks really great.
one small thing i noticed. The lettering is not centered in the box on the left side:
e.g. http://aligulac.com/players/48-INnoVation/

Can you make a screenshot of what you mean? I'm not sure I see it.

Be sure to forcibly refresh your CSS and JS files before trying. Probably Ctrl+F5 depending on your browser.

shid0x

Korea (South)5014 Posts

September 26 2013 17:27 GMT

#243

When you're checking a player profile what use does the column ''form'' has ?
I assume it shows the stats according to the latest results of the player but how far does it go ? 2 weeks ? 1 month ?

Grayson Carlyle

Canada219 Posts

September 26 2013 17:39 GMT

#244

The tabs at the top of player ages (e.g. http://aligulac.com/players/48-INnoVation/) have the tab switching function (onclick="switch_tab...") tied to an anchor tag, making them fairly difficult to click. Putting the function on the encompassing td tag would make switching easier and from looking at the function itself, wouldn't require any JS changes.

TheBB

Switzerland5133 Posts

September 26 2013 17:43 GMT

#245

On September 27 2013 02:27 shid0x wrote:
When you're checking a player profile what use does the column ''form'' has ?
I assume it shows the stats according to the latest results of the player but how far does it go ? 2 weeks ? 1 month ?

Two months. I think that's a bit on the long end, I might change it.

On September 27 2013 02:39 Grayson Carlyle wrote:
The tabs at the top of player ages (e.g. http://aligulac.com/players/48-INnoVation/) have the tab switching function (onclick="switch_tab...") tied to an anchor tag, making them fairly difficult to click. Putting the function on the encompassing td tag would make switching easier and from looking at the function itself, wouldn't require any JS changes.

Good point, I did it like this because I learned earlier that tds can't be links. I assume there won't be a hand-finger cursor on the td to indicate a clickable point?

Grayson Carlyle

Canada219 Posts

September 26 2013 17:58 GMT

#246

You can make them have the hand cursor by adding the css

.tabsel, .tabunsel {
    cursor: pointer;
}

Things don't need to be links to be able to activate javascript

Other thing I noticed:
When mousing over the first row of menu options (Ranking Teams Records Results Reports Inference About Submit) it shows the relevant 2nd level menu options, but if you attempt to click them the menu options revert to the page default. This is confusing behaviour.

Removing this function (generated per-page, here's the ranking page version):

document.onmouseover = function (e)
{
    if (!is_descendant(document.getElementById('menu_container'), e.target))
        hover('Ranking');
}

would cause the sub-menus not to revert, but then doesn't give you access to the default ones unless you mouse back over this page's menu option. It's a tradeoff, but I think keeping them visible after mousing over them is the more intuitive behaviour.

StarGalaxy

Germany744 Posts

September 26 2013 21:48 GMT

#247

On September 27 2013 01:40 TheBB wrote:

Show nested quote +

Can you make a screenshot of what you mean? I'm not sure I see it.

Be sure to forcibly refresh your CSS and JS files before trying. Probably Ctrl+F5 depending on your browser.

It is looking how it is supposed to now. =)

TheBB

Switzerland5133 Posts

September 26 2013 22:20 GMT

#248

Thanks Grayson, we ended up pulling a similar fix for the menu using jQuery. Hopefully it's a bit easier to use now.

Grayson Carlyle

Canada219 Posts

September 27 2013 01:06 GMT

#249

On September 27 2013 07:20 TheBB wrote:
Thanks Grayson, we ended up pulling a similar fix for the menu using jQuery. Hopefully it's a bit easier to use now.

Nice! I wasn't about to go telling you how to write clean JS, so I just went with what was already there, but I'm glad you found a very elegant solution.

kurosu_

France46 Posts

September 28 2013 08:53 GMT

#250

Something that has bugged me about the ratings, quantization of the values:
1) When a player is expected to do, say, 5.2:4.8, but actually achieves 5:5, the rating goes down, but there's no way he could have performed according to the decimal parts
2) How much of this accumulates over time? Probably it goes both ways (ie 4.8:3.2 and 5:3) on average but this feels weird

Dghelneshi

Germany82 Posts

September 28 2013 09:03 GMT

#251

On September 28 2013 17:53 kurosu_ wrote:
Something that has bugged me about the ratings, quantization of the values:
1) When a player is expected to do, say, 5.2:4.8, but actually achieves 5:5, the rating goes down, but there's no way he could have performed according to the decimal parts
2) How much of this accumulates over time? Probably it goes both ways (ie 4.8:3.2 and 5:3) on average but this feels weird

I think it might make more sense to you if you think about comparing different players. If there are two players and one is better (according to the rating system), but both would be predicted at 5:5 due to rounding down/up (5.5:4.5 vs 4.5:5.5), it would practically make the two players even in skill.

You can also look at other "stochastic objects" like dice. A 6-sided die's expected value is 3.5. If you want to "test" a die whether it's actually balanced (=test whether a player is actually rated correctly), you let your statistic model expect a value of 3.5, even though it can't actually happen on an individual roll and adjust the result accordingly with each roll you do (give the player +/- rating).

slowbacontron

United States7722 Posts

September 28 2013 09:12 GMT

#252

Quick question, when you predict a best of n match between two players, why are their race icons white?

example http://aligulac.com/inference/match/?bo=3&ps=1978,51
http://aligulac.com/inference/match/?bo=1&ps=19,15

TheBB

Switzerland5133 Posts

September 28 2013 11:20 GMT

#253

On September 28 2013 18:12 slowbacontron wrote:
Quick question, when you predict a best of n match between two players, why are their race icons white?

I just didn't feel the normal icons looked very good on the dark background, that's all.

slowbacontron

United States7722 Posts

September 28 2013 19:36 GMT

#254

On September 28 2013 20:20 TheBB wrote:

Show nested quote +

I just didn't feel the normal icons looked very good on the dark background, that's all.

Hmm, ok. Personally I see the colors as an additional way to distinguish between the races, but since the prediction is just between two players it doesn't make a big difference.

StarGalaxy

Germany744 Posts

September 29 2013 11:19 GMT

#255

there is no "korea" under the country filter:
e.g. http://aligulac.com/players/29/results/?after=2013-07-04&before=&race=t&country=foreigners&bestof=all&offline=both&game=all&op=Filter
would be cool if it would be placed right above "non korea" since it is the most important option imho.

Conti

Germany2516 Posts

September 29 2013 11:21 GMT

#256

There is, under South Korea.

Grovbolle

Denmark3804 Posts

September 29 2013 11:49 GMT

#257

On September 29 2013 20:19 StarGalaxy wrote:
there is no "korea" under the country filter:
e.g. http://aligulac.com/players/29/results/?after=2013-07-04&before=&race=t&country=foreigners&bestof=all&offline=both&game=all&op=Filter
would be cool if it would be placed right above "non korea" since it is the most important option imho.

Considering Korea isn't an actual country it makes sense to keep it under South Korea. I am also fairly certain we are using an imported library of countries which has been modified to include "Non-Koreans", which is why it is called South Korea and not just Korea

Hier

2391 Posts

September 30 2013 18:08 GMT

#258

Sorry if the following is answered somewhere; I didn't find the answer. Where did the Swiss group prediction option go?

slowbacontron

United States7722 Posts

September 30 2013 18:15 GMT

#259

On October 01 2013 03:08 Hier wrote:
Sorry if the following is answered somewhere; I didn't find the answer. Where did the Swiss group prediction option go?

In a group of 4 players, it's the same thing as a double elimination tournament.

TheBB

Switzerland5133 Posts

September 30 2013 18:36 GMT

#260

On October 01 2013 03:08 Hier wrote:
Sorry if the following is answered somewhere; I didn't find the answer. Where did the Swiss group prediction option go?

I renamed it «dual tournament» since that's what most people seem to be calling it now.