Yo so I did a code walkthrough to explain what I've done to my supervisor, and he was saying that a good rule of thumb is to have a comment for every 3 lines of code? Is it just me or is that crazy high?

x++; // increment x by one

Requizen

United States33802 Posts

March 17 2014 21:07 GMT

#28828

General rule of thumb that I (sometimes) abide by:

A function should never be more than 10-20 lines long. Comment describing function, comment for each loop (unless it's really simple like printing out a row of numbers).

That should generally cover everything necessary, unless you have some really complex shit going on.

Of course, it can depend on languages too. If you're using things like LINQ, it's much easier to see what query you're writing than if you're manually building a SQL query string on the fly.

Nos-

Canada12016 Posts

March 17 2014 21:10 GMT

#28829

On March 18 2014 05:51 Duvon wrote:

Show nested quote +

No! Then she-ablo will come and explode everyone all the time.

Yango just wants to be an old man

ketchup

14521 Posts

March 17 2014 21:19 GMT

#28830

On March 18 2014 05:50 TheYango wrote:
I'll be honest, the only thing I really want from Heroes is to be able to play as Deckard Cain.

I wasn't at all interested in Heroes of the Storm until you said this idea. That would be amazing to see. Please make it happen Yango

red_

United States8474 Posts

March 17 2014 21:24 GMT

#28831

On March 18 2014 05:49 Requizen wrote:

Show nested quote +

Oh no, I agree on those points, but I don't think it's enough to make a deal about. Like Parnage said, they have enough heroes to have releases for a long time. It's been out for a few days.

And like I said, they probably wanted to put in things from the current games. While Gazlowe is less influential than Mannoroth in the long run, more WoW-only players know Gazlowe (Not to mention that he fills a niche role with his charge beam and turrets, while Mannoroth would likely be very similar to Diablo).

I think you'd have decriers no matter which order they chose to implement some characters, and while you and many here are likely more partial to the old, nostalgic characters that you know as big bad guys/big ol' heroes, you'd get people complaining if they came in before more modern, relevant characters.

I mean, even if we go from WoW, Onyxia, Ragnaros, Kel'Thuzad, KJ, Nefarian, either of the major frost wyrms(Sapph or Sindra)... there are so many good bosses/villains to choose from that are incredibly notable and popular.

Za'Muro being the orc represented is a fucking tragedy. No Grom or Thrall or Garrosh(for the modern players).

Azmodan and the 3 generic classes from D3 all being in at the start seems like such an oversaturation, especially given how popular D2 is(represented only by the model chosen for Diablo).

I can get that they might want to slant towards their 'modern' characters more, but they pretty much completely neglected anyone who has been gaming with them from before 2004 or so.

Alzadar

Canada5009 Posts

March 17 2014 21:26 GMT

#28832

Haven't followed any Heroes news but it seems like Fenix changing into a different unit on death would be a really cool mechanic. Zealot -> die -> Dragoon -> die for real -> respawn as Zealot

I fear no enemy, for the Khala is my strength! I fear not death, for our strength is eternal!

WiseBagus

Canada452 Posts

March 17 2014 21:31 GMT

#28833

They have a large pool to pull from the books. that will also give them a lot of creative freedom because some descriptions are pretty vague

Requizen

United States33802 Posts

March 17 2014 21:32 GMT

#28834

Started my mono-type run in Sapphire, RNG'd Flying. Cool enough, right?

First gym is Rock. FML.

Edit:

THIS IS FANTASTIC NEWS

SagaZ

France3460 Posts

March 17 2014 21:43 GMT

#28835

On March 18 2014 06:26 Alzadar wrote:
Haven't followed any Heroes news but it seems like Fenix changing into a different unit on death would be a really cool mechanic. Zealot -> die -> Dragoon -> die for real -> respawn as Zealot

I fear no enemy, for the Khala is my strength! I fear not death, for our strength is eternal!

yeah welcome to the moba, you are playing as Fenix, the dragoon
passive: shitty pathfinding so whenever you click somewhere to go your dude will usually go in another random direction

Omnishroud

1073 Posts

March 17 2014 21:44 GMT

#28836

Roflol pika pika

Gahlo

United States35173 Posts

March 17 2014 21:47 GMT

#28837

Now I want to see pikachu do post goal celebrations. Preferably against Canada.

jcarlsoniv

United States27922 Posts

March 17 2014 22:06 GMT

#28838

On March 18 2014 05:21 TheYango wrote:
So DotA has a shitty client and attracts toxic players who are elitist about their game, while League has some shitty UI design and has a great business model but a balance team that's not at all in tune with the problems in their game?

sounds about right

On March 18 2014 05:47 Parnage wrote:
Stitches is actually a pretty big deal to any old school wow player. That guy was the terror of every alliance character leveling in duskwood for quite a while. Walking down the road when suddenly this highlevel elite mob rounds the bend and faceplants you on his way to mess up your questing hub town. He was later nerfed but the original stitches was the 2nd most terrifying thing to encounter while leveling in Vanilla(next to Rexxar and Misha wandering around Desolace)

can confirm - first character was a holy priest, I had sad times

#IHopeJonGaltIsStillAlive