• Log InLog In
  • Register
Liquid`
Team Liquid Liquipedia
EDT 22:32
CEST 04:32
KST 11:32
  • Home
  • Forum
  • Calendar
  • Streams
  • Liquipedia
  • Features
  • Store
  • EPT
  • TL+
  • StarCraft 2
  • Brood War
  • Smash
  • Heroes
  • Counter-Strike
  • Overwatch
  • Liquibet
  • Fantasy StarCraft
  • TLPD
  • StarCraft 2
  • Brood War
  • Blogs
Forum Sidebar
Events/Features
News
Featured News
HomeStory Cup 27 - Info & Preview18Classic wins Code S Season 2 (2025)16Code S RO4 & Finals Preview: herO, Rogue, Classic, GuMiho0TL Team Map Contest #5: Presented by Monster Energy6Code S RO8 Preview: herO, Zoun, Bunny, Classic7
Community News
Weekly Cups (June 23-29): Reynor in world title form?12FEL Cracov 2025 (July 27) - $8000 live event16Esports World Cup 2025 - Final Player Roster14Weekly Cups (June 16-22): Clem strikes back1Weekly Cups (June 9-15): herO doubles on GSL week4
StarCraft 2
General
Weekly Cups (June 23-29): Reynor in world title form? StarCraft Mass Recall: SC1 campaigns on SC2 thread The SCII GOAT: A statistical Evaluation How does the number of casters affect your enjoyment of esports? Esports World Cup 2025 - Final Player Roster
Tourneys
FEL Cracov 2025 (July 27) - $8000 live event HomeStory Cup 27 (June 27-29) WardiTV Mondays SOOPer7s Showmatches 2025 $200 Biweekly - StarCraft Evolution League #1
Strategy
How did i lose this ZvP, whats the proper response Simple Questions Simple Answers [G] Darkgrid Layout
Custom Maps
[UMS] Zillion Zerglings
External Content
Mutation # 480 Moths to the Flame Mutation # 479 Worn Out Welcome Mutation # 478 Instant Karma Mutation # 477 Slow and Steady
Brood War
General
ASL20 Preliminary Maps BGH Auto Balance -> http://bghmmr.eu/ BW General Discussion StarCraft & BroodWar Campaign Speedrun Quest Unit and Spell Similarities
Tourneys
[Megathread] Daily Proleagues [BSL20] GosuLeague RO16 - Tue & Wed 20:00+CET The Casual Games of the Week Thread [BSL20] ProLeague LB Final - Saturday 20:00 CET
Strategy
Simple Questions, Simple Answers I am doing this better than progamers do.
Other Games
General Games
Stormgate/Frost Giant Megathread Nintendo Switch Thread Path of Exile What do you want from future RTS games? Beyond All Reason
Dota 2
Official 'what is Dota anymore' discussion
League of Legends
Heroes of the Storm
Simple Questions, Simple Answers Heroes of the Storm 2.0
Hearthstone
Heroes of StarCraft mini-set
TL Mafia
TL Mafia Community Thread Vanilla Mini Mafia
Community
General
Trading/Investing Thread US Politics Mega-thread Things Aren’t Peaceful in Palestine Stop Killing Games - European Citizens Initiative Russo-Ukrainian War Thread
Fan Clubs
SKT1 Classic Fan Club! Maru Fan Club
Media & Entertainment
Anime Discussion Thread [Manga] One Piece [\m/] Heavy Metal Thread Korean Music Discussion
Sports
2024 - 2025 Football Thread NBA General Discussion Formula 1 Discussion TeamLiquid Health and Fitness Initiative For 2023 NHL Playoffs 2024
World Cup 2022
Tech Support
Computer Build, Upgrade & Buying Resource Thread
TL Community
The Automated Ban List
Blogs
from making sc maps to makin…
Husyelt
Blog #2
tankgirl
Game Sound vs. Music: The Im…
TrAiDoS
StarCraft improvement
iopq
Heero Yuy & the Tax…
KrillinFromwales
Trip to the Zoo
micronesia
Customize Sidebar...

Website Feedback

Closed Threads



Active: 558 users

C++ revision help! - Page 5

Blogs > konadora
Post a Reply
Prev 1 2 3 4 5 6 7 Next All
konadora *
Profile Blog Joined February 2009
Singapore66156 Posts
July 09 2009 22:51 GMT
#81
Oh lol

Kk thanks
POGGERS
qrs
Profile Blog Joined December 2007
United States3637 Posts
Last Edited: 2009-07-09 22:54:14
July 09 2009 22:53 GMT
#82
'As per the American Heart Association, the beat of the Bee Gees song "Stayin' Alive" provides an ideal rhythm in terms of beats per minute to use for hands-only CPR. One can also hum Queen's "Another One Bites The Dust".' —Wikipedia
fusionsdf
Profile Blog Joined June 2006
Canada15390 Posts
Last Edited: 2009-07-10 00:37:39
July 10 2009 00:37 GMT
#83
On July 10 2009 01:47 Cambium wrote:
You need to figure out the inequalities... you have 0 < a < 20 and 20 < a < 25, i.e. you don't cover the case where a == 20.


#include <iostream>
using namespace std;

int main()
{
double w, h;
double a;
cout << "Please enter your weight (in KG) and height (in meters)." << endl;
cin >> w >> h;
// assuming you can't weight 0 kg and have 0 cm height ( h = 0 actually give you division by zero exception
if( w <= 0 || h <= 0 ) {
cout << "Invalid input." << endl;
return 0;
} else {
a = (w/(h*h));
cout << "Your Body Mass Index is " << a << endl;
}

if ( a > 0 && a < 20 )
cout << "You have a low BMI." << endl;
else if ( a > 20 && a < 25 )
cout << "You are within the healthy BMI range. Congratulations!" << endl;
else
cout << "You have exceeded the healthy BMI range." << endl;

return 0;
}


ewww. I was always taught multiple return statements like that are frowned upon. to be honest, I'm not exactly sure what's considered acceptable in a professional environment. The code (if someone else is wondering) will still work perfectly, its just a matter of style.
SKT_Best: "I actually chose Protoss because it was so hard for me to defeat Protoss as a Terran. When I first started Brood War, my main race was Terran."
Cambium
Profile Blog Joined June 2004
United States16368 Posts
July 10 2009 00:59 GMT
#84
Multiple return statements are acceptable in a professional environment.
When you want something, all the universe conspires in helping you to achieve it.
konadora *
Profile Blog Joined February 2009
Singapore66156 Posts
July 10 2009 01:52 GMT
#85
Okay I debugged the thing

#include <iostream>
using namespace std;

int main()
{
double w, h;
double a;
cout << "Please enter your weight (in KG) and height (in meters)." << endl;
cin >> w >> h;
if (w <= 0 || h <= 0){
cout << "Invalid input." << endl;
return 0;
} else {
a = (w/(h*h));
cout << "Your Body Mass Index is " << a << "." << endl;
}
if ( a > 0 && a < 20 )
cout << "You have a low BMI." << endl;
else if ( a > 20 && a < 25 )
cout << "You are within the healthy BMI range. Congratulations!" << endl;
else
cout << "You have exceeded the healthy BMI range." << endl;

return 0;
}


And still, if I input two negative values, "You have a low BMI." still shows. What's the problem here?
POGGERS
Cambium
Profile Blog Joined June 2004
United States16368 Posts
July 10 2009 02:00 GMT
#86
that's surprising... did you copy and paste or did you modify your source?
When you want something, all the universe conspires in helping you to achieve it.
konadora *
Profile Blog Joined February 2009
Singapore66156 Posts
Last Edited: 2009-07-10 02:01:06
July 10 2009 02:00 GMT
#87
Modify

Oh, and happy birthday
POGGERS
Cambium
Profile Blog Joined June 2004
United States16368 Posts
July 10 2009 02:01 GMT
#88
paste your source
When you want something, all the universe conspires in helping you to achieve it.
Cambium
Profile Blog Joined June 2004
United States16368 Posts
July 10 2009 02:01 GMT
#89
thanks for the hb
When you want something, all the universe conspires in helping you to achieve it.
konadora *
Profile Blog Joined February 2009
Singapore66156 Posts
July 10 2009 02:14 GMT
#90
#include <iostream>
using namespace std;

int main()
{
double w, h;
double a;
cout << "Please enter your weight (in KG) and height (in meters)." << endl;
cin >> w >> h;
a = (w/(h*h));
if (w > 0, h > 0)
cout << "Your Body Mass Index is " << a << endl;
else
cout << "Invalid input." << endl;

if (0 < a < 20, w > 0, h > 0)
cout << "You have a low BMI." << endl;
else if (20 < a < 25, w > 0, h > 0)
cout << "You are within the healthy BMI range. Congratulations!" << endl;
else
cout << "You have exceeded the healthy BMI range." << endl;
return 0;
}
POGGERS
GogoKodo
Profile Blog Joined April 2003
Canada1785 Posts
Last Edited: 2009-07-10 02:19:37
July 10 2009 02:18 GMT
#91
Are you still using commas in the 'if' statements? If you are then that's a problem. You have to use && for AND, || for OR

I guess you maybe just pasted the wrong source?
twitter: @terrancem
konadora *
Profile Blog Joined February 2009
Singapore66156 Posts
July 10 2009 02:19 GMT
#92
Nope. The modified one is the one few posts above
POGGERS
GogoKodo
Profile Blog Joined April 2003
Canada1785 Posts
July 10 2009 02:20 GMT
#93
Ok. I got confused because your last post has the commas in it.
twitter: @terrancem
Cambium
Profile Blog Joined June 2004
United States16368 Posts
July 10 2009 02:20 GMT
#94
What's your OS and what IDE/compiler are you using?

I'm amazed at its ability to interpret equalities and inequalities...

The problem with your code is that you don't terminate when you detected invalid inputs. The program continues to run and since two negatives give you a positive, you get "You have a low BMI".

After you terminate, you no longer need to check w > 0 and h > 0, as you have already done so.

#include <iostream>
using namespace std;

int main()
{
double w, h;
double a;
cout << "Please enter your weight (in KG) and height (in meters)." << endl;
cin >> w >> h;
a = (w/(h*h));
if (w > 0, h > 0)
cout << "Your Body Mass Index is " << a << endl;
else {
cout << "Invalid input." << endl;
return 0;
}

if (0 < a < 20, w > 0, h > 0)
cout << "You have a low BMI." << endl;
else if (20 < a < 25, w > 0, h > 0)
cout << "You are within the healthy BMI range. Congratulations!" << endl;
else
cout << "You have exceeded the healthy BMI range." << endl;
return 0;
}
When you want something, all the universe conspires in helping you to achieve it.
konadora *
Profile Blog Joined February 2009
Singapore66156 Posts
July 10 2009 02:22 GMT
#95
Ooooh

I was wondering but, it's okay to have many 'return 0; ' statements?
POGGERS
GogoKodo
Profile Blog Joined April 2003
Canada1785 Posts
July 10 2009 02:23 GMT
#96
Now Cambium is modifying the source with the commas too. Hrmm, perhaps I'm still confused as to what your latest source is.
twitter: @terrancem
Cambium
Profile Blog Joined June 2004
United States16368 Posts
July 10 2009 02:23 GMT
#97
I'm confused. Which source are you running?

There is no way you get anything beyond "invalid input" if you ran the code below...

if (w <= 0 || h <= 0){
cout << "Invalid input." << endl;
return 0;
}


catches any negative inputs.

+ Show Spoiler +


#include <iostream>
using namespace std;

int main()
{
double w, h;
double a;
cout << "Please enter your weight (in KG) and height (in meters)." << endl;
cin >> w >> h;
if (w <= 0 || h <= 0){
cout << "Invalid input." << endl;
return 0;
} else {
a = (w/(h*h));
cout << "Your Body Mass Index is " << a << "." << endl;
}
if ( a > 0 && a < 20 )
cout << "You have a low BMI." << endl;
else if ( a > 20 && a < 25 )
cout << "You are within the healthy BMI range. Congratulations!" << endl;
else
cout << "You have exceeded the healthy BMI range." << endl;

return 0;
}
When you want something, all the universe conspires in helping you to achieve it.
GogoKodo
Profile Blog Joined April 2003
Canada1785 Posts
July 10 2009 02:26 GMT
#98
It's sort of ok. You can do it, but for beginning programming it's usually much easier to keep a single return for a function (main in this case).
twitter: @terrancem
Cambium
Profile Blog Joined June 2004
United States16368 Posts
Last Edited: 2009-07-10 02:27:05
July 10 2009 02:26 GMT
#99
Yes, it's okay to have multiple return statements... but this is better structurally, because your first if/else statement doesn't make too much sense.



#include <iostream>
using namespace std;

int main()
{
double w, h;
double a;
cout << "Please enter your weight (in KG) and height (in meters)." << endl;
cin >> w >> h;
if (w <= 0 || h <= 0){
cout << "Invalid input." << endl;
} else {
a = (w/(h*h));
cout << "Your Body Mass Index is " << a << "." << endl;
if ( a > 0 && a < 20 )
cout << "You have a low BMI." << endl;
else if ( a > 20 && a < 25 )
cout << "You are within the healthy BMI range. Congratulations!" << endl;
else
cout << "You have exceeded the healthy BMI range." << endl;
}
return 0;
}
When you want something, all the universe conspires in helping you to achieve it.
konadora *
Profile Blog Joined February 2009
Singapore66156 Posts
July 10 2009 02:26 GMT
#100
OS = Vista 64-bit
Compiler = Visual C++ 2008 Express Edition

I'm using this one

#include <iostream>
using namespace std;

int main()
{
double w, h;
double a;
cout << "Please enter your weight (in KG) and height (in meters)." << endl;
cin >> w >> h;
if (w <= 0 || h <= 0){
cout << "Invalid input." << endl;
return 0;
} else {
a = (w/(h*h));
cout << "Your Body Mass Index is " << a << "." << endl;
}
if ( a > 0 && a < 20 )
cout << "You have a low BMI." << endl;
else if ( a > 20 && a < 25 )
cout << "You are within the healthy BMI range. Congratulations!" << endl;
else
cout << "You have exceeded the healthy BMI range." << endl;

return 0;
}


The one I posted after that was the original before I modified it
POGGERS
Prev 1 2 3 4 5 6 7 Next All
Please log in or register to reply.
Live Events Refresh
PiGosaur Monday
00:00
#38
PiGStarcraft694
rockletztv 41
Liquipedia
[ Submit Event ]
Live Streams
Refresh
StarCraft 2
PiGStarcraft694
RuFF_SC2 126
Livibee 97
StarCraft: Brood War
Artosis 704
MaD[AoV]21
Icarus 5
Dota 2
monkeys_forever601
febbydoto16
League of Legends
JimRising 741
Counter-Strike
summit1g9291
taco 330
Super Smash Bros
hungrybox537
Heroes of the Storm
Khaldor109
Other Games
tarik_tv7696
Fnx 3162
shahzam780
Maynarde196
CosmosSc2 24
Organizations
Other Games
gamesdonequick1137
StarCraft 2
Blizzard YouTube
StarCraft: Brood War
BSLTrovo
sctven
[ Show 16 non-featured ]
StarCraft 2
• Hupsaiya 116
• Kozan
• LaughNgamezSOOP
• sooper7s
• AfreecaTV YouTube
• intothetv
• Migwel
• IndyKCrew
StarCraft: Brood War
• Azhi_Dahaki2
• STPLYoutube
• ZZZeroYoutube
• BSLYoutube
League of Legends
• Doublelift4971
• Jankos1563
• masondota2689
Other Games
• Scarra1533
Upcoming Events
Replay Cast
21h 28m
The PondCast
1d 7h
RSL Revival
1d 7h
ByuN vs Classic
Clem vs Cham
WardiTV European League
1d 13h
Replay Cast
1d 21h
RSL Revival
2 days
herO vs SHIN
Reynor vs Cure
WardiTV European League
2 days
FEL
2 days
Korean StarCraft League
3 days
CranKy Ducklings
3 days
[ Show More ]
RSL Revival
3 days
FEL
3 days
Sparkling Tuna Cup
4 days
RSL Revival
4 days
FEL
4 days
BSL: ProLeague
4 days
Dewalt vs Bonyth
Replay Cast
5 days
Replay Cast
6 days
Liquipedia Results

Completed

Proleague 2025-06-28
HSC XXVII
Heroes 10 EU

Ongoing

JPL Season 2
BSL 2v2 Season 3
BSL Season 20
Acropolis #3
KCM Race Survival 2025 Season 2
CSL 17: 2025 SUMMER
Copa Latinoamericana 4
Championship of Russia 2025
RSL Revival: Season 1
Murky Cup #2
BLAST.tv Austin Major 2025
ESL Impact League Season 7
IEM Dallas 2025
PGL Astana 2025
Asian Champions League '25
BLAST Rivals Spring 2025
MESA Nomadic Masters
CCT Season 2 Global Finals
IEM Melbourne 2025
YaLLa Compass Qatar 2025

Upcoming

CSLPRO Last Chance 2025
CSLPRO Chat StarLAN 3
K-Championship
uThermal 2v2 Main Event
SEL Season 2 Championship
FEL Cracov 2025
Esports World Cup 2025
StarSeries Fall 2025
FISSURE Playground #2
BLAST Open Fall 2025
BLAST Open Fall Qual
Esports World Cup 2025
BLAST Bounty Fall 2025
BLAST Bounty Fall Qual
IEM Cologne 2025
FISSURE Playground #1
TLPD

1. ByuN
2. TY
3. Dark
4. Solar
5. Stats
6. Nerchio
7. sOs
8. soO
9. INnoVation
10. Elazer
1. Rain
2. Flash
3. EffOrt
4. Last
5. Bisu
6. Soulkey
7. Mini
8. Sharp
Sidebar Settings...

Advertising | Privacy Policy | Terms Of Use | Contact Us

Original banner artwork: Jim Warren
The contents of this webpage are copyright © 2025 TLnet. All Rights Reserved.