The Big Programming Thread - Page 415

On December 28 2013 13:35 sluggaslamoo wrote:

Show nested quote +

On December 28 2013 05:16 Yoshi- wrote:

On December 28 2013 04:53 sluggaslamoo wrote:


Still destroys the 3-5 lines recommendation that I gave that certain people told me was impossible. T_T

Are you trolling or that stupid?


You said sth among the lines "your functions shouldn't be longer than 3-5 lines", and not "the average length of your function should be around 3-5 lines", if you write a getter/setter for every variable you obviously get an extremely low average.


In many if/while expression you didn't used the brackets(which many people would most probably consider to be bad), if you would have written it in the "proper way" or if you ever need to add another statement to those structure, it would obviously inflate your average.
If you would have used a different coding style like Allman, it would also have increased your line count.


So yea your 3-5 lines recommendation is bullshit, since you 1) weren't talking about averages and 2) it heavily depends on the coding style.

Or you used the ternary operator, many people would have used a normal if structure instead, since those are much easier to understand at the first look, but obviously much longer.

And you were also saying that you shouldn't repeat yourself.

  public List<Cell> getColumn(int columnNumber) {
    List<Cell> row = new ArrayList();
    for(int i = 0; i < widthTiles; i++)
      row.add(getCell(columnNumber, i));
    return row;
  }
  
  public List<Cell> getDiagonalRowTop() {
    List<Cell> row = new ArrayList();
    for(int i = 0; i < widthTiles; i++)
      row.add(getCell(i, i));
    return row;
  }
  
  public List<Cell> getDiagonalRowBottom() {
    List<Cell> row = new ArrayList();
    for(int i = 0; i < widthTiles; i++)
      row.add(getCell(i, widthTiles-i-1));
    return row;
  }
 

How would you do it?

Show nested quote +

On November 12 2013 01:52 Yoshi- wrote:

On November 11 2013 07:30 sluggaslamoo wrote:

If you have any functions that are longer than 10 lines seriously have a look at them and see if you can't break them down. Most of my functions are 1-3 (ruby) lines long, this is due to functional programming though, I'd say for PHP they should float between 3 to 5 lines on average.

Yea that is bullshit
I all up for splitting code into smaller part, but saying that you should average between 3 to 5 lines is just ridiculous

Would you like some cold water for your burn?

I really just think you don't know much about programming, keep limiting yourself and thinking everything is bullshit. And trolling one of the bigger contributors to this thread while contributing none of your own.

My average was 2.97, adding a brace using the standard method would maybe add 1 or 2 lines to some methods, a lot of them none at all. So 4-5? That still fits within 3-5 lines. Only two methods were longer than 5 lines as well.

By the way not once did I think about lines of code throughout, if you have good basics, that's what you'll get. Actually as I was rushing this, I was barely thinking at all, just sticking to basics. That's the entire point, functional decomposition.

Let me know if you want any programming lessons.

var getDiagBottom = function(i) {
	return getCell(i, widthTiles - i - 1);
};

var getDiagTop = function(i) {
	return getCell(i, i);
};

// Returns a function which searches along a specific column.
var getColumn = function(columnNumber) {
	return function(i) {
		getCell(columnNumber, i);
	};
};

// Takes an iterator function to build a list of tiles.
var getTiles = function(fn) {
	var tiles = [];
	for (var i = 0; i < widthTiles; i++)
		tiles.push(fn(i));
	return tiles;
};

// getTiles(getColumn(1));
// getTiles(getDiagTop);
// getTiles(getDiagBottom);

On December 28 2013 20:50 InvaderUK wrote:

Show nested quote +

On December 28 2013 13:35 sluggaslamoo wrote:

On December 28 2013 05:16 Yoshi- wrote:

On December 28 2013 04:53 sluggaslamoo wrote:


Still destroys the 3-5 lines recommendation that I gave that certain people told me was impossible. T_T

Are you trolling or that stupid?


You said sth among the lines "your functions shouldn't be longer than 3-5 lines", and not "the average length of your function should be around 3-5 lines", if you write a getter/setter for every variable you obviously get an extremely low average.


In many if/while expression you didn't used the brackets(which many people would most probably consider to be bad), if you would have written it in the "proper way" or if you ever need to add another statement to those structure, it would obviously inflate your average.
If you would have used a different coding style like Allman, it would also have increased your line count.


So yea your 3-5 lines recommendation is bullshit, since you 1) weren't talking about averages and 2) it heavily depends on the coding style.

Or you used the ternary operator, many people would have used a normal if structure instead, since those are much easier to understand at the first look, but obviously much longer.

And you were also saying that you shouldn't repeat yourself.

  public List<Cell> getColumn(int columnNumber) {
    List<Cell> row = new ArrayList();
    for(int i = 0; i < widthTiles; i++)
      row.add(getCell(columnNumber, i));
    return row;
  }
  
  public List<Cell> getDiagonalRowTop() {
    List<Cell> row = new ArrayList();
    for(int i = 0; i < widthTiles; i++)
      row.add(getCell(i, i));
    return row;
  }
  
  public List<Cell> getDiagonalRowBottom() {
    List<Cell> row = new ArrayList();
    for(int i = 0; i < widthTiles; i++)
      row.add(getCell(i, widthTiles-i-1));
    return row;
  }
 

How would you do it?

On November 12 2013 01:52 Yoshi- wrote:

On November 11 2013 07:30 sluggaslamoo wrote:

If you have any functions that are longer than 10 lines seriously have a look at them and see if you can't break them down. Most of my functions are 1-3 (ruby) lines long, this is due to functional programming though, I'd say for PHP they should float between 3 to 5 lines on average.

Yea that is bullshit
I all up for splitting code into smaller part, but saying that you should average between 3 to 5 lines is just ridiculous

Would you like some cold water for your burn?

I really just think you don't know much about programming, keep limiting yourself and thinking everything is bullshit. And trolling one of the bigger contributors to this thread while contributing none of your own.

My average was 2.97, adding a brace using the standard method would maybe add 1 or 2 lines to some methods, a lot of them none at all. So 4-5? That still fits within 3-5 lines. Only two methods were longer than 5 lines as well.

By the way not once did I think about lines of code throughout, if you have good basics, that's what you'll get. Actually as I was rushing this, I was barely thinking at all, just sticking to basics. That's the entire point, functional decomposition.

Let me know if you want any programming lessons.

I agree with your sentiment of splitting functionality into short functions that do one thing well, for the most part it is completely possible and good practice. Most (but not all) functions shouldn't be longer than 10 lines.

However there is code reuse in those three functions quoted. Since each function is creating a list, iterating through the tiles, adding cells to the list and returning it.

One could write a function which does the work described, and takes input telling it what parameters it should use with getCell while iterating through the tile space.

The result would be one slightly longer function which does the work of those three functions, and also has functionality that extends beyond them. (If you wanted to get tiles in a different manner, modify the parameters of this function rather than defining another function.)

EDIT:

On further reflection, passing in arguments to replace those functions is probably a bit of a stretch. You can still use a map function which iterates over widthTiles and pass in smaller functions that get the required cell. This would make your four getter functions one liners rather than 4-5 liners (Four lines is clearly too long for any function /s).

I don't write Java so unsure of implementing the mapping function as I've heard it doesn't properly support first class functions.

JS proof of concept:

var getDiagBottom = function(i) {
	return getCell(i, widthTiles - i - 1);
};

var getDiagTop = function(i) {
	return getCell(i, i);
};

// Returns a function which searches along a specific column.
var getColumn = function(columnNumber) {
	return function(i) {
		getCell(columnNumber, i);
	};
};

// Takes an iterator function to build a list of tiles.
var getTiles = function(fn) {
	var tiles = [];
	for (var i = 0; i < widthTiles; i++)
		tiles.push(fn(i));
	return tiles;
};

// getTiles(getColumn(1));
// getTiles(getDiagTop);
// getTiles(getDiagBottom);

class Array
  def to_row #etc
end

class Row
  def solved? #etc
end

def check_results
  end_game if [
    { |i| [0..3].map {|col| cells[col, i]} },
    { |i| [0..3].map {|row| cells[i, row]} },
    {|i| cells[i, i]},
    {|i| cells[i, 3-i-1]}
  ].select { |proc| [0..3].map{|i| proc(i)}.to_row.solved? }.any?
end

for (T t : arrayList) {
    t.method();
}

for (id *object in arrayList) {
    [object method];
}

 
interface User32 extends com.sun.jna.platform.win32.User32 {
	User32 INSTANCE = (User32) Native.loadLibrary(User32.class, W32APIOptions.UNICODE_OPTIONS);
	LRESULT SendMessage(HWND hWnd, int Msg, WPARAM wParam, LPARAM lParam);
}
private static final User32 USER = User32.INSTANCE;
public static void main(String[] args) throws IOException, InterruptedException {
	WinDef.HWND target = USER.FindWindow(null, "windowname");
	USER.PostMessage(target, 0x0201, new WinDef.WPARAM(0x01), new WinDef.LPARAM(16 | 41 << 16));
	Thread.sleep(50);
	USER.PostMessage(target, 0x0202, new WinDef.WPARAM(0x00), new WinDef.LPARAM(16 | 41 << 16));
}

WinDef.HWND target = USER.FindWindow(null, "windowname");
		
USER.SendMessage(target, 0x0084,null, new WinDef.LPARAM(16 | 41 << 16));
USER.SendMessage(target, 0x0020,new WinDef.WPARAM(0x001A067C), new WinDef.LPARAM(1 | 0x0201 << 16));
USER.PostMessage(target, 0x0201, new WinDef.WPARAM(0x01), new WinDef.LPARAM(16 | 41 << 16));
Thread.sleep(50);
		
USER.SendMessage(target, 0x0084,null, new WinDef.LPARAM(16 | 41 << 16));
USER.SendMessage(target, 0x0020,new WinDef.WPARAM(0x001A067C), new WinDef.LPARAM(1 | 0x0202 << 16));
USER.PostMessage(target, 0x0202, new WinDef.WPARAM(0x00), new WinDef.LPARAM(16 | 41 << 16));

USER.SendMessage(target,0x0200,null,new WinDef.LPARAM(16|41<<16));

for (T t : arrayList) {
    t.method();
}

for (id *object in arrayList) {
    [object method];
}

import java.util.ArrayList;

public class ArrayListTest {
	public static <T> void iterate(ArrayList<T> list) {
		for(T t: list) {
			System.out.println(t.toString());
		}
	}

	public static void main(String[] args) {
		ArrayList<Integer> list = new ArrayList<>();
		list.add(2);
		list.add(3);
		iterate(list);
	}	
}

2
3

my cubelets[6][9];
{
  cubelets[0][0] = ( ["1 0", "4 2"] );
  cubelets[0][1] = "4 1";
  cubelets[0][2] = ( ["4 0", "3 2"] );
  cubelets[0][3] = "1 1";
  cubelets[0][5] = "3 1";
  cubelets[0][6] = ( ["1 2", "2 0"] );
  cubelets[0][7] = "2 1";
  cubelets[0][8] = ( ["2 2", "3 0"] );

  cubelets[1][0] = ( ["0 0", "4 2"] );
  cubelets[1][1] = "0 3";
  cubelets[1][2] = ( ["0 6", "2 0"] );
  cubelets[1][3] = "4 5";
  cubelets[1][5] = "2 3";
  cubelets[1][6] = ( ["4 8", "5 6"] );
  cubelets[1][7] = "5 3";
  cubelets[1][8] = ( ["2 6", "5 0"] );

  cubelets[2][0] = ( ["0 6", "1 2"] );
  cubelets[2][1] = "0 7";
  cubelets[2][2] = ( ["0 8", "3 0"] );
  cubelets[2][3] = "1 5";
  cubelets[2][5] = "3 3";
  cubelets[2][6] = ( ["1 8", "5 0"] );
  cubelets[2][7] = "5 1";
  cubelets[2][8] = ( ["3 6", "5 2"] );

  ...