|
Thread Rules 1. This is not a "do my homework for me" thread. If you have specific questions, ask, but don't post an assignment or homework problem and expect an exact solution. 2. No recruiting for your cockamamie projects (you won't replace facebook with 3 dudes you found on the internet and $20) 3. If you can't articulate why a language is bad, don't start slinging shit about it. Just remember that nothing is worse than making CSS IE6 compatible. 4. Use [code] tags to format code blocks. |
That explains the weird Syntax...
|
Russian Federation80 Posts
On December 17 2013 02:58 WarSame wrote: That explains the weird Syntax...
But still, why can't I run the code you wrote?
|
I'm not sure. The error you posted mentions that it is an error with the Scanner and Random parts. So did you include the import java.util.Random; import java.util.Scanner; section?
|
Russian Federation80 Posts
On December 17 2013 07:43 WarSame wrote:I'm not sure. The error you posted mentions that it is an error with the Scanner and Random parts. So did you include the section?
You are right, that's what I forgot to include. Now everything works perfectly. I have to improve my attentiveness, it looks like that's very important thing to have while coding.
|
Help me please. I'm having a huge brainfart right now...
I want to create a small int array with numbers from 1 to 5 in it, but the numbers need to be randomly placed inside the array each time. C doesn't have the shuffle() function so I have to go about it manually but I guess I've been thinking too much about it and can't get it to work...
#include <stdlib.h> #include <time.h> #include <stdio.h>
int main (void) { int order[5] = { 0, 0, 0, 0, 0 }; int number = 0;
srand((unsigned int) time(0));
for (int i = 0; i < 5; i += 1) { while (number == order[i]) { number = rand() % 6;
if (i >= 1) { for (int j = 0; j < 4; j += 1) { if (number == order[j]) { number = rand() % 6; } } } }
order[i] = number;
number = 0;
printf("%d \n", order[i]); }
return 0; }
It's in ANSI C but if you can give me example on how to go about it in other languages (C++/Java/C# etc.) I'll be able to understand it too.
|
On December 19 2013 02:35 Manit0u wrote:Help me please. I'm having a huge brainfart right now... I want to create a small int array with numbers from 1 to 5 in it, but the numbers need to be randomly placed inside the array each time. C doesn't have the shuffle() function so I have to go about it manually but I guess I've been thinking too much about it and can't get it to work... + Show Spoiler + #include <stdlib.h> #include <time.h> #include <stdio.h>
int main (void) { int order[5] = { 0, 0, 0, 0, 0 }; int number = 0;
srand((unsigned int) time(0));
for (int i = 0; i < 5; i += 1) { while (number == order[i] { number = rand() % 6;
if (i >= 1) { for (int j = 0; j < 4; j += 1) { if (number == order[j] { number = rand() % 6; } } } }
order[i] = number;
number = 0;
printf("%d \n", order[i] ; }
return 0; }
It's in ANSI C but if you can give me example on how to go about it in other languages (C++/Java/C# etc.) I'll be able to understand it too.
Untested since i'm too lazy, but this is a very simple shuffle implementation:
int array[5] = { 1,2,3,4,5 }; for (int i = 0; i < 5; ++i) { int new_pos = rand() % 5; int temp = array[i]; array[i] = array[new_pos]; array[new_pos] = temp; }
Basically, for every element in the array, you pick a random index and exchange the current element with the element at that index.
|
On December 19 2013 02:35 Manit0u wrote:Help me please. I'm having a huge brainfart right now... I want to create a small int array with numbers from 1 to 5 in it, but the numbers need to be randomly placed inside the array each time. C doesn't have the shuffle() function so I have to go about it manually but I guess I've been thinking too much about it and can't get it to work... + Show Spoiler + #include <stdlib.h> #include <time.h> #include <stdio.h>
int main (void) { int order[5] = { 0, 0, 0, 0, 0 }; int number = 0;
srand((unsigned int) time(0));
for (int i = 0; i < 5; i += 1) { while (number == order[i] { number = rand() % 6;
if (i >= 1) { for (int j = 0; j < 4; j += 1) { if (number == order[j] { number = rand() % 6; } } } }
order[i] = number;
number = 0;
printf("%d \n", order[i] ; }
return 0; }
It's in ANSI C but if you can give me example on how to go about it in other languages (C++/Java/C# etc.) I'll be able to understand it too.
Your while loop condition doesn't make sense. while (number == order[i]) will only be true on the first iteration when both are 0. after that you update number to a random value but order[i] will still be 0.
|
On December 19 2013 03:05 scudst0rm wrote:Show nested quote +On December 19 2013 02:35 Manit0u wrote:Help me please. I'm having a huge brainfart right now... I want to create a small int array with numbers from 1 to 5 in it, but the numbers need to be randomly placed inside the array each time. C doesn't have the shuffle() function so I have to go about it manually but I guess I've been thinking too much about it and can't get it to work... + Show Spoiler + #include <stdlib.h> #include <time.h> #include <stdio.h>
int main (void) { int order[5] = { 0, 0, 0, 0, 0 }; int number = 0;
srand((unsigned int) time(0));
for (int i = 0; i < 5; i += 1) { while (number == order[i] { number = rand() % 6;
if (i >= 1) { for (int j = 0; j < 4; j += 1) { if (number == order[j] { number = rand() % 6; } } } }
order[i] = number;
number = 0;
printf("%d \n", order[i] ; }
return 0; }
It's in ANSI C but if you can give me example on how to go about it in other languages (C++/Java/C# etc.) I'll be able to understand it too. Your while loop condition doesn't make sense. while (number == order[i]) will only be true on the first iteration when both are 0. after that you update number to a random value but order[i] will still be 0.
I knew I messed something up with the control statements and placement of things That's what you get for having 2 minutes at the computer and having to do different stuff for hours inbetween.
On December 19 2013 03:04 Morfildur wrote:Show nested quote +On December 19 2013 02:35 Manit0u wrote:Help me please. I'm having a huge brainfart right now... I want to create a small int array with numbers from 1 to 5 in it, but the numbers need to be randomly placed inside the array each time. C doesn't have the shuffle() function so I have to go about it manually but I guess I've been thinking too much about it and can't get it to work... + Show Spoiler + #include <stdlib.h> #include <time.h> #include <stdio.h>
int main (void) { int order[5] = { 0, 0, 0, 0, 0 }; int number = 0;
srand((unsigned int) time(0));
for (int i = 0; i < 5; i += 1) { while (number == order[i] { number = rand() % 6;
if (i >= 1) { for (int j = 0; j < 4; j += 1) { if (number == order[j] { number = rand() % 6; } } } }
order[i] = number;
number = 0;
printf("%d \n", order[i] ; }
return 0; }
It's in ANSI C but if you can give me example on how to go about it in other languages (C++/Java/C# etc.) I'll be able to understand it too. Untested since i'm too lazy, but this is a very simple shuffle implementation: int array[5] = { 1,2,3,4,5 }; for (int i = 0; i < 5; ++i) { int new_pos = rand() % 5; int temp = array[i]; array[i] = array[new_pos]; array[new_pos] = temp; }
Basically, for every element in the array, you pick a random index and exchange the current element with the element at that index.
Tried it like that:
#include <stdlib.h> #include <time.h> #include <stdio.h>
int main (void) { srand((unsigned int) time(0));
int arr[5] = { 1, 2, 3, 4, 5 }; int n = sizeof(arr);
while (n > 1) { int s = rand() % n; int tmp = arr[n];
n -= 1; arr[s] = arr[n]; arr[n] = tmp; }
for (int i = 0; i < 5; i += 1) { printf("%d, ", arr[i]); }
return 0; }
It compiles just fine but throws the "memory protection error" at me. Any ideas where I went wrong?
Edit: This works but not as intended (some of the elements get doubled).
srand((unsigned int) time(0));
int arr[5] = { 1, 2, 3, 4, 5 };
for (int i = 0; i < 5; i += 1) { int s = rand() % 5; int tmp = arr[i];
arr[i] = arr[s]; arr[s] = tmp; printf("%d\n", arr[i]); }
Edit2: I'm dumb... Forget about it
|
Hello, i need some help with linked lists in java. It's a program i have to write for my course and i can't find my error. I am not allowed to use the API class for lists. I somehow have a problem with my tail function which has to return a new list with out the head.
+ Show Spoiler + // get rest of list // note: this operation must create a new list (which may be empty = null) PlayerList tail() { PlayerList list = new PlayerList(head().getNext()); if(list.head() == null) { PlayerList empty = new PlayerList(); return empty; } return list; }
my constructors for the list: + Show Spoiler + // constructor for empty list PlayerList() { firstPlayer = null; } // constructor to start list with first player PlayerList(Player playr) { firstPlayer = playr; }
and well .. head().getNext() returns the 2nd Player object.
With the code like this i always get an java.lang.StackOverflowError. So i think it means that when i call tail() in my recursive functions it doens'f find the end of the list. But i can't figure out why. Help please
|
Maybe you need to check if the list is 1 or less elements?
|
How is the rest of your linked list implemented, and how are you using it, because I don't see something that should give you a stack overflow there.
Also you should check for null, then make a new list, as you're otherwise making a list that consists of a null player - which probably is not what you want.
|
On December 19 2013 08:06 bangsholt wrote: How is the rest of your linked list implemented, and how are you using it, because I don't see something that should give you a stack overflow there.
Also you should check for null, then make a new list, as you're otherwise making a list that consists of a null player - which probably is not what you want.
Thats the complete class:
+ Show Spoiler + public class PlayerList { private Player firstPlayer;
// constructor for empty list PlayerList() { firstPlayer = null; } // constructor to start list with first player PlayerList(Player playr) { firstPlayer = playr; } // ************************************************************************* // setter for first element void setHead(Player playr) { firstPlayer = playr; } // ************************************************************************* // getter for first element Player head() { return firstPlayer; }
// ************************************************************************* // get rest of list // note: this operation must create a new list (which may be empty = null) PlayerList tail() { PlayerList list = new PlayerList(head().getNext()); if(list.head() == null){ final PlayerList empty = new PlayerList(); return empty; } return list; } // ************************************************************************* // add each new Student at the beginning of the list void addPlayer(Player playr) { playr.setNext(head()); setHead(playr); } // ************************************************************************* // add each new Student recursively at the end of the list void addPlayerLast(Player playr, PlayerList list) { if(list.head().getNext() == null){ list.head().setNext(head().getNext()); } else{ addPlayerLast(playr, tail()); } } // ************************************************************************* void addPlayerLast(Player playr) { addPlayerLast(playr, this); } // ************************************************************************* // recursive print-out of player data (id, family name, first name, goals) void printList(PlayerList list) { if(head() == null){ } else{ //System.out.println(head().toString()); printList(tail()); } } // ************************************************************************* // just call printList(param) to allow for recursion and to keep the interface clean void printList() { printList(this); } // ************************************************************************* // recursive computation of length of list int lengthList(PlayerList list) { if(firstPlayer.getNext() == null){ return 1; } else{ return 1+lengthList(tail()); } } // ************************************************************************* int lengthList() { return lengthList(this); } // ************************************************************************* // recursive computation of sum of ages of all players in the list int sumAge(PlayerList list) { if(firstPlayer.getNext() == null){ return firstPlayer.getAge(); } else{ return head().getAge() + sumAge(tail());
} }
// ************************************************************************* // recursive computation of sum of games of all players in the list int sumAge() { return sumAge(this); }
// ************************************************************************* /** * @param args */ public static void main(String[] args) { PlayerList test = new PlayerList(); Player ilkay = new Player(1, "Guendokan", "Ilkay", 23, "Stauchung"); test.addPlayer(ilkay); Player mats = new Player(2, "Hummels", "Mats", 24, "Baenderriss"); test.addPlayer(mats); Player neven = new Player(3, "Subotic", "Neven", 25, "Kreuzbandriss"); test.addPlayer(neven); Player sven = new Player(4, "Bender", "Sven", 24, "Innenbandanriss"); test.addPlayer(sven); Player nuri = new Player(5, "Sahin", "Nuri", 25, "Sprunggelenk"); test.addPlayer(nuri); System.out.println(test.sumAge()); System.out.println(test.head().getFamilyName()); // testing
//players.printList(); //System.out.println("length of list: " + test.lengthList()); //System.out.println("average age: " + (double) players.sumAge()/players.lengthList() + "\n"); } }
Basically all methods with tail() do not work, the others like addPlayer work.
And regarding that null player list ... that's what it was says in the description: must create a new list (which may be empty = null)
|
On December 19 2013 08:17 Vilanoil wrote:Show nested quote +On December 19 2013 08:06 bangsholt wrote: How is the rest of your linked list implemented, and how are you using it, because I don't see something that should give you a stack overflow there.
Also you should check for null, then make a new list, as you're otherwise making a list that consists of a null player - which probably is not what you want.
Thats the complete class: + Show Spoiler + public class PlayerList { private Player firstPlayer;
// constructor for empty list PlayerList() { firstPlayer = null; } // constructor to start list with first player PlayerList(Player playr) { firstPlayer = playr; } // ************************************************************************* // setter for first element void setHead(Player playr) { firstPlayer = playr; } // ************************************************************************* // getter for first element Player head() { return firstPlayer; }
// ************************************************************************* // get rest of list // note: this operation must create a new list (which may be empty = null) PlayerList tail() { PlayerList list = new PlayerList(head().getNext()); if(list.head() == null){ final PlayerList empty = new PlayerList(); return empty; } return list; } // ************************************************************************* // add each new Student at the beginning of the list void addPlayer(Player playr) { playr.setNext(head()); setHead(playr); } // ************************************************************************* // add each new Student recursively at the end of the list void addPlayerLast(Player playr, PlayerList list) { if(list.head().getNext() == null){ list.head().setNext(head().getNext()); } else{ addPlayerLast(playr, tail()); } } // ************************************************************************* void addPlayerLast(Player playr) { addPlayerLast(playr, this); } // ************************************************************************* // recursive print-out of player data (id, family name, first name, goals) void printList(PlayerList list) { if(head() == null){ } else{ //System.out.println(head().toString()); printList(tail()); } } // ************************************************************************* // just call printList(param) to allow for recursion and to keep the interface clean void printList() { printList(this); } // ************************************************************************* // recursive computation of length of list int lengthList(PlayerList list) { if(firstPlayer.getNext() == null){ return 1; } else{ return 1+lengthList(tail()); } } // ************************************************************************* int lengthList() { return lengthList(this); } // ************************************************************************* // recursive computation of sum of ages of all players in the list int sumAge(PlayerList list) { if(firstPlayer.getNext() == null){ return firstPlayer.getAge(); } else{ return head().getAge() + sumAge(tail());
} }
// ************************************************************************* // recursive computation of sum of games of all players in the list int sumAge() { return sumAge(this); }
// ************************************************************************* /** * @param args */ public static void main(String[] args) { PlayerList test = new PlayerList(); Player ilkay = new Player(1, "Guendokan", "Ilkay", 23, "Stauchung"); test.addPlayer(ilkay); Player mats = new Player(2, "Hummels", "Mats", 24, "Baenderriss"); test.addPlayer(mats); Player neven = new Player(3, "Subotic", "Neven", 25, "Kreuzbandriss"); test.addPlayer(neven); Player sven = new Player(4, "Bender", "Sven", 24, "Innenbandanriss"); test.addPlayer(sven); Player nuri = new Player(5, "Sahin", "Nuri", 25, "Sprunggelenk"); test.addPlayer(nuri); System.out.println(test.sumAge()); System.out.println(test.head().getFamilyName()); // testing
//players.printList(); //System.out.println("length of list: " + test.lengthList()); //System.out.println("average age: " + (double) players.sumAge()/players.lengthList() + "\n"); } }
Basically all methods with tail() do not work, the others like addPlayer work. And regarding that null player list ... that's what it was says in the description: must create a new list (which may be empty = null)
You're sure the issue isn't with your getNext() function?
|
Might want to include your player class as well.
**This might not be totally correct, correct me if I am wrong**
Also one thing with linked lists is that you have to watch the pointers. With your tail method, you make a new list, but with the same objects. If you keep the first list around after calling tail, you could have two lists accessing the same player objects and cause hard to troubleshoot problems if you are not looking for it.
Also, you may want to change your classes so that the linked list class keeps track of next and implements those methods. As it is now, each player object needs to know about another player object and I would say that is the job of your list class.
|
On December 19 2013 03:16 Manit0u wrote:Show nested quote +On December 19 2013 03:05 scudst0rm wrote:On December 19 2013 02:35 Manit0u wrote:Help me please. I'm having a huge brainfart right now... I want to create a small int array with numbers from 1 to 5 in it, but the numbers need to be randomly placed inside the array each time. C doesn't have the shuffle() function so I have to go about it manually but I guess I've been thinking too much about it and can't get it to work... + Show Spoiler + #include <stdlib.h> #include <time.h> #include <stdio.h>
int main (void) { int order[5] = { 0, 0, 0, 0, 0 }; int number = 0;
srand((unsigned int) time(0));
for (int i = 0; i < 5; i += 1) { while (number == order[i] { number = rand() % 6;
if (i >= 1) { for (int j = 0; j < 4; j += 1) { if (number == order[j] { number = rand() % 6; } } } }
order[i] = number;
number = 0;
printf("%d \n", order[i] ; }
return 0; }
It's in ANSI C but if you can give me example on how to go about it in other languages (C++/Java/C# etc.) I'll be able to understand it too. Your while loop condition doesn't make sense. while (number == order[i]) will only be true on the first iteration when both are 0. after that you update number to a random value but order[i] will still be 0. I knew I messed something up with the control statements and placement of things  That's what you get for having 2 minutes at the computer and having to do different stuff for hours inbetween. Show nested quote +On December 19 2013 03:04 Morfildur wrote:On December 19 2013 02:35 Manit0u wrote:Help me please. I'm having a huge brainfart right now... I want to create a small int array with numbers from 1 to 5 in it, but the numbers need to be randomly placed inside the array each time. C doesn't have the shuffle() function so I have to go about it manually but I guess I've been thinking too much about it and can't get it to work... + Show Spoiler + #include <stdlib.h> #include <time.h> #include <stdio.h>
int main (void) { int order[5] = { 0, 0, 0, 0, 0 }; int number = 0;
srand((unsigned int) time(0));
for (int i = 0; i < 5; i += 1) { while (number == order[i] { number = rand() % 6;
if (i >= 1) { for (int j = 0; j < 4; j += 1) { if (number == order[j] { number = rand() % 6; } } } }
order[i] = number;
number = 0;
printf("%d \n", order[i] ; }
return 0; }
It's in ANSI C but if you can give me example on how to go about it in other languages (C++/Java/C# etc.) I'll be able to understand it too. Untested since i'm too lazy, but this is a very simple shuffle implementation: int array[5] = { 1,2,3,4,5 }; for (int i = 0; i < 5; ++i) { int new_pos = rand() % 5; int temp = array[i]; array[i] = array[new_pos]; array[new_pos] = temp; }
Basically, for every element in the array, you pick a random index and exchange the current element with the element at that index. Tried it like that: #include <stdlib.h> #include <time.h> #include <stdio.h>
int main (void) { srand((unsigned int) time(0));
int arr[5] = { 1, 2, 3, 4, 5 }; int n = sizeof(arr);
while (n > 1) { int s = rand() % n; int tmp = arr[n];
n -= 1; arr[s] = arr[n]; arr[n] = tmp; }
for (int i = 0; i < 5; i += 1) { printf("%d, ", arr[i]); }
return 0; }
It compiles just fine but throws the "memory protection error" at me. Any ideas where I went wrong? Edit: This works but not as intended (some of the elements get doubled). srand((unsigned int) time(0));
int arr[5] = { 1, 2, 3, 4, 5 };
for (int i = 0; i < 5; i += 1) { int s = rand() % 5; int tmp = arr[i];
arr[i] = arr[s]; arr[s] = tmp; printf("%d\n", arr[i]); }
Edit2: I'm dumb... Forget about it  Keep in mind that while in the first solution every permutation is equally likely (well, almost... 2^32 or 2^64 is not divisible by 5, but that's negligible...), the second algorithm (by Morfildur) is "incorrect" -- some permutations are less likely than others.
|
On December 19 2013 08:45 WolfintheSheep wrote:Show nested quote +On December 19 2013 08:17 Vilanoil wrote:On December 19 2013 08:06 bangsholt wrote: How is the rest of your linked list implemented, and how are you using it, because I don't see something that should give you a stack overflow there.
Also you should check for null, then make a new list, as you're otherwise making a list that consists of a null player - which probably is not what you want.
Thats the complete class: + Show Spoiler + public class PlayerList { private Player firstPlayer;
// constructor for empty list PlayerList() { firstPlayer = null; } // constructor to start list with first player PlayerList(Player playr) { firstPlayer = playr; } // ************************************************************************* // setter for first element void setHead(Player playr) { firstPlayer = playr; } // ************************************************************************* // getter for first element Player head() { return firstPlayer; }
// ************************************************************************* // get rest of list // note: this operation must create a new list (which may be empty = null) PlayerList tail() { PlayerList list = new PlayerList(head().getNext()); if(list.head() == null){ final PlayerList empty = new PlayerList(); return empty; } return list; } // ************************************************************************* // add each new Student at the beginning of the list void addPlayer(Player playr) { playr.setNext(head()); setHead(playr); } // ************************************************************************* // add each new Student recursively at the end of the list void addPlayerLast(Player playr, PlayerList list) { if(list.head().getNext() == null){ list.head().setNext(head().getNext()); } else{ addPlayerLast(playr, tail()); } } // ************************************************************************* void addPlayerLast(Player playr) { addPlayerLast(playr, this); } // ************************************************************************* // recursive print-out of player data (id, family name, first name, goals) void printList(PlayerList list) { if(head() == null){ } else{ //System.out.println(head().toString()); printList(tail()); } } // ************************************************************************* // just call printList(param) to allow for recursion and to keep the interface clean void printList() { printList(this); } // ************************************************************************* // recursive computation of length of list int lengthList(PlayerList list) { if(firstPlayer.getNext() == null){ return 1; } else{ return 1+lengthList(tail()); } } // ************************************************************************* int lengthList() { return lengthList(this); } // ************************************************************************* // recursive computation of sum of ages of all players in the list int sumAge(PlayerList list) { if(firstPlayer.getNext() == null){ return firstPlayer.getAge(); } else{ return head().getAge() + sumAge(tail());
} }
// ************************************************************************* // recursive computation of sum of games of all players in the list int sumAge() { return sumAge(this); }
// ************************************************************************* /** * @param args */ public static void main(String[] args) { PlayerList test = new PlayerList(); Player ilkay = new Player(1, "Guendokan", "Ilkay", 23, "Stauchung"); test.addPlayer(ilkay); Player mats = new Player(2, "Hummels", "Mats", 24, "Baenderriss"); test.addPlayer(mats); Player neven = new Player(3, "Subotic", "Neven", 25, "Kreuzbandriss"); test.addPlayer(neven); Player sven = new Player(4, "Bender", "Sven", 24, "Innenbandanriss"); test.addPlayer(sven); Player nuri = new Player(5, "Sahin", "Nuri", 25, "Sprunggelenk"); test.addPlayer(nuri); System.out.println(test.sumAge()); System.out.println(test.head().getFamilyName()); // testing
//players.printList(); //System.out.println("length of list: " + test.lengthList()); //System.out.println("average age: " + (double) players.sumAge()/players.lengthList() + "\n"); } }
Basically all methods with tail() do not work, the others like addPlayer work. And regarding that null player list ... that's what it was says in the description: must create a new list (which may be empty = null) You're sure the issue isn't with your getNext() function?
This is the answer - are you by any chance using recursion in getNext(), for some reason? In any case, could we see it?
|
Okay thank you for your help. Here is the Player.class: + Show Spoiler +
public class Player { private int id; private String familyName; private String firstName; private int age; private String injury; private Player next; Player(int id, String familyName, String firstName, int age, String injury, Player next) { this.id = id; this.familyName = familyName; this.firstName = firstName; this.age = age; this.injury = injury; this.next = next; } Player(int id, String familyName, String firstName, int age, String injury) { this(id, familyName, firstName, age, injury, null); }
int getId() { return id; }
void setId(int id) { this.id = id; }
String getFamilyName() { return familyName; }
void setFamilyName(String familyName) { this.familyName = familyName; }
String getFirstName() { return firstName; }
void setFirstName(String firstName) { this.firstName = firstName; }
int getAge() { return age; }
void setAge(int age) { this.age = age; } String getInjury() { return injury; }
void setInjury(String injury) { this.injury = injury; } Player getNext() { return next; }
void setNext(Player next) { this.next = next; } }
|
Could you give the stack trace of the stack overflow?
|
On December 19 2013 06:56 Vilanoil wrote:Hello, i need some help with linked lists in java. It's a program i have to write for my course and i can't find my error. I am not allowed to use the API class for lists. I somehow have a problem with my tail function which has to return a new list with out the head. + Show Spoiler + // get rest of list // note: this operation must create a new list (which may be empty = null) PlayerList tail() { PlayerList list = new PlayerList(head().getNext()); if(list.head() == null) { PlayerList empty = new PlayerList(); return empty; } return list; }
my constructors for the list: + Show Spoiler + // constructor for empty list PlayerList() { firstPlayer = null; } // constructor to start list with first player PlayerList(Player playr) { firstPlayer = playr; }
and well .. head().getNext() returns the 2nd Player object. With the code like this i always get an java.lang.StackOverflowError. So i think it means that when i call tail() in my recursive functions it doens'f find the end of the list. But i can't figure out why. Help please  EDIT: reading on a tablet and didn't reread before I posted lol, ignore me
EDIT2: so after reading more carefully, how long is your linked list? Because the recursive addPlayerLast call basically creates a copy of the linked list for every student in it, taking the first student off every time, which could rapidly cause some things to go crazy since your Player class has a fair bit of data in it... although that's only really a problem if it's a pretty long linked list, it might be worth looking at since you are getting a stack overflow ^^
|
Your main return condition in sumAge is an infinite loop.
hint: which object is head() and tail() getting called on?
|
|
|
|
|
|