c++ source code added.

Excuse me if I don't have much to add, I'm not getting much feedback, and almost ran out of ideas to improve this project.
I guess this is because many people are lured by Blizzard to use the lack of features version (SC:R) which doesn't support BWAPI yet.

sc-darkness

856 Posts

June 02 2018 22:45 GMT

#24

On June 03 2018 06:23 Moataz wrote:
c++ scource code added.

Excuse me if I don't have much to add, I'm not getting much feedback, and almost ran out of ideas to improve this project.
I guess this is because many people are lured by Blizzard to use the lack of features version (SC:R) which doesn't support BWAPI yet.

If you're looking for such feedback, I can help you with improving your C++ code. Just upload it on github or a similar place so I can create a pull request.

Moataz

Egypt267 Posts

June 03 2018 07:08 GMT

#25

Thanks for contribution, sc-darkness, its spaghetti newbie code as I'm only good at c# not c++, check the 1st post.

sc-darkness

856 Posts

June 03 2018 10:02 GMT

#26

On June 03 2018 16:08 Moataz wrote:
Thanks for contribution, sc-darkness, its spaghetti newbie code as I'm only good at c# not c++, check the 1st post.

I've created a quick pull request with my changes. I have some more ideas, but I need to spend more time reading your code and I need to check Coach AI too. I've not played BW for months, I'm playing SC2 right now.

I can create another pull request at some point if you wish. Also, your Visual Studio solution targets Windows 10 SDK (10.0.15063.0), so I had to download it explicitly just to compile. I don't know if that means users also need to have Windows 10 though.

Also, I wanted to remove the following line because I dislike it and I don't think it's advisable, but it's up to you:


using namespace std;

Some motivation to remove it:
https://stackoverflow.com/a/1452738/1091781
https://stackoverflow.com/a/4043963/1091781

Moataz

Egypt267 Posts

June 03 2018 17:54 GMT

#27

What I was thinking about is to have someone take care of the project without needing my approval on changes, then when seeing a suitable update, make it and post the release here for others to see it, take your time.

I have Windows 8.1 64bit, it doesn't need 10, the AI can even work on XP but it needs downgrading the included BWAPI.dll version & "lib" folder.

You can also find active c++ devs and experienced BWAPI AI makers on this Discord channel, if you want any help.

For the lib.7z file, I was facing problems uploading the "lib" folder as whole due to my bad Internet, so I thought it might be easier if compressed, its now deleted from my own repository. But I'm bit confused about the forked version of your own repository, can't we both work on the same repository when needed ?

sc-darkness

856 Posts

June 03 2018 18:42 GMT

#28

Maybe it's possible if you invite me, but I got an error saying I didn't have a permission so I had to create a fork to have a pull request. I'm happy to delete fork though.

In terms of Windows, maybe you have Windows 10 SDK installed even though you have Windows 8? I don't know, it refused to compile for me without the SDK. I either had to modify project settings or install the SDK. Sometimes Visual Studio 2017 installs stuff by default, and the SDK could be one of them.

Moataz

Egypt267 Posts

June 04 2018 18:00 GMT

#29

I sent you an invitation to be Collaborator, got it ?

Moataz

Egypt267 Posts

June 06 2018 17:09 GMT

#30

I didn't got a response from you for a while. Are you still on you words, sc-darkness.

sc-darkness

856 Posts

June 10 2018 20:17 GMT

#31

I've accepted invite. I was just banned temporarily from TL, so I wasn't able to reply. I'll try to make some changes and create a pull request soon though.

Moataz

Egypt267 Posts

June 11 2018 04:57 GMT

#32

Welcome back, awaiting your changes, let me know here or by PM, and don't get banned again.