didnt want to add new rules halfway through though and change who 'would' have won, if I left the rule alone.
fantasy dota site for boston major I made - Page 2
Blogs > ThePianoDentist |
ThePianoDentist
United Kingdom698 Posts
didnt want to add new rules halfway through though and change who 'would' have won, if I left the rule alone. | ||
ThePianoDentist
United Kingdom698 Posts
https://www.fantasydota.eu/battlecup | ||
ThePianoDentist
United Kingdom698 Posts
Winner is liquid92. Pretty sure he is from here. I've added instructions to your profile screen on how to get arcana. Will look to do this again for other tournaments (Definitely going to make tweaks to how hero valuation is done. Will also actually have the time to do some proper features and not rush everything) | ||
Manit0u
Poland17051 Posts
1. You don't really need so many classes in your html with bootstrap (no need to do "col-lg-1 col-md-1 col-sm-1 col-xs-1", if they're all the same you can just put "col-xs-1" - or any other, and it'll propagate to all screen sizes). The same goes for "col-lg-2 col-md-2 col-sm-1 col-xs-1", this can be simply done as "col-md-2 col-sm-1". 2. I don't know what you written this in but usually there are libraries for password resets. 3. What do you mean by "Passwords are encrypted and stored securely"? Something like md5 on a password is not encrypting it... 4. Since you're using bootstrap anyway, why not use its layout (buttons, headers etc.) to enhance the look on the site? Sorry to pester so much but I do those things for a living | ||
shoukichi
Israel2 Posts
Also, grats liquid92. Checked the picks and he's only changed the team once through the tournament (mandatory Alchemist pick), sick predictions. | ||
ThePianoDentist
United Kingdom698 Posts
On December 11 2016 20:19 Manit0u wrote: Just a couple of pointers for the future: 1. You don't really need so many classes in your html with bootstrap (no need to do "col-lg-1 col-md-1 col-sm-1 col-xs-1", if they're all the same you can just put "col-xs-1" - or any other, and it'll propagate to all screen sizes). The same goes for "col-lg-2 col-md-2 col-sm-1 col-xs-1", this can be simply done as "col-md-2 col-sm-1". 2. I don't know what you written this in but usually there are libraries for password resets. 3. What do you mean by "Passwords are encrypted and stored securely"? Something like md5 on a password is not encrypting it... 4. Since you're using bootstrap anyway, why not use its layout (buttons, headers etc.) to enhance the look on the site? Sorry to pester so much but I do those things for a living 1) ok thanks. 2) The website can reset password. The issue is I need SPF and DKIM set up for my server to be able to send emails. Technically this should have been fairly straight-forward. But I managed to spend hours trying it with no luck. Therefore as soon as can get server to send emails which aren't classified as spam, it will have that 3) uses bcrypt. From what I read that is secure 4) Going to make it open source and put it on github tonight | ||
Pontual
Brazil3038 Posts
| ||
sCuMBaG
United Kingdom1144 Posts
Ending up in 9th (top spot #4) isn't too shabby though. I'm definitely in for the next one as well. Well done mate. | ||
| ||